raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-12 03:50:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prettyfy code

Browse Source
This commit is contained in:
Gaetan Craig-Riou
2025-04-09 15:00:41 +10:00
parent 9e1a80c327
commit 157de25f36
1 changed files with 61 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

122
spec/javascripts/stimulus/bulk_form_controller_test.js
View File

@@ -23,16 +23,16 @@ describe("BulkFormController", () => {
// Mock I18n. TODO: moved to a shared helper
beforeAll(() => {
const mockedT = jest.fn();
mockedT.mockImplementation((string, opts) => (string + ', ' + JSON.stringify(opts)));
mockedT.mockImplementation((string, opts) => string + ", " + JSON.stringify(opts));
global.I18n = {
t: mockedT
global.I18n = {
t: mockedT,
};
})
});
// (jest still doesn't have aroundEach https://github.com/jestjs/jest/issues/4543 )
afterAll(() => {
delete global.I18n;
})
});
beforeEach(() => {
document.body.innerHTML = `
@@ -62,17 +62,17 @@ describe("BulkFormController", () => {
describe("marking changed fields", () => {
it("input: onInput", () => {
input1a.value = 'updated1a';
input1a.value = "updated1a";
input1a.dispatchEvent(new Event("input"));
// Expect only first field to show changed
expect(input1a.classList).toContain('changed');
expect(input1b.classList).not.toContain('changed');
expect(input2.classList).not.toContain('changed');
expect(input1a.classList).toContain("changed");
expect(input1b.classList).not.toContain("changed");
expect(input2.classList).not.toContain("changed");
// Change back to original value
input1a.value = 'initial1a';
input1a.value = "initial1a";
input1a.dispatchEvent(new Event("input"));
expect(input1a.classList).not.toContain('changed');
expect(input1a.classList).not.toContain("changed");
});
it("select: onInput", () => {
@@ -81,33 +81,33 @@ describe("BulkFormController", () => {
select1.options[1].selected = false;
select1.dispatchEvent(new Event("input"));
// Expect select to show changed
expect(input1a.classList).not.toContain('changed');
expect(input1b.classList).not.toContain('changed');
expect(select1.classList).toContain('changed');
expect(input1a.classList).not.toContain("changed");
expect(input1b.classList).not.toContain("changed");
expect(select1.classList).toContain("changed");
// Change back to original value
select1.options[0].selected = false;
select1.options[1].selected = true;
select1.dispatchEvent(new Event("input"));
expect(select1.classList).not.toContain('changed');
expect(select1.classList).not.toContain("changed");
});
it("multiple fields", () => {
input1a.value = 'updated1a';
input1a.value = "updated1a";
input1a.dispatchEvent(new Event("input"));
input2.value = 'updated2';
input2.value = "updated2";
input2.dispatchEvent(new Event("input"));
// Expect only first field to show changed
expect(input1a.classList).toContain('changed');
expect(input1b.classList).not.toContain('changed');
expect(input2.classList).toContain('changed');
expect(input1a.classList).toContain("changed");
expect(input1b.classList).not.toContain("changed");
expect(input2.classList).toContain("changed");
// Change only one back to original value
input1a.value = 'initial1a';
input1a.value = "initial1a";
input1a.dispatchEvent(new Event("input"));
expect(input1a.classList).not.toContain('changed');
expect(input1b.classList).not.toContain('changed');
expect(input2.classList).toContain('changed');
expect(input1a.classList).not.toContain("changed");
expect(input1b.classList).not.toContain("changed");
expect(input2.classList).toContain("changed");
});
describe("select not include_blank", () => {
@@ -129,13 +129,13 @@ describe("BulkFormController", () => {
it("shows as changed", () => {
// Expect select to show changed (select-one always has something selected)
expect(select1.classList).toContain('changed');
expect(select1.classList).toContain("changed");
// Change selection
select1.options[0].selected = false;
select1.options[1].selected = true;
select1.dispatchEvent(new Event("input"));
expect(select1.classList).toContain('changed');
expect(select1.classList).toContain("changed");
});
});
@@ -157,75 +157,75 @@ describe("BulkFormController", () => {
});
it("does not show as changed", () => {
expect(select1.classList).not.toContain('changed');
expect(select1.classList).not.toContain("changed");
// Change selection
select1.options[0].selected = false;
select1.options[1].selected = true;
select1.dispatchEvent(new Event("input"));
expect(select1.classList).toContain('changed');
expect(select1.classList).toContain("changed");
});
});
})
});
describe("activating sections, and showing a summary", () => {
// This scenario should probably be broken up into smaller units.
it("counts changed records ", () => {
// Record 1: First field changed
input1a.value = 'updated1a';
input1a.value = "updated1a";
input1a.dispatchEvent(new Event("input"));
// Actions and changed summary are shown, with other sections disabled
expect(actions.classList).not.toContain('hidden');
expect(actions.classList).not.toContain("hidden");
expect(changed_summary.textContent).toBe('changed_summary, {"count":1}');
expect(disable1.classList).toContain('disabled-section');
expect(disable1.classList).toContain("disabled-section");
expect(disable1_element.disabled).toBe(true);
expect(disable2.classList).toContain('disabled-section');
expect(disable2.classList).toContain("disabled-section");
expect(disable2_element.disabled).toBe(true);
// Record 1: Second field changed
input1b.value = 'updated1b';
input1b.value = "updated1b";
input1b.dispatchEvent(new Event("input"));
// Expect to show same summary translation
expect(actions.classList).not.toContain('hidden');
expect(actions.classList).not.toContain("hidden");
expect(changed_summary.textContent).toBe('changed_summary, {"count":1}');
// Record 2: has been changed
input2.value = 'updated2';
input2.value = "updated2";
input2.dispatchEvent(new Event("input"));
// Expect summary to count both records
expect(actions.classList).not.toContain('hidden');
expect(actions.classList).not.toContain("hidden");
expect(changed_summary.textContent).toBe('changed_summary, {"count":2}');
// Record 1: Change first field back to original value
input1a.value = 'initial1a';
input1a.value = "initial1a";
input1a.dispatchEvent(new Event("input"));
// Both records are still changed.
expect(input1a.classList).not.toContain('changed');
expect(input1b.classList).toContain('changed');
expect(input2.classList).toContain('changed');
expect(actions.classList).not.toContain('hidden');
expect(input1a.classList).not.toContain("changed");
expect(input1b.classList).toContain("changed");
expect(input2.classList).toContain("changed");
expect(actions.classList).not.toContain("hidden");
expect(changed_summary.textContent).toBe('changed_summary, {"count":2}');
// Record 1: Change second field back to original value
input1b.value = 'initial1b';
input1b.value = "initial1b";
input1b.dispatchEvent(new Event("input"));
// Both fields for record 1 show unchanged, but second record is still changed
expect(actions.classList).not.toContain('hidden');
expect(actions.classList).not.toContain("hidden");
expect(changed_summary.textContent).toBe('changed_summary, {"count":1}');
expect(disable1.classList).toContain('disabled-section');
expect(disable1.classList).toContain("disabled-section");
expect(disable1_element.disabled).toBe(true);
expect(disable2.classList).toContain('disabled-section');
expect(disable2.classList).toContain("disabled-section");
expect(disable2_element.disabled).toBe(true);
// Record 2: Change back to original value
input2.value = 'initial2';
input2.value = "initial2";
input2.dispatchEvent(new Event("input"));
// Actions are hidden and other sections are now re-enabled
expect(actions.classList).toContain('hidden');
expect(actions.classList).toContain("hidden");
expect(changed_summary.textContent).toBe('changed_summary, {"count":0}');
expect(disable1.classList).not.toContain('disabled-section');
expect(disable1.classList).not.toContain("disabled-section");
expect(disable1_element.disabled).toBe(false);
expect(disable2.classList).not.toContain('disabled-section');
expect(disable2.classList).not.toContain("disabled-section");
expect(disable2_element.disabled).toBe(false);
});
});
@@ -254,19 +254,19 @@ describe("BulkFormController", () => {
it("form actions section remains visible", () => {
// Expect actions to remain visible
expect(actions.classList).not.toContain('hidden');
expect(actions.classList).not.toContain("hidden");
// Record 1: First field changed
input1a.value = 'updated1a';
input1a.value = "updated1a";
input1a.dispatchEvent(new Event("input"));
// Expect actions to remain visible
expect(actions.classList).not.toContain('hidden');
expect(actions.classList).not.toContain("hidden");
// Change back to original value
input1a.value = 'initial1a';
input1a.value = "initial1a";
input1a.dispatchEvent(new Event("input"));
// Expect actions to remain visible
expect(actions.classList).not.toContain('hidden');
expect(actions.classList).not.toContain("hidden");
});
});
@@ -300,18 +300,18 @@ describe("BulkFormController", () => {
});
it("onInput", () => {
input1b.value = 'updated1b';
input1b.value = "updated1b";
input1b.dispatchEvent(new Event("input"));
// Expect only updated field to show changed
expect(input1b.classList).toContain('changed');
expect(input2.classList).not.toContain('changed');
expect(input1b.classList).toContain("changed");
expect(input2.classList).not.toContain("changed");
// Change back to original value
input1b.value = 'initial1b';
input1b.value = "initial1b";
input1b.dispatchEvent(new Event("input"));
expect(input1b.classList).not.toContain('changed');
expect(input1b.classList).not.toContain("changed");
});
})
});
});
// unable to test disconnect at this stage