From 2f562809c090ac09394e49b3648151c6ca0e9abb Mon Sep 17 00:00:00 2001 From: Steve Roberts Date: Wed, 8 Jul 2020 21:31:52 +1000 Subject: [PATCH 1/4] Ensure the hero image doesn't attempt to use the full height of all page content Not sure exactly why this happens, but when the mobile nav is opened the hero image at #tagline:before uses the height of the full window - often around 4000px. Adding max-height of 100% to the nearest safe parent prevents this behaviour. --- app/assets/stylesheets/darkswarm/layout/offcanvas.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/assets/stylesheets/darkswarm/layout/offcanvas.scss b/app/assets/stylesheets/darkswarm/layout/offcanvas.scss index de54f0ef54..f6fe7a0455 100644 --- a/app/assets/stylesheets/darkswarm/layout/offcanvas.scss +++ b/app/assets/stylesheets/darkswarm/layout/offcanvas.scss @@ -15,3 +15,6 @@ transform: none; margin-left: -15.625rem; } +.off-canvas-wrap .inner-wrap { + max-height:100%; +} \ No newline at end of file From 60870a1215af3abb5d093ef873035403a1c6fb7a Mon Sep 17 00:00:00 2001 From: Steve Roberts Date: Tue, 14 Jul 2020 12:58:48 +1000 Subject: [PATCH 2/4] Fix linting errors --- app/assets/stylesheets/darkswarm/layout/offcanvas.scss | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/assets/stylesheets/darkswarm/layout/offcanvas.scss b/app/assets/stylesheets/darkswarm/layout/offcanvas.scss index f6fe7a0455..83c488afab 100644 --- a/app/assets/stylesheets/darkswarm/layout/offcanvas.scss +++ b/app/assets/stylesheets/darkswarm/layout/offcanvas.scss @@ -15,6 +15,7 @@ transform: none; margin-left: -15.625rem; } + .off-canvas-wrap .inner-wrap { - max-height:100%; -} \ No newline at end of file + max-height: 100%; +} From c4d7899a99c5607a0ec3d05acd815e17529b9a8e Mon Sep 17 00:00:00 2001 From: Steve Roberts Date: Tue, 14 Jul 2020 19:26:12 +1000 Subject: [PATCH 3/4] Use vh units for new browsers and align tagline bg to top. --- app/assets/stylesheets/darkswarm/home_tagline.scss | 3 ++- app/assets/stylesheets/darkswarm/layout/offcanvas.scss | 4 ---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/app/assets/stylesheets/darkswarm/home_tagline.scss b/app/assets/stylesheets/darkswarm/home_tagline.scss index c6cc15c9e8..ac187c38f5 100644 --- a/app/assets/stylesheets/darkswarm/home_tagline.scss +++ b/app/assets/stylesheets/darkswarm/home_tagline.scss @@ -17,10 +17,11 @@ position: fixed; left: 0; right: 0; - bottom: 0; + top: 0; z-index: -1; width: 100%; height: 100%; + height: 100vh; } h1 { diff --git a/app/assets/stylesheets/darkswarm/layout/offcanvas.scss b/app/assets/stylesheets/darkswarm/layout/offcanvas.scss index 83c488afab..de54f0ef54 100644 --- a/app/assets/stylesheets/darkswarm/layout/offcanvas.scss +++ b/app/assets/stylesheets/darkswarm/layout/offcanvas.scss @@ -15,7 +15,3 @@ transform: none; margin-left: -15.625rem; } - -.off-canvas-wrap .inner-wrap { - max-height: 100%; -} From dbc7632c4ed2277ed1194100337367fbaeb4052a Mon Sep 17 00:00:00 2001 From: Steve Roberts Date: Wed, 15 Jul 2020 09:52:04 +1000 Subject: [PATCH 4/4] Add inline comment to explain two height properties --- app/assets/stylesheets/darkswarm/home_tagline.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/app/assets/stylesheets/darkswarm/home_tagline.scss b/app/assets/stylesheets/darkswarm/home_tagline.scss index ac187c38f5..7ad1ea0241 100644 --- a/app/assets/stylesheets/darkswarm/home_tagline.scss +++ b/app/assets/stylesheets/darkswarm/home_tagline.scss @@ -21,6 +21,7 @@ z-index: -1; width: 100%; height: 100%; + // Use vh units for new browsers - fixed issue 1253 height: 100vh; }