From 14c32c0d2e23030ceaab114a758f9480ce36de93 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Tue, 10 Sep 2024 16:20:15 +1000 Subject: [PATCH] Reduce complexity --- app/jobs/backorder_job.rb | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/app/jobs/backorder_job.rb b/app/jobs/backorder_job.rb index 914647d7fc..1b73af05c6 100644 --- a/app/jobs/backorder_job.rb +++ b/app/jobs/backorder_job.rb @@ -47,11 +47,7 @@ class BackorderJob < ApplicationJob placed_order = orderer.send_order(backorder) - if orderer.new?(backorder) - wait_until = order.order_cycle.orders_close_at + SALE_SESSION_DELAY - CompleteBackorderJob.set(wait_until:) - .perform_later(user, placed_order.semanticId) - end + schedule_order_completion(user, order, placed_order) if orderer.new?(backorder) # Once we have transformations and know the quantities in bulk products # we will need to increase on_hand by the ordered quantity. @@ -70,6 +66,12 @@ class BackorderJob < ApplicationJob DfcIo.import(catalog_json) end + def self.schedule_order_completion(user, order, placed_order) + wait_until = order.order_cycle.orders_close_at + SALE_SESSION_DELAY + CompleteBackorderJob.set(wait_until:) + .perform_later(user, placed_order.semanticId) + end + def perform(*args) # The ordering logic will live here later. end