From 13cf5d29de78633ca7409e9d76ab467a705a88cb Mon Sep 17 00:00:00 2001 From: Rohan Mitchell Date: Thu, 7 Jul 2016 10:04:11 +1000 Subject: [PATCH] Add guard for selector overflow (only seen in phantom, not selenium/firefox or dev server/chrome) --- .../directives/single_line_selectors.coffee | 3 ++- spec/features/consumer/producers_spec.rb | 17 +++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/darkswarm/directives/single_line_selectors.coffee b/app/assets/javascripts/darkswarm/directives/single_line_selectors.coffee index 04fa639bf4..9cc125a537 100644 --- a/app/assets/javascripts/darkswarm/directives/single_line_selectors.coffee +++ b/app/assets/javascripts/darkswarm/directives/single_line_selectors.coffee @@ -38,7 +38,8 @@ Darkswarm.directive 'singleLineSelectors', ($timeout, $filter) -> loadWidths = -> $(element).find("li").not(".more").each (i) -> - scope.allSelectors[i].width = $(this).outerWidth(true) + if i < scope.allSelectors.length + scope.allSelectors[i].width = $(this).outerWidth(true) return null # So we don't exit the loop weirdly scope.overFlowSelectors = -> diff --git a/spec/features/consumer/producers_spec.rb b/spec/features/consumer/producers_spec.rb index 5c89a23529..4bb8d2d97e 100644 --- a/spec/features/consumer/producers_spec.rb +++ b/spec/features/consumer/producers_spec.rb @@ -55,6 +55,23 @@ feature %q{ page.should_not have_content producer2.name end + describe "filtering by product property" do + it "filters" do + toggle_filters + + toggle_filter 'Organic' + + page.should have_content producer1.name + page.should_not have_content producer2.name + + toggle_filter 'Organic' + toggle_filter 'Biodynamic' + + page.should_not have_content producer1.name + page.should have_content producer2.name + end + end + it "shows all producers with expandable details" do page.should have_content producer1.name expand_active_table_node producer1.name