From c4bc0a7bbd5b5f0e7247373b1d3ee2f13271e201 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Sun, 7 May 2023 14:03:51 +0100
Subject: [PATCH 01/38] Rename select-all-controller

---
 .../order_cycles/checkout_options.html.haml   | 12 +++----
 ...ll_controller.js => checked_controller.js} |  0
 ...ler_test.js => checked_controller_test.js} | 34 +++++++++----------
 3 files changed, 23 insertions(+), 23 deletions(-)
 rename app/webpacker/controllers/{select_all_controller.js => checked_controller.js} (100%)
 rename spec/javascripts/stimulus/{select_all_controller_test.js => checked_controller_test.js} (75%)

diff --git a/app/views/admin/order_cycles/checkout_options.html.haml b/app/views/admin/order_cycles/checkout_options.html.haml
index 80d58be8c6..cc43c1323e 100644
--- a/app/views/admin/order_cycles/checkout_options.html.haml
+++ b/app/views/admin/order_cycles/checkout_options.html.haml
@@ -21,11 +21,11 @@
               = hidden_field_tag "order_cycle[selected_distributor_shipping_method_ids][]", ""
           - @order_cycle.distributors.each do |distributor|
             - distributor_shipping_methods = @order_cycle.attachable_distributor_shipping_methods.where("distributor_id = ?", distributor.id).includes(:shipping_method)
-            %tr{ class: "distributor-#{distributor.id}-shipping-methods", "data-controller": "select-all" }
+            %tr{ class: "distributor-#{distributor.id}-shipping-methods", "data-controller": "checked" }
               %td.text-center
                 - if distributor_shipping_methods.many?
                   %label
-                    = check_box_tag nil, nil, nil, { "data-action": "change->select-all#toggleAll", "data-select-all-target": "all" }
+                    = check_box_tag nil, nil, nil, { "data-action": "change->checked#toggleAll", "data-checked-target": "all" }
                     = t(".select_all")
               %td
                 %em= distributor.name
@@ -36,7 +36,7 @@
                           distributor_shipping_method.id,
                           @order_cycle.distributor_shipping_methods.include?(distributor_shipping_method),
                           id: "order_cycle_selected_distributor_shipping_method_ids_#{distributor_shipping_method.id}",
-                          data: ({ "action" => "change->select-all#toggleCheckbox", "select-all-target" => "checkbox" } if distributor_shipping_method.shipping_method.frontend?)
+                          data: ({ "action" => "change->checked#toggleCheckbox", "checked-target" => "checkbox" } if distributor_shipping_method.shipping_method.frontend?)
                       = distributor_shipping_method.shipping_method.name
                 - distributor.shipping_methods.backend.each do |shipping_method|
                   %label.disabled
@@ -52,11 +52,11 @@
               = hidden_field_tag "order_cycle[selected_distributor_payment_method_ids][]", ""
           - @order_cycle.distributors.each do |distributor|
             - distributor_payment_methods = @order_cycle.attachable_distributor_payment_methods.where("distributor_id = ?", distributor.id).includes(:payment_method)
-            %tr{ class: "distributor-#{distributor.id}-payment-methods", "data-controller": "select-all" }
+            %tr{ class: "distributor-#{distributor.id}-payment-methods", "data-controller": "checked" }
               %td.text-center
                 - if distributor_payment_methods.many?
                   %label
-                    = check_box_tag nil, nil, nil, { "data-action": "change->select-all#toggleAll", "data-select-all-target": "all" }
+                    = check_box_tag nil, nil, nil, { "data-action": "change->checked#toggleAll", "data-checked-target": "all" }
                     = t(".select_all")
               %td
                 %em= distributor.name
@@ -67,7 +67,7 @@
                           distributor_payment_method.id,
                           @order_cycle.distributor_payment_methods.include?(distributor_payment_method),
                           id: "order_cycle_selected_distributor_payment_method_ids_#{distributor_payment_method.id}",
-                          data: ({ "action" => "change->select-all#toggleCheckbox", "select-all-target" => "checkbox" } if distributor_payment_method.payment_method.frontend?)
+                          data: ({ "action" => "change->checked#toggleCheckbox", "checked-target" => "checkbox" } if distributor_payment_method.payment_method.frontend?)
                       = distributor_payment_method.payment_method.name
                 - distributor.payment_methods.inactive_or_backend.each do |payment_method|
                   %label.disabled
diff --git a/app/webpacker/controllers/select_all_controller.js b/app/webpacker/controllers/checked_controller.js
similarity index 100%
rename from app/webpacker/controllers/select_all_controller.js
rename to app/webpacker/controllers/checked_controller.js
diff --git a/spec/javascripts/stimulus/select_all_controller_test.js b/spec/javascripts/stimulus/checked_controller_test.js
similarity index 75%
rename from spec/javascripts/stimulus/select_all_controller_test.js
rename to spec/javascripts/stimulus/checked_controller_test.js
index f7a17b884f..772d519ea0 100644
--- a/spec/javascripts/stimulus/select_all_controller_test.js
+++ b/spec/javascripts/stimulus/checked_controller_test.js
@@ -3,32 +3,32 @@
  */
 
 import { Application } from "stimulus";
-import select_all_controller from "../../../app/webpacker/controllers/select_all_controller";
+import checked_controller from "../../../app/webpacker/controllers/checked_controller";
 
-describe("SelectAllController", () => {
+describe("CheckedController", () => {
   beforeAll(() => {
     const application = Application.start();
-    application.register("select-all", select_all_controller);
+    application.register("checked", checked_controller);
   });
 
   beforeEach(() => {
     document.body.innerHTML = `
-      <div data-controller="select-all">
+      <div data-controller="checked">
         <input
           id="selectAllCheckbox"
           type="checkbox"
-          data-action="change->select-all#toggleAll"
-          data-select-all-target="all">
+          data-action="change->checked#toggleAll"
+          data-checked-target="all">
         <input
           id="checkboxA"
           type="checkbox"
-          data-action="change->select-all#toggleCheckbox"
-          data-select-all-target="checkbox">
+          data-action="change->checked#toggleCheckbox"
+          data-checked-target="checkbox">
         <input
           id="checkboxB"
           type="checkbox"
-          data-action="change->select-all#toggleCheckbox"
-          data-select-all-target="checkbox">
+          data-action="change->checked#toggleCheckbox"
+          data-checked-target="checkbox">
       </div>
     `;
   });
@@ -83,23 +83,23 @@ describe("SelectAllController", () => {
   describe("#connect", () => {
     beforeEach(() => {
       document.body.innerHTML = `
-        <div data-controller="select-all">
+        <div data-controller="checked">
           <input
             id="selectAllCheckbox"
             type="checkbox"
-            data-action="change->select-all#toggleAll"
-            data-select-all-target="all">
+            data-action="change->checked#toggleAll"
+            data-checked-target="all">
           <input
             id="checkboxA"
             type="checkbox"
-            data-action="change->select-all#toggleCheckbox"
-            data-select-all-target="checkbox"
+            data-action="change->checked#toggleCheckbox"
+            data-checked-target="checkbox"
             checked="checked">
           <input
             id="checkboxB"
             type="checkbox"
-            data-action="change->select-all#toggleCheckbox"
-            data-select-all-target="checkbox"
+            data-action="change->checked#toggleCheckbox"
+            data-checked-target="checkbox"
             checked="checked">
         </div>
       `;

From f181b35a905bd63d4f536157acf817eb5dc4d3aa Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Sun, 7 May 2023 23:39:47 +0100
Subject: [PATCH 02/38] Add minimal admin js setup

---
 app/assets/javascripts/admin_minimal.js       | 44 +++++++++++++++++++
 app/views/spree/admin/orders/index.html.haml  |  4 +-
 app/views/spree/admin/shared/_head.html.haml  |  8 ++--
 .../spree/admin/shared/_translations.html.erb |  3 ++
 config/application.rb                         |  2 +-
 5 files changed, 56 insertions(+), 5 deletions(-)
 create mode 100644 app/assets/javascripts/admin_minimal.js

diff --git a/app/assets/javascripts/admin_minimal.js b/app/assets/javascripts/admin_minimal.js
new file mode 100644
index 0000000000..d438957f34
--- /dev/null
+++ b/app/assets/javascripts/admin_minimal.js
@@ -0,0 +1,44 @@
+// This is a manifest file that'll be compiled into including all the files listed below.
+// Add new JavaScript/Coffee code in separate files in this directory and they'll automatically
+// be included in the compiled file accessible from http://example.com/assets/application.js
+// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
+// the compiled file.
+//
+
+//= require jquery2
+//= require admin/spree/spree-select2
+//= require admin/spree/handlebar_extensions
+
+//= require i18n/translations
+//= require darkswarm/i18n.translate.js
+//= require moment/min/moment.min.js
+//= require moment/locale/ar.js
+//= require moment/locale/ca.js
+//= require moment/locale/de.js
+//= require moment/locale/en-gb.js
+//= require moment/locale/es.js
+//= require moment/locale/fil.js
+//= require moment/locale/fr.js
+//= require moment/locale/it.js
+//= require moment/locale/nb.js
+//= require moment/locale/nl-be.js
+//= require moment/locale/pt-br.js
+//= require moment/locale/pt.js
+//= require moment/locale/ru.js
+//= require moment/locale/sv.js
+//= require moment/locale/tr.js
+//= require moment/locale/pl.js
+
+//= require js-big-decimal/dist/web/js-big-decimal.min.js
+
+window.angular = { module: function(noop){ return { value: function(){} } } }
+
+document.addEventListener("ajax:beforeSend", (event) => {
+  window.Turbo.navigator.adapter.progressBar.setValue(0)
+  window.Turbo.navigator.adapter.progressBar.show()
+})
+
+document.addEventListener("ajax:complete", (event) => {
+  window.Turbo.navigator.adapter.progressBar.setValue(100)
+  window.Turbo.navigator.adapter.progressBar.hide()
+})
\ No newline at end of file
diff --git a/app/views/spree/admin/orders/index.html.haml b/app/views/spree/admin/orders/index.html.haml
index 33224c8957..5c55106a03 100644
--- a/app/views/spree/admin/orders/index.html.haml
+++ b/app/views/spree/admin/orders/index.html.haml
@@ -1,6 +1,8 @@
 - content_for :page_title do
   = t('.listing_orders')
 
+- content_for :minimal_js, true
+
 - content_for :page_actions do
   %li
     = button_link_to t('.new_order'), spree.new_admin_order_url, icon: 'icon-plus', id: 'admin_new_order'
@@ -42,7 +44,7 @@
           %div.menu_item
             %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "cancel_orders" }
               = t('.cancel_orders')
-    
+
     = render partial: 'admin/shared/angular_per_page_controls', locals: { position: "right", model: "orders" }
 
 %table#listing_orders.index.responsive{width: "100%", 'ng-init' => 'initialise()', 'ng-show' => "!RequestMonitor.loading && orders.length > 0" }
diff --git a/app/views/spree/admin/shared/_head.html.haml b/app/views/spree/admin/shared/_head.html.haml
index 238052154e..ec9ea94fb5 100644
--- a/app/views/spree/admin/shared/_head.html.haml
+++ b/app/views/spree/admin/shared/_head.html.haml
@@ -3,8 +3,6 @@
 = csrf_meta_tags
 = action_cable_meta_tag
 
-= action_cable_meta_tag
-
 %title
   - if content_for? :html_title
     = yield :html_title
@@ -16,7 +14,11 @@
 
 = stylesheet_pack_tag 'admin-styles', media: "screen, print"
 = render "layouts/bugsnag_js"
-= javascript_include_tag 'admin/all'
+
+- if content_for? :minimal_js
+  = javascript_include_tag 'admin_minimal'
+- else
+  = javascript_include_tag 'admin/all'
 
 = render "spree/admin/shared/translations"
 = render "spree/admin/shared/routes"
diff --git a/app/views/spree/admin/shared/_translations.html.erb b/app/views/spree/admin/shared/_translations.html.erb
index 97eae43d00..96183fd864 100644
--- a/app/views/spree/admin/shared/_translations.html.erb
+++ b/app/views/spree/admin/shared/_translations.html.erb
@@ -1,4 +1,7 @@
 <script>
+  if (Spree === undefined) {
+    var Spree = {}
+  }
   Spree.translations = <%==
   {:flatpickr_date_format    => Spree.t(:flatpickr_date_format,
                               :scope => 'date_picker',
diff --git a/config/application.rb b/config/application.rb
index 13e94443fe..7ea51da3e5 100644
--- a/config/application.rb
+++ b/config/application.rb
@@ -209,7 +209,7 @@ module Openfoodnetwork
     # Instead, they must be explicitly included below
     # http://stackoverflow.com/questions/8012434/what-is-the-purpose-of-config-assets-precompile
     config.assets.initialize_on_precompile = true
-    config.assets.precompile += ['admin/*.js', 'admin/**/*.js']
+    config.assets.precompile += ['admin/*.js', 'admin/**/*.js', 'admin_minimal.js']
     config.assets.precompile += ['web/all.js']
     config.assets.precompile += ['darkswarm/all.js']
     config.assets.precompile += ['shared/*']

From 48a8f57262e054eb3f406838ac89486b3ab4ad09 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 10 May 2023 14:16:27 +0100
Subject: [PATCH 03/38] Prep admin JS

---
 app/views/spree/layouts/admin.html.haml      |  2 +-
 app/views/spree/layouts/bare_admin.html.haml |  2 +-
 app/webpacker/packs/admin.js                 | 22 ++++++++------------
 3 files changed, 11 insertions(+), 15 deletions(-)

diff --git a/app/views/spree/layouts/admin.html.haml b/app/views/spree/layouts/admin.html.haml
index ad070e473c..98e7cb9ebd 100644
--- a/app/views/spree/layouts/admin.html.haml
+++ b/app/views/spree/layouts/admin.html.haml
@@ -3,7 +3,7 @@
   %head
     = render :partial => 'spree/admin/shared/head'
 
-  %body.admin
+  %body.admin{ "data-turbo": "false" }
     - if content_for?(:main_ng_app_name)
       - if content_for?(:main_ng_ctrl_name)
         %div{ "ng-app" => yield(:main_ng_app_name).strip.html_safe, "ng-controller" => yield(:main_ng_ctrl_name).strip.html_safe }
diff --git a/app/views/spree/layouts/bare_admin.html.haml b/app/views/spree/layouts/bare_admin.html.haml
index ee861eef15..db744183f1 100644
--- a/app/views/spree/layouts/bare_admin.html.haml
+++ b/app/views/spree/layouts/bare_admin.html.haml
@@ -1,6 +1,6 @@
 %html{ lang: "en", "ng-csp": "no-unsafe-eval" }
   %head= render :partial => 'spree/admin/shared/head'
-  %body.admin{"data-ajax-root-path" => main_app.root_path}
+  %body.admin{"data-turbo": "false", "data-ajax-root-path": main_app.root_path}
     #wrapper
       - if flash[:error]
         .flash.error= flash[:error]
diff --git a/app/webpacker/packs/admin.js b/app/webpacker/packs/admin.js
index b0a44a4fe9..efb841fdc0 100644
--- a/app/webpacker/packs/admin.js
+++ b/app/webpacker/packs/admin.js
@@ -1,18 +1,14 @@
-import { Application } from "stimulus";
-import { definitionsFromContext } from "stimulus/webpack-helpers";
+import "controllers";
+import "channels";
 
-const application = Application.start();
-const context = require.context("controllers", true, /.js$/);
-application.load(definitionsFromContext(context));
+import "@hotwired/turbo";
+import CableReady from "cable_ready";
+import mrujs from "mrujs";
+import { CableCar } from "mrujs/plugins";
 
-import StimulusReflex from "stimulus_reflex";
-import consumer from "../channels/consumer";
-import controller from "../controllers/application_controller";
-
-application.consumer = consumer;
-StimulusReflex.initialize(application, { controller, isolate: true });
-StimulusReflex.debug = process.env.RAILS_ENV === "development";
-CableReady.initialize({ consumer });
+mrujs.start({
+  plugins: [new CableCar(CableReady, { mimeType: "text/vnd.cable-ready.json" })],
+});
 
 import debounced from "debounced";
 debounced.initialize({ input: { wait: 300 } });

From 59fd4ad251993e9057e1baea0fb904080190662c Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Thu, 11 May 2023 17:14:57 +0100
Subject: [PATCH 04/38] Tidy up JS imports

---
 app/assets/javascripts/admin_minimal.js        | 12 +-----------
 app/assets/javascripts/darkswarm/all.js.coffee |  8 --------
 app/webpacker/js/mrujs.js                      | 17 +++++++++++++++++
 app/webpacker/packs/admin.js                   |  9 +--------
 app/webpacker/packs/application.js             | 18 +++---------------
 5 files changed, 22 insertions(+), 42 deletions(-)
 create mode 100644 app/webpacker/js/mrujs.js

diff --git a/app/assets/javascripts/admin_minimal.js b/app/assets/javascripts/admin_minimal.js
index d438957f34..2a6b52ddac 100644
--- a/app/assets/javascripts/admin_minimal.js
+++ b/app/assets/javascripts/admin_minimal.js
@@ -31,14 +31,4 @@
 
 //= require js-big-decimal/dist/web/js-big-decimal.min.js
 
-window.angular = { module: function(noop){ return { value: function(){} } } }
-
-document.addEventListener("ajax:beforeSend", (event) => {
-  window.Turbo.navigator.adapter.progressBar.setValue(0)
-  window.Turbo.navigator.adapter.progressBar.show()
-})
-
-document.addEventListener("ajax:complete", (event) => {
-  window.Turbo.navigator.adapter.progressBar.setValue(100)
-  window.Turbo.navigator.adapter.progressBar.hide()
-})
\ No newline at end of file
+window.angular = { module: function(noop){ return { value: function(){} } } }
\ No newline at end of file
diff --git a/app/assets/javascripts/darkswarm/all.js.coffee b/app/assets/javascripts/darkswarm/all.js.coffee
index dfaf65a185..0797cfd99b 100644
--- a/app/assets/javascripts/darkswarm/all.js.coffee
+++ b/app/assets/javascripts/darkswarm/all.js.coffee
@@ -67,11 +67,3 @@ document.addEventListener "turbo:before-render", ->
     rootscope = null
     window.injector = null
   true
-
-document.addEventListener "ajax:beforeSend", (event) =>
-  window.Turbo.navigator.adapter.progressBar.setValue(0)
-  window.Turbo.navigator.adapter.progressBar.show()
-
-document.addEventListener "ajax:complete", (event) =>
-  window.Turbo.navigator.adapter.progressBar.setValue(100)
-  window.Turbo.navigator.adapter.progressBar.hide()
diff --git a/app/webpacker/js/mrujs.js b/app/webpacker/js/mrujs.js
new file mode 100644
index 0000000000..c2702a9992
--- /dev/null
+++ b/app/webpacker/js/mrujs.js
@@ -0,0 +1,17 @@
+import CableReady from "cable_ready";
+import mrujs from "mrujs";
+import { CableCar } from "mrujs/plugins";
+
+mrujs.start({
+  plugins: [new CableCar(CableReady, { mimeType: "text/vnd.cable-ready.json" })],
+});
+
+document.addEventListener("ajax:beforeSend", (event) => {
+  window.Turbo.navigator.adapter.progressBar.setValue(0);
+  window.Turbo.navigator.adapter.progressBar.show();
+});
+
+document.addEventListener("ajax:complete", (event) => {
+  window.Turbo.navigator.adapter.progressBar.setValue(100);
+  window.Turbo.navigator.adapter.progressBar.hide();
+});
diff --git a/app/webpacker/packs/admin.js b/app/webpacker/packs/admin.js
index efb841fdc0..f0394256b3 100644
--- a/app/webpacker/packs/admin.js
+++ b/app/webpacker/packs/admin.js
@@ -1,14 +1,7 @@
 import "controllers";
 import "channels";
-
 import "@hotwired/turbo";
-import CableReady from "cable_ready";
-import mrujs from "mrujs";
-import { CableCar } from "mrujs/plugins";
-
-mrujs.start({
-  plugins: [new CableCar(CableReady, { mimeType: "text/vnd.cable-ready.json" })],
-});
+import "../js/mrujs";
 
 import debounced from "debounced";
 debounced.initialize({ input: { wait: 300 } });
diff --git a/app/webpacker/packs/application.js b/app/webpacker/packs/application.js
index 66a2fd7cb5..9d784fc502 100644
--- a/app/webpacker/packs/application.js
+++ b/app/webpacker/packs/application.js
@@ -1,19 +1,7 @@
-/* eslint no-console:0 */
-import CableReady from "cable_ready";
-import mrujs from "mrujs";
-import { CableCar } from "mrujs/plugins";
-import * as Turbo from "@hotwired/turbo";
-
-window.Turbo = Turbo;
-window.CableReady = CableReady;
-mrujs.start({
-  plugins: [
-    new CableCar(CableReady, { mimeType: "text/vnd.cable-ready.json" }),
-  ],
-});
+import "controllers";
+import "@hotwired/turbo";
+import "../js/mrujs";
 
 require.context("../fonts", true);
 const images = require.context("../images", true);
 const imagePath = (name) => images(name, true);
-
-import "controllers";

From 3df166fb2f382f1f1b73e15d56ffae429a1f7cfa Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 10 May 2023 13:43:09 +0100
Subject: [PATCH 05/38] Drop jquery_ujs

---
 app/assets/javascripts/admin/all.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/app/assets/javascripts/admin/all.js b/app/assets/javascripts/admin/all.js
index 0f0643d388..739dff3f73 100644
--- a/app/assets/javascripts/admin/all.js
+++ b/app/assets/javascripts/admin/all.js
@@ -7,7 +7,6 @@
 
 // jquery and angular
 //= require jquery2
-//= require jquery_ujs
 //= require jquery.ui.all
 //= require jquery.powertip
 //= require jquery.cookie

From 5ad68f25e310d3de33e0c95e5f2225afd778bca4 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Sat, 20 May 2023 19:28:07 +0100
Subject: [PATCH 06/38] Handle old jquery_ujs buttons

---
 .../templates/admin/links_dropdown.html.haml    | 17 +++++++++++++----
 .../enterprises/form/_stripe_connect.html.haml  |  3 ++-
 app/views/admin/oidc_settings/index.html.haml   |  2 +-
 app/views/admin/order_cycles/_row.html.haml     |  2 +-
 app/views/admin/order_cycles/edit.html.haml     |  3 ++-
 .../admin/subscriptions/_autocomplete.html.haml |  2 +-
 .../admin/terms_of_service_files/show.html.haml |  2 +-
 .../spree/admin/mail_methods/edit.html.haml     |  3 ++-
 app/views/spree/admin/payments/_list.html.haml  |  3 ++-
 .../admin/return_authorizations/edit.html.haml  |  6 ++++--
 app/webpacker/js/mrujs.js                       | 11 +++++++++++
 11 files changed, 40 insertions(+), 14 deletions(-)

diff --git a/app/assets/javascripts/templates/admin/links_dropdown.html.haml b/app/assets/javascripts/templates/admin/links_dropdown.html.haml
index 1f4f8e4f47..afcaa1e8da 100644
--- a/app/assets/javascripts/templates/admin/links_dropdown.html.haml
+++ b/app/assets/javascripts/templates/admin/links_dropdown.html.haml
@@ -4,7 +4,16 @@
     {{ 'admin.actions' | t }}
     %i{ 'ng-class' => "expanded && 'icon-caret-up' || !expanded && 'icon-caret-down'" }
   %div.menu{ 'ng-show' => "expanded" }
-    %a.menu_item{ 'ng-repeat' => "link in links", href: '{{link.url}}', target: "{{link.target || '_self'}}", data: { method: "{{ link.method || 'get' }}", confirm: "{{link.confirm}}" } }
-      %span
-        %i{ ng: { class: "link.icon" } }
-      %span {{ link.name }}
+    %div{ 'ng-repeat' => "link in links" }
+      %a.menu_item{ 'ng-if': "link.method", href: '{{link.url}}', target: "{{link.target || '_self'}}", data: { method: "{{ link.method }}", "ujs-navigate": "false", confirm: "{{link.confirm}}" } }
+        %span
+          %i{ ng: { class: "link.icon" } }
+        %span {{ link.name }}
+      %a.menu_item{ 'ng-if': "link.confirm && !link.method", href: '{{link.url}}', target: "{{link.target || '_self'}}", "data-confirm": "{{link.confirm}}" }
+        %span
+          %i{ ng: { class: "link.icon" } }
+        %span {{ link.name }}
+      %a.menu_item{ 'ng-if': "!link.confirm && !link.method", href: '{{link.url}}', target: "{{link.target || '_self'}}" }
+        %span
+          %i{ ng: { class: "link.icon" } }
+        %span {{ link.name }}
diff --git a/app/views/admin/enterprises/form/_stripe_connect.html.haml b/app/views/admin/enterprises/form/_stripe_connect.html.haml
index 5c42499718..ec8e1e178b 100644
--- a/app/views/admin/enterprises/form/_stripe_connect.html.haml
+++ b/app/views/admin/enterprises/form/_stripe_connect.html.haml
@@ -4,7 +4,8 @@
     .row
       = t('.stripe_account_connected')
     .row
-      =link_to t('.disconnect'), main_app.admin_stripe_account_path(@stripe_account), method: :delete, class: 'button'
+
+      =link_to t('.disconnect'), main_app.admin_stripe_account_path(@stripe_account), data: { method: :delete, "ujs-navigate": "false"}, class: 'button'
 - else
   .row.stripe-info
     .six.columns.alpha
diff --git a/app/views/admin/oidc_settings/index.html.haml b/app/views/admin/oidc_settings/index.html.haml
index 4a6878eed6..eed72c78d2 100644
--- a/app/views/admin/oidc_settings/index.html.haml
+++ b/app/views/admin/oidc_settings/index.html.haml
@@ -22,4 +22,4 @@
     %br
     = button_to t(".link_account_button"),
       Spree::Core::Engine.routes.url_helpers.spree_user_openid_connect_omniauth_authorize_path(auth_type: "login"),
-      method: :post
+      data: { method: :post, "ujs-navigate": "false" }
diff --git a/app/views/admin/order_cycles/_row.html.haml b/app/views/admin/order_cycles/_row.html.haml
index 5a2e06dbb6..4508858a1d 100644
--- a/app/views/admin/order_cycles/_row.html.haml
+++ b/app/views/admin/order_cycles/_row.html.haml
@@ -36,4 +36,4 @@
   %td.actions{ ng: { if: 'orderCycle.viewing_as_coordinator' } }
     %a.clone-order-cycle.icon-copy.no-text{ ng: { href: '{{orderCycle.clone_path}}'}, 'ofn-with-tip' => t(:clone) }
   %td.actions{ ng: { if: 'orderCycle.deletable && orderCycle.viewing_as_coordinator' }}
-    %a.delete-order-cycle.icon-trash.no-text{ ng: { href: '{{orderCycle.delete_path}}'}, data: { method: 'delete', confirm: t(:are_you_sure) }, 'ofn-with-tip' => t(:remove) }
+    %a.delete-order-cycle.icon-trash.no-text{ ng: { href: '{{orderCycle.delete_path}}'}, data: { method: 'delete', confirm: t(:are_you_sure), "ujs-navigate": "false" }, 'ofn-with-tip' => t(:remove) }
diff --git a/app/views/admin/order_cycles/edit.html.haml b/app/views/admin/order_cycles/edit.html.haml
index 56151db299..3dcc757370 100644
--- a/app/views/admin/order_cycles/edit.html.haml
+++ b/app/views/admin/order_cycles/edit.html.haml
@@ -5,7 +5,8 @@
       - mails_sent = @order_cycle.mails_sent?
       - url = main_app.notify_producers_admin_order_cycle_path
       - confirm_msg = "#{t('.notify_producers_tip')} #{t(:are_you_sure)}"
-      %a.button.icon-email.with-tip{ href: url, data: { method: 'post', confirm: confirm_msg }, 'data-powertip': t('.notify_producers_tip') }
+
+      %a.button.icon-email.with-tip{ href: url, data: { method: :post, "ujs-navigate": "false", confirm: confirm_msg }, 'data-powertip': t('.notify_producers_tip') }
         = mails_sent ? t('.re_notify_producers') : t(:notify_producers)
         - if mails_sent
           .badge.icon-ok.success
diff --git a/app/views/admin/subscriptions/_autocomplete.html.haml b/app/views/admin/subscriptions/_autocomplete.html.haml
index 789f27104c..784c77009e 100644
--- a/app/views/admin/subscriptions/_autocomplete.html.haml
+++ b/app/views/admin/subscriptions/_autocomplete.html.haml
@@ -16,5 +16,5 @@
             %input#add_quantity.fullwidth{ type: 'number', min: 1, ng: { model: 'newItem.quantity' } }
         %td
           .actions
-            %a.icon-plus.button.fullwidth{ href: 'javascript:void(0)', method: :post, ng: { click: 'addSubscriptionLineItem()' } }
+            %a.icon-plus.button.fullwidth{ href: 'javascript:void(0)', ng: { click: 'addSubscriptionLineItem()' } }
               = t('.add')
diff --git a/app/views/admin/terms_of_service_files/show.html.haml b/app/views/admin/terms_of_service_files/show.html.haml
index 68373724a0..2f3c5b387b 100644
--- a/app/views/admin/terms_of_service_files/show.html.haml
+++ b/app/views/admin/terms_of_service_files/show.html.haml
@@ -7,7 +7,7 @@
 .admin-current-terms-of-service
   - if @current_file
     %p= t(".current_terms_html", tos_link: link_to(t(".terms_of_service"), @current_file.attachment), datetime: @current_file.updated_at)
-    %p= link_to t(".delete"), main_app.admin_terms_of_service_files_path, method: "delete", data: { confirm: t(".confirm_delete") }
+    %p= link_to t(".delete"), main_app.admin_terms_of_service_files_path, data: { method: :delete, "ujs-navigate": "false", confirm: t(".confirm_delete") }
   - else
     %p
       = t(".no_files")
diff --git a/app/views/spree/admin/mail_methods/edit.html.haml b/app/views/spree/admin/mail_methods/edit.html.haml
index 9e79403270..5a03702c21 100644
--- a/app/views/spree/admin/mail_methods/edit.html.haml
+++ b/app/views/spree/admin/mail_methods/edit.html.haml
@@ -5,7 +5,8 @@
 
 - content_for :page_actions do
   %li
-    = link_to_with_icon 'icon-envelope-alt', t("spree.admin.mail_methods.send_testmail"), testmail_admin_mail_methods_path, method: :post, title: t("spree.admin.mail_methods.send_testmail"), class: 'send_mail button no-text'
+    = link_to_with_icon 'icon-envelope-alt', t("spree.admin.mail_methods.send_testmail"), testmail_admin_mail_methods_path,
+    data: { method: :post, "ujs-navigate": "false" }, title: t("spree.admin.mail_methods.send_testmail"), class: 'send_mail button no-text'
 
 = render partial: 'spree/shared/error_messages', locals: { target: @mail_method }
 
diff --git a/app/views/spree/admin/payments/_list.html.haml b/app/views/spree/admin/payments/_list.html.haml
index 6daa450eca..4e1a1ec066 100644
--- a/app/views/spree/admin/payments/_list.html.haml
+++ b/app/views/spree/admin/payments/_list.html.haml
@@ -16,4 +16,5 @@
           %span{class: "state #{payment.state}"}= t(payment.state, scope: "spree.payment_states", default: payment.state.capitalize)
         %td.actions
           - payment.actions.each do |action|
-            = link_to_with_icon "icon-#{action}", Spree.t(action), fire_admin_order_payment_path(@order, payment, e: action), method: :put, no_text: true, data: {action: action, disable_with: ""}
+            = link_to_with_icon "icon-#{action}", Spree.t(action), fire_admin_order_payment_path(@order, payment, e: action),
+            no_text: true, data: { method: :put, "ujs-navigate": "false", action: action, disable_with: "" }
diff --git a/app/views/spree/admin/return_authorizations/edit.html.haml b/app/views/spree/admin/return_authorizations/edit.html.haml
index 71c32c0ab3..190e6e31c5 100644
--- a/app/views/spree/admin/return_authorizations/edit.html.haml
+++ b/app/views/spree/admin/return_authorizations/edit.html.haml
@@ -1,10 +1,12 @@
 - content_for :page_actions do
   %li
     - if @return_authorization.can_receive?
-      = button_link_to t('.receive'), fire_admin_order_return_authorization_url(@order, @return_authorization, e: 'receive'), method: :put, data: { confirm: t('.are_you_sure') }, icon: 'icon-download-alt'
+      = button_link_to t('.receive'), fire_admin_order_return_authorization_url(@order, @return_authorization, e: 'receive'),
+      data: { method: :put, "ujs-navigate": "false", confirm: t('.are_you_sure') }, icon: 'icon-download-alt'
   %li
     - if @return_authorization.can_cancel?
-      = button_link_to t('actions.cancel'), fire_admin_order_return_authorization_url(@order, @return_authorization, e: 'cancel'), method: :put, data: { confirm: t('.are_you_sure') }, icon: 'icon-remove'
+      = button_link_to t('actions.cancel'), fire_admin_order_return_authorization_url(@order, @return_authorization, e: 'cancel'),
+      data: { method: :put, "ujs-navigate": "false", confirm: t('.are_you_sure') }, icon: 'icon-remove'
 
 = render partial: 'spree/admin/shared/order_page_title'
 = render partial: 'spree/admin/shared/order_tabs', locals: { current: 'Return Authorizations' }
diff --git a/app/webpacker/js/mrujs.js b/app/webpacker/js/mrujs.js
index c2702a9992..602fc56ca4 100644
--- a/app/webpacker/js/mrujs.js
+++ b/app/webpacker/js/mrujs.js
@@ -6,6 +6,17 @@ mrujs.start({
   plugins: [new CableCar(CableReady, { mimeType: "text/vnd.cable-ready.json" })],
 });
 
+// Handle legacy jquery ujs buttons
+document.addEventListener("ajax:beforeNavigation", (event) => {
+  if (event.detail.element.dataset.ujsNavigate !== "false") return;
+
+  event.preventDefault();
+
+  if (event.detail.fetchResponse.response.redirected) {
+    document.location.href = event.detail.fetchResponse.response.url;
+  }
+});
+
 document.addEventListener("ajax:beforeSend", (event) => {
   window.Turbo.navigator.adapter.progressBar.setValue(0);
   window.Turbo.navigator.adapter.progressBar.show();

From 048df6230b62b8d01a7d96c7620e919f67c596e0 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 10 May 2023 14:16:56 +0100
Subject: [PATCH 07/38] Remove angular from admin orders index page

---
 .../product_component.html.haml               |   2 +-
 .../spree/admin/orders_controller.rb          |  27 ++
 app/services/search_orders.rb                 |   2 +-
 .../shared/_stimulus_page_controls.html.haml  |   8 +
 .../shared/_stimulus_pagination.html.haml     |  22 ++
 .../admin/orders/_bulk_actions.html.haml      |  20 ++
 .../spree/admin/orders/_filters.html.haml     |  53 +--
 app/views/spree/admin/orders/_table.html.haml |  30 ++
 .../spree/admin/orders/_table_row.html.haml   |  48 +++
 app/views/spree/admin/orders/index.html.haml  | 110 +-----
 .../_stimulus_sortable_header.html.haml       |   8 +
 app/views/spree/admin/shared/_tabs.html.haml  |   2 +-
 .../controllers/cancel_orders_controller.js   |   9 +-
 .../controllers/checked_controller.js         |  28 +-
 .../controllers/ephemeral_controller.js       |  16 +
 .../controllers/search_controller.js          |  68 ++++
 app/webpacker/css/admin/animations.scss       |  10 +
 .../css/admin/components/buttons.scss         |   2 +-
 .../admin/components/per_page_controls.scss   |   4 +
 .../css/admin/components/tom_select.scss      |  13 +
 app/webpacker/css/admin/dropdown.scss         | 327 ++++++++++--------
 app/webpacker/css/admin/shared/forms.scss     |  45 ++-
 config/locales/en.yml                         |   1 +
 23 files changed, 538 insertions(+), 317 deletions(-)
 create mode 100644 app/views/admin/shared/_stimulus_page_controls.html.haml
 create mode 100644 app/views/admin/shared/_stimulus_pagination.html.haml
 create mode 100644 app/views/spree/admin/orders/_bulk_actions.html.haml
 create mode 100644 app/views/spree/admin/orders/_table.html.haml
 create mode 100644 app/views/spree/admin/orders/_table_row.html.haml
 create mode 100644 app/views/spree/admin/shared/_stimulus_sortable_header.html.haml
 create mode 100644 app/webpacker/controllers/ephemeral_controller.js
 create mode 100644 app/webpacker/controllers/search_controller.js

diff --git a/app/components/product_component/product_component.html.haml b/app/components/product_component/product_component.html.haml
index e0d9d760a8..55c3e47e67 100644
--- a/app/components/product_component/product_component.html.haml
+++ b/app/components/product_component/product_component.html.haml
@@ -1,6 +1,6 @@
 %tr
   - @columns.each do |column|
     %td.products_column{class: column[:id]}
-      - if column[:id] == "name" && @image
+      - if column[:id] == "name" && @image&.attachment.present?
         = image_tag @image.url(:mini)
       = column[:value]
diff --git a/app/controllers/spree/admin/orders_controller.rb b/app/controllers/spree/admin/orders_controller.rb
index 51a21a8b60..43cbdf2d9c 100644
--- a/app/controllers/spree/admin/orders_controller.rb
+++ b/app/controllers/spree/admin/orders_controller.rb
@@ -5,6 +5,7 @@ require 'open_food_network/spree_api_key_loader'
 module Spree
   module Admin
     class OrdersController < Spree::Admin::BaseController
+      include CablecarResponses
       include OpenFoodNetwork::SpreeApiKeyLoader
       helper CheckoutHelper
 
@@ -16,6 +17,13 @@ module Spree
 
       respond_to :html, :json
 
+      def index
+        orders = SearchOrders.new(search_params, spree_current_user).orders
+        @pagy, @orders = pagy(orders, items: params[:per_page] || 15)
+
+        update_search_results if searching?
+      end
+
       def new
         @order = Order.create
         @order.created_by = spree_current_user
@@ -110,6 +118,25 @@ module Spree
 
       private
 
+      def update_search_results
+        render cable_ready: cable_car.inner_html(
+          "#orders-index",
+          partial("spree/admin/orders/table", locals: { pagy: @pagy, orders: @orders })
+        )
+      end
+
+      def searching?
+        params[:q].present? && request.format.symbol == :cable_ready
+      end
+
+      def search_params
+        search_defaults.deep_merge(params.permit!).to_h.with_indifferent_access
+      end
+
+      def search_defaults
+        { q: { completed_at_not_null: 1, s: "completed_at desc" } }
+      end
+
       def on_update
         @order.recreate_all_fees!
 
diff --git a/app/services/search_orders.rb b/app/services/search_orders.rb
index 6b08d78cfb..60cf824e63 100644
--- a/app/services/search_orders.rb
+++ b/app/services/search_orders.rb
@@ -26,7 +26,7 @@ class SearchOrders
     base_query = ::Permissions::Order.new(current_user).editable_orders.not_empty
       .or(::Permissions::Order.new(current_user).editable_orders.finalized)
 
-    return base_query unless params[:shipping_method_id]
+    return base_query if params[:shipping_method_id].blank?
 
     base_query
       .joins(shipments: :shipping_rates)
diff --git a/app/views/admin/shared/_stimulus_page_controls.html.haml b/app/views/admin/shared/_stimulus_page_controls.html.haml
new file mode 100644
index 0000000000..9e69c82203
--- /dev/null
+++ b/app/views/admin/shared/_stimulus_page_controls.html.haml
@@ -0,0 +1,8 @@
+= select_tag :per_page,
+  options_for_select([15, 50, 100].collect{|num| [t('js.admin.orders.index.per_page', results: num), num] }, params[:per_page]),
+  { class: "no-search primary per-page-dropdown", data: { controller: "tom-select search", action: "change->search#changePerPage" } }
+
+- if pagy
+  %span.per-page-feedback
+    = t("spree.admin.orders.index.results_found", number: pagy.count)
+    = t("spree.admin.orders.index.viewing", start: pagy.from, end: pagy.to )
diff --git a/app/views/admin/shared/_stimulus_pagination.html.haml b/app/views/admin/shared/_stimulus_pagination.html.haml
new file mode 100644
index 0000000000..e7e97fc643
--- /dev/null
+++ b/app/views/admin/shared/_stimulus_pagination.html.haml
@@ -0,0 +1,22 @@
+- link = pagy_link_proc(pagy)
+
+.pagination{ "data-controller": "search" }
+  - if pagy.prev
+    %button{ data: { action: 'click->search#changePage', page: pagy.prev } }!= pagy_t('pagy.nav.prev')
+  - else
+    %button.disabled{disabled: "disabled"}!= pagy_t('pagy.nav.prev')
+
+  - pagy.series.each do |item|                      # series example: [1, :gap, 7, 8, "9", 10, 11, :gap, 36]
+    - if item.is_a?(Integer)                        # page link
+      %button{ data: { action: 'click->search#changePage', page: item } }= item
+
+    - elsif item.is_a?(String)                      # current page
+      %button.active= item
+
+    - elsif item == :gap                            # page gap
+      %span.pagination-ellipsis!= pagy_t('pagy.nav.gap')
+
+  - if pagy.next
+    %button{ data: { action: 'click->search#changePage', page: pagy.next } }!= pagy_t('pagy.nav.next')
+  - else
+    %button.disabled.pagination-next{disabled: "disabled"}!= pagy_t('pagy.nav.next')
diff --git a/app/views/spree/admin/orders/_bulk_actions.html.haml b/app/views/spree/admin/orders/_bulk_actions.html.haml
new file mode 100644
index 0000000000..bdbfdd466a
--- /dev/null
+++ b/app/views/spree/admin/orders/_bulk_actions.html.haml
@@ -0,0 +1,20 @@
+%button.plain.ofn-drop-down.disabled{ "data-checked-target": "disable" }
+  %span{ class: 'icon-reorder' }
+    ="#{t('admin.actions')}".html_safe
+  %span.toggle-off.icon-caret-up
+  %span.toggle-on.icon-caret-down
+
+  %div.menu.dropdown-content
+    %div.menu_item
+      %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "resend_confirmation" }
+        = t('spree.admin.orders.index.resend_confirmation')
+    - if Spree::Config[:enable_invoices?]
+      %div.menu_item
+        %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "send_invoice" }
+          = t('spree.admin.orders.index.send_invoice')
+      %div.menu_item
+        %span.name.invoices-modal{'ng-controller' => 'bulkInvoiceCtrl', 'ng-click' => 'createBulkInvoice()' }
+          = t('spree.admin.orders.index.print_invoices')
+    %div.menu_item
+      %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "cancel_orders" }
+        = t('spree.admin.orders.index.cancel_orders')
diff --git a/app/views/spree/admin/orders/_filters.html.haml b/app/views/spree/admin/orders/_filters.html.haml
index f328c149ea..9f924fffa1 100644
--- a/app/views/spree/admin/orders/_filters.html.haml
+++ b/app/views/spree/admin/orders/_filters.html.haml
@@ -1,59 +1,60 @@
-%div.admin-orders-index-search
-  = form_tag spree.admin_orders_url, {name: "orders_form", "ng-submit" => "fetchResults()"} do
+%div.admin-orders-index-search{ "data-controller": "search" }
+  = form_with url: spree.admin_orders_url, id: "orders_form", method: :get, data: { remote: true, "search-target": "form" } do
+    = hidden_field_tag :page, 1, class: "page"
+    = hidden_field_tag :per_page, 15, class: "per-page"
+    = hidden_field_tag "[q][s]", params.dig(:q, :s) || "completed_at desc", class: "sort", "data-default": "completed_at desc"
+
     .field-block.alpha.four.columns
       .date-range-filter.field
         = label_tag nil, t(:date_range)
-        .date-range-fields{ data: { controller: "flatpickr", "flatpickr-mode-value": "range", "flatpickr-default-date": "{{ [q.completed_at_gteq, q.completed_at_lteq] }}" } }
+        .date-range-fields{ data: { controller: "flatpickr", "flatpickr-mode-value": "range" } }
           = text_field_tag nil, nil, class: "datepicker", data: { "flatpickr-target": "instance", action: "flatpickr_clear@window->flatpickr#clear" }
           = text_field_tag "q[completed_at_gteq]", nil, "ng-model": "q.completed_at_gteq", data: { "flatpickr-target": "start" }, style: "display: none"
           = text_field_tag "q[completed_at_lteq]", nil, "ng-model": "q.completed_at_lteq", data: { "flatpickr-target": "end" }, style: "display: none"
       .field
         = label_tag nil, t(:status)
-        %select2-watch-ng-model{'ng-model': 'q.state_eq'}
-          = select_tag("q[state_eq]",
-              options_for_select(Spree::Order.state_machines[:state].states.collect {|s| [t("spree.order_state.#{s.name}"), s.value]}),
-              {include_blank: true, class: 'select2', 'ng-model' => 'q.state_eq'})
+        = select_tag("q[state_eq]",
+            options_for_select(Spree::Order.state_machines[:state].states.collect {|s| [t("spree.order_state.#{s.name}"), s.value]}),
+            { include_blank: true, class: "primary", "data-controller": "tom-select" })
     .four.columns
       .field
         = label_tag "q_number_cont", t(:order_number)
-        = text_field_tag "q[number_cont]", nil, "ng-model" => "q.number_cont", "ng-keypress" => "$event.keyCode === 13 && fetchResults()"
+        = text_field_tag "q[number_cont]", nil
       .field
         = label_tag "q_email_cont", t(:email)
-        = email_field_tag "q[email_cont]", nil, "ng-model" => "q.email_cont", "ng-keypress" => "$event.keyCode === 13 && fetchResults()"
+        = email_field_tag "q[email_cont]", nil
     .four.columns
       .field
         = label_tag "q_bill_address_firstname_start", t(:first_name_begins_with)
-        = text_field_tag "q[bill_address_firstname_start]", nil, size: 25, "ng-model" => "q.bill_address_firstname_start", "ng-keypress" => "$event.keyCode === 13 && fetchResults()"
+        = text_field_tag "q[bill_address_firstname_start]", nil, size: 25
       .field
         = label_tag "q_bill_address_lastname_start", t(:last_name_begins_with)
-        = text_field_tag "q[bill_address_lastname_start]", nil, size: 25, "ng-model" => "q.bill_address_lastname_start", "ng-keypress" => "$event.keyCode === 13 && fetchResults()"
+        = text_field_tag "q[bill_address_lastname_start]", nil, size: 25
     .omega.four.columns
       .field.checkbox
         %label
-          = check_box_tag "q[completed_at_not_null]", 1, true, {'ng-model' => 'q.completed_at_not_null'}
+          = check_box_tag "q[completed_at_not_null]", 1, true
           = t(:show_only_complete_orders)
       .field
         = label_tag nil, t(:shipping_method)
-        %select2-watch-ng-model{'ng-model': 'q.shipping_method_id'}
-          = select_tag("q[shipping_method_id]",
-            options_for_select(Spree::ShippingMethod.managed_by(spree_current_user).collect {|s| [t("spree.shipping_method_names.#{s.name}"), s.id]}),
-            {include_blank: true, class: 'select2', 'ng-model': 'q.shipping_method_id'})
+        = select_tag(:shipping_method_id,
+          options_for_select(Spree::ShippingMethod.managed_by(spree_current_user).collect {|s| [t("spree.shipping_method_names.#{s.name}"), s.id]}),
+          { include_blank: true, class: "primary", "data-controller": "tom-select" })
     .field-block.alpha.eight.columns
       = label_tag nil, t(:distributors)
-      %select2-watch-ng-model{'ng-model': 'q.distributor_id_in'}
-        = select_tag("q[distributor_id_in]",
-            options_for_select(Enterprise.is_distributor.managed_by(spree_current_user).map {|e| [e.name, e.id]}, params[:distributor_ids]),
-            {class: "select2 fullwidth", multiple: true, 'ng-model' => 'q.distributor_id_in'})
+      = select_tag("q[distributor_id_in]",
+          options_for_select(Enterprise.is_distributor.managed_by(spree_current_user).map {|e| [e.name, e.id]}, params[:distributor_ids]),
+          { class: "fullwidth", multiple: true, data: { controller: "tom-select", "tom-select-options-value": { plugins: ['remove_button'], maxItems: nil } }})
     .field-block.omega.eight.columns
       = label_tag nil, t(:order_cycles)
-      %select2-watch-ng-model{'ng-model': 'q.order_cycle_id_in'}
-        = select_tag("q[order_cycle_id_in]",
-            options_for_select(OrderCycle.managed_by(spree_current_user).where('order_cycles.orders_close_at is not null').order('order_cycles.orders_close_at DESC').map {|oc| [oc.name, oc.id]}, params[:order_cycle_ids]),
-            {class: "select2 fullwidth", multiple: true, 'ng-model' => 'q.order_cycle_id_in'})
+      = select_tag("q[order_cycle_id_in]",
+        options_for_select(OrderCycle.managed_by(spree_current_user).where('order_cycles.orders_close_at is not null').order('order_cycles.orders_close_at DESC').map {|oc| [oc.name, oc.id]}, params[:order_cycle_ids]),
+        { class: "fullwidth", multiple: true, data: { controller: "tom-select", "tom-select-options-value": { plugins: ['remove_button'], maxItems: nil } }})
     .clearfix
     .actions.filter-actions
-      %a.button.icon-search{'ng-click' => 'fetchResults()'}
+      %button{type: "submit", class: "button"}
+        %i.icon-search
         = t(:filter_results)
-      %a.button{'ng-click' => 'clearFilters()', "id": "clear_filters_button"}
+      %button{"id": "clear_filters_button", type: "button", "data-controller": "search", "data-action": "click->search#reset" }
         =  t(:clear_filters)
           
diff --git a/app/views/spree/admin/orders/_table.html.haml b/app/views/spree/admin/orders/_table.html.haml
new file mode 100644
index 0000000000..f15cc261d1
--- /dev/null
+++ b/app/views/spree/admin/orders/_table.html.haml
@@ -0,0 +1,30 @@
+.row.index-controls
+  %div{ style: "display: flex; justify-content: space-between;" }
+    = render partial: "bulk_actions"
+    .per-page.right
+      = render partial: 'admin/shared/stimulus_page_controls', locals: { pagy: pagy }
+
+%table#listing_orders.index.responsive{width: "100%" }
+  %colgroup
+    %col{style: "width: 3%"}
+  %thead
+    %tr
+      %th
+        %input#selectAll{ type: 'checkbox', data: { "checked-target": "all", action: "change->checked#toggleAll" } }
+      %th
+        = t(:products_distributor)
+
+      - columns = ['completed_at', 'number', 'state', 'payment_state', 'shipment_state', 'email', 'bill_address_lastname', 'total']
+
+      = render partial: "spree/admin/shared/stimulus_sortable_header", collection: columns, as: :column,
+        locals: { sorted: params.dig(:q, :s), default: "completed_at desc" }
+
+      %th.actions
+  %tbody
+    = render partial: "table_row", collection: orders, as: :order
+
+
+- if pagy&.count&.positive?
+  = render partial: "admin/shared/stimulus_pagination", locals: { pagy: pagy }
+- else
+  .no-objects-found= t('spree.admin.orders.index.no_orders_found')
diff --git a/app/views/spree/admin/orders/_table_row.html.haml b/app/views/spree/admin/orders/_table_row.html.haml
new file mode 100644
index 0000000000..58c09d4bed
--- /dev/null
+++ b/app/views/spree/admin/orders/_table_row.html.haml
@@ -0,0 +1,48 @@
+%tr{ id: dom_id(order), class: "state-#{order.state}" }
+  %td.align-center
+    %input{type: 'checkbox', value: order.id, name: 'order_ids[]', "data-checked-target": "checkbox", "data-action": "change->checked#toggleCheckbox" }
+  %td.align-center
+    = order.distributor.name
+  %td.align-center
+    = I18n.l(order.completed_at, format: '%B %d, %Y') if order.completed_at
+  %td
+    %a{ href: edit_admin_order_path(order) }
+      = order.number
+    - if order.special_instructions
+      %div
+        %br
+        %span.icon-warning-sign{'ofn-with-tip' => order.special_instructions.to_s }
+          = t('spree.admin.orders.index.note')
+  %td.align-center
+    %span.state{ class: order.state.to_s }
+      = t('js.admin.orders.order_state.' + order.state.to_s)
+  %td.align-center
+    - if order.payment_state
+      %span.state{class: 'order.payment_state'}
+        %a{href: spree.admin_order_payments_path(order) }
+          = t('js.admin.orders.payment_states.' + order.payment_state.to_s)
+          - if order.display_outstanding_balance
+            %span
+              = "(#{order.display_outstanding_balance})"
+  %td.align-center
+    - if order.shipment_state
+      %span.state{class: order.shipment_state.to_s}
+        = t('js.admin.orders.shipment_states.' + order.shipment_state.to_s)
+  %td
+    %a{ href: "mailto:#{order.email}", target: "_blank" }
+      = order.email
+  %td
+    = order.bill_address.full_name
+  %td.align-center
+    %span
+      = order.display_total
+  %td.actions
+    .flex
+      %div.row-loading-icons
+        - if local_assigns[:success]
+          %i.success.icon-ok-sign{"data-controller": "ephemeral"}
+      %a.icon_link.with-tip.icon-edit.no-text{href: edit_admin_order_path(order), 'ofn-with-tip' => t('spree.admin.orders.index.edit')}
+      - if order.ready_to_ship?
+        %button.icon-road.icon_link.with-tip.no-text{rel: 'nofollow', 'ofn-with-tip' => t('spree.admin.orders.index.ship')}
+      - if order.payment_required? && order.pending_payments.reject(&:requires_authorization?).any?
+        %button.icon-capture.icon_link.no-text{rel: 'nofollow', 'ofn-with-tip' => t('spree.admin.orders.index.capture')}
diff --git a/app/views/spree/admin/orders/index.html.haml b/app/views/spree/admin/orders/index.html.haml
index 5c55106a03..d46af52b9a 100644
--- a/app/views/spree/admin/orders/index.html.haml
+++ b/app/views/spree/admin/orders/index.html.haml
@@ -9,120 +9,14 @@
 
 = render partial: 'spree/admin/shared/order_sub_menu'
 
-- content_for :main_ng_app_name do
-  = "ofn.admin"
-
-- content_for :main_ng_ctrl_name do
-  = "ordersCtrl"
-
 - content_for :table_filter_title do
   = t(:search)
 
 - content_for :table_filter do
   = render partial: 'filters'
 
-.row.index-controls{'ng-show' => '!RequestMonitor.loading && orders.length > 0'}
-  %div{style: "display: flex; justify-content: space-between;"}
-    .ofn-drop-down-with-prepend
-      .ofn-drop-down-prepend{"ng-class": "selected_orders.length == 0 ? 'disabled' : ''"}
-        {{ "spree.admin.orders.index.selected" | t:{count: selected_orders.length} }}
-      .ofn-drop-down{"ng-class": "selected_orders.length == 0 ? 'disabled' : ''"}
-        %span{ :class => 'icon-reorder' }
-          ="#{t('admin.actions')}".html_safe
-        %span{ 'ng-class' => "expanded && 'icon-caret-up' || !expanded && 'icon-caret-down'" }
-        %div.menu{ 'ng-show' => "expanded" }
-          %div.menu_item
-            %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "resend_confirmation" }
-              = t('.resend_confirmation')
-          - if Spree::Config[:enable_invoices?]
-            %div.menu_item
-              %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "send_invoice" }
-                = t('.send_invoice')
-            %div.menu_item
-              %span.name.invoices-modal{'ng-controller' => 'bulkInvoiceCtrl', 'ng-click' => 'createBulkInvoice()' }
-                = t('.print_invoices')
-          %div.menu_item
-            %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "cancel_orders" }
-              = t('.cancel_orders')
-
-    = render partial: 'admin/shared/angular_per_page_controls', locals: { position: "right", model: "orders" }
-
-%table#listing_orders.index.responsive{width: "100%", 'ng-init' => 'initialise()', 'ng-show' => "!RequestMonitor.loading && orders.length > 0" }
-  %colgroup
-    %col{style: "width: 3%"}
-  %thead
-    %tr
-      %th
-        %input#selectAll{type: 'checkbox', 'ng-change' => 'toggleAll()', 'ng-model' => 'select_all'}
-      %th
-        = t(:products_distributor)
-        %th
-          %a{'ng-click' => "sortOptions.toggle('completed_at')"}
-            = t(:completed_at, scope: 'activerecord.attributes.spree/order')
-            %span{'ng-show' => "sorting == 'completed_at asc'"}= "&#x25B2;".html_safe
-            %span{'ng-show' => "sorting == 'completed_at desc' || sorting === undefined"}= "&#x25BC;".html_safe
-
-      - ['number', 'state', 'payment_state', 'shipment_state', 'email', 'bill_address_lastname', 'total'].each do |column_name|
-        %th
-          = render partial: 'spree/admin/shared/sortable_header', locals: {column_name: column_name}
-
-      %th.actions
-  %tbody
-    %tr{ng: {repeat: 'order in orders track by order.id', class: {even: "'even'", odd: "'odd'"}}, 'ng-class' => "{'state-{{order.state}}': true, 'row-loading': rowStatus[order.id] == 'loading'}"}
-      %td.align-center
-        %input{type: 'checkbox', 'ng-model' => 'checkboxes[order.id]', 'ng-change' => 'toggleSelection(order.id)', value: '{{order.id}}', name: 'order_ids[]'}
-      %td.align-center
-        {{order.distributor_name}}
-      %td.align-center
-        {{order.completed_at}}
-      %td
-        %a{'ng-href' => '{{order.edit_path}}'}
-          {{order.number}}
-        %div{'ng-if' => 'order.special_instructions'}
-          %br
-          %span.icon-warning-sign{'ofn-with-tip' => "{{order.special_instructions}}"}
-            = t('.note')
-      %td.align-center
-        %span.state{'ng-class' => 'order.state'}
-          {{'js.admin.orders.order_state.' + order.state | t}}
-      %td.align-center
-        %span.state{'ng-class' => 'order.payment_state', 'ng-if' => 'order.payment_state'}
-          %a{'ng-href' => '{{order.payments_path}}' }
-            {{'js.admin.orders.payment_states.' + order.payment_state | t}}
-            %span{'ng-if' => 'order.display_outstanding_balance'}
-              ({{order.display_outstanding_balance}})
-      %td.align-center
-        %span.state{'ng-class' => 'order.shipment_state', 'ng-if' => 'order.shipment_state'}
-          {{'js.admin.orders.shipment_states.' + order.shipment_state | t}}
-      %td
-        %a{ ng: { href: "mailto:{{order.email}}" } }
-          {{order.email}}
-      %td
-        {{order.full_name}}
-      %td.align-center
-        %span{'ng-bind-html' => 'order.display_total'}
-      %td.actions
-        %div.row-loading-icons
-          %div{ng: {show: 'rowStatus[order.id] == "loading"', cloak: true}, style: "width: 30px; height: 30px;"}
-            = render partial: "components/spinner"
-          %i.success.icon-ok-sign{ng: {show: 'rowStatus[order.id] == "success"'} }
-          %i.error.icon-remove-sign.with-tip{ng: {show: 'rowStatus[order.id] == "error"'}, 'ofn-with-tip' => t('.order_not_updated')}
-        %a.icon_link.with-tip.icon-edit.no-text{'ng-href' => '{{order.edit_path}}', 'data-action' => 'edit', 'ofn-with-tip' => t('.edit')}
-        %div{'ng-if' => 'order.ready_to_ship'}
-          %button.icon-road.icon_link.with-tip.no-text{'ng-click' => 'shipOrder(order)', rel: 'nofollow', 'ofn-with-tip' => t('.ship')}
-        %div{'ng-if' => 'order.ready_to_capture'}
-          %button.icon-capture.icon_link.no-text{'ng-click' => 'capturePayment(order)', rel: 'nofollow', 'ofn-with-tip' => t('.capture')}
-
-.sixteen.columns.alpha#loading{ 'ng-show' => 'RequestMonitor.loading' }
-  = render partial: "components/admin_spinner"
-  %h1
-    = t('.loading')
-
-%div{'ng-show' => "!RequestMonitor.loading && orders.length > 0" }
-  = render partial: 'admin/shared/angular_pagination'
-
-.no-objects-found{'ng-show' => "!RequestMonitor.loading && orders.length == 0"}
-  = t('.no_orders_found')
+#orders-index{"data-controller": "search checked"}
+  = render partial: "table", locals: { pagy: @pagy, orders: @orders }
 
 = render 'spree/admin/shared/custom-confirm'
 
diff --git a/app/views/spree/admin/shared/_stimulus_sortable_header.html.haml b/app/views/spree/admin/shared/_stimulus_sortable_header.html.haml
new file mode 100644
index 0000000000..46443016ce
--- /dev/null
+++ b/app/views/spree/admin/shared/_stimulus_sortable_header.html.haml
@@ -0,0 +1,8 @@
+%th
+  %a{ "data-action": "click->search#changeSorting", "data-column": "#{column}", "data-current": sorted.to_s }
+    = t("spree.admin.shared.sortable_header.#{column.to_s}")
+
+    - if sorted == "#{column} asc" || sorted.blank? && local_assigns[:default] == "#{column} asc"
+      = "&#x25B2;".html_safe
+    - if sorted == "#{column} desc" || sorted.blank? && local_assigns[:default] == "#{column} desc"
+      = "&#x25BC;".html_safe
diff --git a/app/views/spree/admin/shared/_tabs.html.haml b/app/views/spree/admin/shared/_tabs.html.haml
index 91efb77da3..d84e381c57 100644
--- a/app/views/spree/admin/shared/_tabs.html.haml
+++ b/app/views/spree/admin/shared/_tabs.html.haml
@@ -1,7 +1,7 @@
 = tab :overview, label: 'dashboard', url: spree.admin_dashboard_path, icon: 'icon-dashboard'
 = tab :products, :properties, :inventory, :product_import, :images, :variants, :product_properties, :group_buy_options, :seo, url: admin_products_path, icon: 'icon-th-large'
 = tab :order_cycles, url: main_app.admin_order_cycles_path, icon: 'icon-refresh'
-= tab :orders, :subscriptions, :customer_details, :adjustments, :payments, :return_authorizations, url: admin_orders_path('q[s]' => 'completed_at desc'), icon: 'icon-shopping-cart'
+= tab :orders, :subscriptions, :customer_details, :adjustments, :payments, :return_authorizations, url: admin_orders_path, icon: 'icon-shopping-cart'
 = tab :reports, url: main_app.admin_reports_path, icon: 'icon-file'
 = tab :general_settings, :mail_methods, :tax_categories, :tax_rates, :tax_settings, :zones, :countries, :states, :payment_methods, :taxonomies, :shipping_methods, :shipping_categories, :enterprise_fees, :contents, :invoice_settings, :matomo_settings, :stripe_connect_settings, label: 'configuration', icon: 'icon-wrench', url: edit_admin_general_settings_path
 = tab :enterprises, :enterprise_relationships, :vouchers, :oidc_settings, url: main_app.admin_enterprises_path
diff --git a/app/webpacker/controllers/cancel_orders_controller.js b/app/webpacker/controllers/cancel_orders_controller.js
index d1872feb07..a017edda2b 100644
--- a/app/webpacker/controllers/cancel_orders_controller.js
+++ b/app/webpacker/controllers/cancel_orders_controller.js
@@ -6,9 +6,7 @@ export default class extends ApplicationController {
   }
 
   confirm() {
-    const send_cancellation_email = document.querySelector(
-      "#send_cancellation_email"
-    ).checked;
+    const send_cancellation_email = document.querySelector("#send_cancellation_email").checked;
     const restock_items = document.querySelector("#restock_items").checked;
     const order_ids = [];
 
@@ -23,8 +21,7 @@ export default class extends ApplicationController {
       send_cancellation_email: send_cancellation_email,
       restock_items: restock_items,
     };
-    this.stimulate("CancelOrdersReflex#confirm", params).then(() =>
-      window.location.reload()
-    );
+
+    this.stimulate("CancelOrdersReflex#confirm", params);
   }
 }
diff --git a/app/webpacker/controllers/checked_controller.js b/app/webpacker/controllers/checked_controller.js
index 30a00aee79..66ab32ae0c 100644
--- a/app/webpacker/controllers/checked_controller.js
+++ b/app/webpacker/controllers/checked_controller.js
@@ -1,19 +1,39 @@
 import { Controller } from "stimulus";
 
 export default class extends Controller {
-  static targets = ["all", "checkbox"];
+  static targets = ["all", "checkbox", "disable"];
 
   connect() {
-    this.toggleCheckbox()
+    this.toggleCheckbox();
   }
 
   toggleAll() {
-    this.checkboxTargets.forEach(checkbox => {
+    this.checkboxTargets.forEach((checkbox) => {
       checkbox.checked = this.allTarget.checked;
     });
+    this.#toggleDisabled();
   }
 
   toggleCheckbox() {
-    this.allTarget.checked = this.checkboxTargets.every(checkbox => checkbox.checked);
+    this.allTarget.checked = this.checkboxTargets.every((checkbox) => checkbox.checked);
+    this.#toggleDisabled();
+  }
+
+  // private
+
+  #toggleDisabled() {
+    if (!this.hasDisableTarget) {
+      return;
+    }
+
+    if (this.#noneChecked()) {
+      this.disableTargets.forEach((element) => element.classList.add("disabled"));
+    } else {
+      this.disableTargets.forEach((element) => element.classList.remove("disabled"));
+    }
+  }
+
+  #noneChecked() {
+    return this.checkboxTargets.every((checkbox) => !checkbox.checked);
   }
 }
diff --git a/app/webpacker/controllers/ephemeral_controller.js b/app/webpacker/controllers/ephemeral_controller.js
new file mode 100644
index 0000000000..bba181a733
--- /dev/null
+++ b/app/webpacker/controllers/ephemeral_controller.js
@@ -0,0 +1,16 @@
+import { Controller } from "stimulus";
+
+export default class extends Controller {
+  connect() {
+    setTimeout(this.fadeout, 1500);
+  }
+
+  fadeout = () => {
+    this.element.classList.add("animate-hide-500");
+    setTimeout(this.remove, 500);
+  };
+
+  remove = () => {
+    this.element.remove();
+  };
+}
diff --git a/app/webpacker/controllers/search_controller.js b/app/webpacker/controllers/search_controller.js
new file mode 100644
index 0000000000..fdcc13439b
--- /dev/null
+++ b/app/webpacker/controllers/search_controller.js
@@ -0,0 +1,68 @@
+import { Controller } from "stimulus";
+
+export default class extends Controller {
+  static targets = ["form"];
+
+  connect() {
+    this.#setup();
+  }
+
+  changePage(event) {
+    this.page.value = event.target.dataset.page;
+    this.submitSearch();
+    this.page.value = 1;
+  }
+
+  changePerPage(event) {
+    this.per_page.value = parseInt(event.target.value);
+    this.submitSearch();
+  }
+
+  changeSorting(event) {
+    let current = event.target.dataset.current;
+    let column = event.target.dataset.column;
+
+    this.sort.value = current === `${column} asc` ? `${column} desc` : `${column} asc`;
+
+    this.submitSearch();
+  }
+
+  submitSearch() {
+    this.form.requestSubmit();
+  }
+
+  reset() {
+    this.clearForm();
+    this.submitSearch();
+  }
+
+  clearForm() {
+    this.form.reset();
+    this.#clearCustomElements();
+    if (this.page) this.page.value = 1;
+    if (this.sort) this.sort.value = this.sort.dataset.default;
+  }
+
+  // private
+
+  #setup() {
+    if (this.hasFormTarget) {
+      this.form = this.formTarget;
+      this.form.controller = this;
+    } else {
+      this.form = document.querySelector("form[data-search-target=form]");
+    }
+
+    this.page = this.form.querySelector(".page");
+    this.per_page = this.form.querySelector(".per-page");
+    this.sort = this.form.querySelector(".sort");
+  }
+
+  #clearCustomElements() {
+    window.dispatchEvent(new CustomEvent("flatpickr:clear"));
+
+    this.form.querySelectorAll(".tomselected").forEach((select) => {
+      select.tomselect?.clear();
+    });
+  }
+}
diff --git a/app/webpacker/css/admin/animations.scss b/app/webpacker/css/admin/animations.scss
index bbc766ecfd..7b6e451078 100644
--- a/app/webpacker/css/admin/animations.scss
+++ b/app/webpacker/css/admin/animations.scss
@@ -10,6 +10,16 @@
   }
 }
 
+@keyframes fade-out-hide {
+  0%   {opacity: 1; visibility: visible;}
+  99%  {opacity: 0; visibility: visible;}
+  100% {opacity: 0; visibility: hidden;}
+}
+
+.animate-hide-500 {
+  animation: fade-out-hide 0.5s;
+}
+
 // @-webkit-keyframes slideOutDown
 //   0%
 //     -webkit-transform: translateY(0)
diff --git a/app/webpacker/css/admin/components/buttons.scss b/app/webpacker/css/admin/components/buttons.scss
index 1a59a4fff2..5de746ea48 100644
--- a/app/webpacker/css/admin/components/buttons.scss
+++ b/app/webpacker/css/admin/components/buttons.scss
@@ -1,6 +1,6 @@
 input[type="submit"],
 input[type="button"],
-button,
+button:not(.plain),
 .button {
   position: relative;
   cursor: pointer;
diff --git a/app/webpacker/css/admin/components/per_page_controls.scss b/app/webpacker/css/admin/components/per_page_controls.scss
index 1b4e2dc3f9..f843bb1674 100644
--- a/app/webpacker/css/admin/components/per_page_controls.scss
+++ b/app/webpacker/css/admin/components/per_page_controls.scss
@@ -10,6 +10,10 @@
       margin-right: 1em;
       margin-left: 0;
     }
+
+    .ts-control > * {
+      padding-right: 2.75em;
+    }
   }
 
   .per-page-feedback {
diff --git a/app/webpacker/css/admin/components/tom_select.scss b/app/webpacker/css/admin/components/tom_select.scss
index 2fb878f4bd..75684615fd 100644
--- a/app/webpacker/css/admin/components/tom_select.scss
+++ b/app/webpacker/css/admin/components/tom_select.scss
@@ -1,5 +1,14 @@
+.ts-wrapper {
+  min-height: initial;
+}
+
 .ts-dropdown {
   margin-top: 0;
+
+  .option {
+    min-height: 2.25em;
+    display: block;
+  }
 }
 
 .ts-wrapper.single .ts-control,
@@ -45,6 +54,10 @@
   }
 }
 
+.ts-wrapper .select-multiple {
+  cursor: pointer;
+}
+
 .ts-wrapper.dropdown-active.primary .ts-control {
   background-color: $spree-green;
   border-color: $spree-green;
diff --git a/app/webpacker/css/admin/dropdown.scss b/app/webpacker/css/admin/dropdown.scss
index 85fd5c7416..d3eab51beb 100644
--- a/app/webpacker/css/admin/dropdown.scss
+++ b/app/webpacker/css/admin/dropdown.scss
@@ -6,130 +6,156 @@
   margin-left: 3px;
 }
 
-.ofn-drop-down:hover, .ofn-drop-down.expanded {
-	border: 1px solid #adadad;
-	color: #575757;
+.ofn-drop-down {
+  .dropdown-content {
+    display: none;
+  }
+
+  .toggle-off {
+    display: none;
+  }
+
+  &:active:not(.disabled),
+  &:focus:not(.disabled) {
+    .dropdown-content {
+      display: inline-block;
+    }
+
+    .toggle-off {
+      display: inline-block;
+    }
+
+    .toggle-on {
+      display: none;
+    }
+  }
+}
+
+.ofn-drop-down:hover,
+.ofn-drop-down.expanded {
+  border: 1px solid #adadad;
+  color: #575757;
 }
 
 @mixin ofn-drop-down-style {
-	padding: 7px 15px;
-	border-radius: 3px;
-	border: 1px solid #d4d4d4;
-	background-color: #f5f5f5;
-	display: block;
-	color: #828282;
-	cursor: pointer;
-	-moz-user-select: none;
-	-khtml-user-select: none;
-	-webkit-user-select: none;
-	-ms-user-select: none;
-	user-select: none;
-	text-align: center;
+  padding: 7px 15px;
+  border-radius: 3px;
+  border: 1px solid #d4d4d4;
+  background-color: #f5f5f5;
+  display: block;
+  color: #828282;
+  cursor: pointer;
+  -moz-user-select: none;
+  -khtml-user-select: none;
+  -webkit-user-select: none;
+  -ms-user-select: none;
+  user-select: none;
+  text-align: center;
   margin-right: 10px;
 
-	&.disabled {
-		opacity: 0.5;
-		
-		&:hover {
-			cursor: default;
-			border-color: #d4d4d4;
-			color: #828282;
-		}
-	}
+  &.disabled {
+    opacity: 0.5;
+
+    &:hover {
+      cursor: default;
+      border-color: #d4d4d4;
+      color: #828282;
+    }
+  }
 }
 
 .ofn-drop-down-with-prepend {
-	display: flex;
+  display: flex;
 
-	&.right {
-		float: right;
+  &.right {
+    float: right;
+  }
 
-	}
+  .ofn-drop-down {
+    border-top-left-radius: 0;
+    border-bottom-left-radius: 0;
+  }
 
-	.ofn-drop-down {
-		border-top-left-radius: 0;
-		border-bottom-left-radius: 0;
-	}
+  .ofn-drop-down-prepend {
+    @include ofn-drop-down-style;
 
-	.ofn-drop-down-prepend {
-		@include ofn-drop-down-style;
-		
-		border-right: none;
-		margin-left: 0;
-		margin-right: 0;
-		border-top-right-radius: 0;
-		border-bottom-right-radius: 0;
-		cursor: default;
-	}
+    border-right: none;
+    margin-left: 0;
+    margin-right: 0;
+    border-top-right-radius: 0;
+    border-bottom-right-radius: 0;
+    cursor: default;
+  }
 }
 
 .ofn-drop-down {
-	@include ofn-drop-down-style;
+  @include ofn-drop-down-style;
 
-	position: relative;
-	float: left;
+  position: relative;
+  float: left;
 
-	&.right {
-		float: right;
+  &.right {
+    float: right;
     margin-right: 0px;
     margin-left: 10px;
-	}
+  }
 
-  &:hover, &.expanded {
+  &:hover,
+  &.expanded {
     border: 1px solid #adadad;
     color: #575757;
   }
 
-	> span {
-		width: auto;
-		text-transform: uppercase;
-		font-size: 85%;
-		font-weight: 600;
-	}
+  > span {
+    width: auto;
+    text-transform: uppercase;
+    font-size: 85%;
+    font-weight: 600;
+  }
 
-	.menu {
-		margin-top: 1px;
-		position: absolute;
-		float: none;
-		top:100%;
-		left: 0px;
-		padding: 5px 0px;
-		border: 1px solid #adadad;
-		background-color: #ffffff;
-		box-shadow: 1px 3px 10px #888888;
-		z-index: 100;
+  .menu {
+    margin-top: 1px;
+    position: absolute;
+    float: none;
+    top: 100%;
+    left: 0px;
+    padding: 5px 0px;
+    border: 1px solid #adadad;
+    background-color: #ffffff;
+    box-shadow: 1px 3px 10px #888888;
+    z-index: 100;
     white-space: nowrap;
 
-		.filter {
-			padding-left: 5px;
-			padding-right: 5px;
-			position: relative;
-			
-			> input[type="text"] {
-				border: 1px solid rgba(18, 18, 18, 0.1);
-				width: 100%;
-				padding-left: 30px;
-				padding-top: 10px;
-				padding-bottom: 10px;
-				font-size: 13px;
-				color:#454545;
-			}
+    .filter {
+      padding-left: 5px;
+      padding-right: 5px;
+      position: relative;
 
-			&:after {
-				content: "\f002";
-				font-family: FontAwesome;
-				position: absolute;
-				left: 15px;
-				top: 13px;
-				color:#454545;
-			}
-		}
+      > input[type="text"] {
+        border: 1px solid rgba(18, 18, 18, 0.1);
+        width: 100%;
+        padding-left: 30px;
+        padding-top: 10px;
+        padding-bottom: 10px;
+        font-size: 13px;
+        color: #454545;
+      }
 
-		.menu_item {
-			margin: 0px;
-			padding: 2px 10px;
-			color: #454545;
-			text-align: left;
+      &:after {
+        content: "\f002";
+        font-family: FontAwesome;
+        position: absolute;
+        left: 15px;
+        top: 13px;
+        color: #454545;
+      }
+    }
+
+    .menu_item {
+      margin: 0px;
+      padding: 2px 10px;
+      color: #454545;
+      text-align: left;
       display: block;
 
       .check {
@@ -146,78 +172,79 @@
         padding: 0px 15px 0px 0px;
       }
 
-      &.selected{
+      &.selected {
         .check:before {
           content: "\2713";
         }
       }
 
-			&.hidden {
-				display: none;
-			}
-		}
+      &.hidden {
+        display: none;
+      }
+    }
 
-		.menu_item:hover {
-			background-color: #ededed;
-		}
-	}
+    .menu_item:hover {
+      background-color: #ededed;
+    }
+  }
 }
 
 .ofn-drop-down-v2 {
-	border: 1px solid $pale-blue;
-	background-color: white;
-	padding: 0px;
-	
-	&:hover {
-		border-color: $spree-blue;
-	}
+  border: 1px solid $pale-blue;
+  background-color: white;
+  padding: 0px;
 
-	.ofn-drop-down-label {
-		color: $color-3;
-		padding: 10px;
-		width: 235px;
-		display: flex;
-		justify-content: space-between;
+  &:hover {
+    border-color: $spree-blue;
+  }
 
-		&:hover {
-			color: $color-3;
-		}
+  .ofn-drop-down-label {
+    color: $color-3;
+    padding: 10px;
+    width: 235px;
+    display: flex;
+    justify-content: space-between;
 
-		.label {
-			padding-right: 10px;
-		}
+    &:hover {
+      color: $color-3;
+    }
 
-		.icon-caret-down, .icon-caret-up {
-			padding-right: 0px;
-		}
-	}
+    .label {
+      padding-right: 10px;
+    }
 
-	.menu {
-		width: 100%;
-	}
+    .icon-caret-down,
+    .icon-caret-up {
+      padding-right: 0px;
+    }
+  }
 
-	.menu_items {
-		max-height: 200px;
-		overflow-y: scroll;
+  .menu {
+    width: 100%;
+  }
 
-		.menu_item {
-			margin-bottom: 5px;
-			color: #454545;
-			font-weight: 400;
-			cursor: pointer;
-			padding-top: 4px;
-			padding-bottom: 5px;
-			text-transform: uppercase;
-			font-size: 85%;
-		}
-	}
+  .menu_items {
+    max-height: 200px;
+    overflow-y: scroll;
+
+    .menu_item {
+      margin-bottom: 5px;
+      color: #454545;
+      font-weight: 400;
+      cursor: pointer;
+      padding-top: 4px;
+      padding-bottom: 5px;
+      text-transform: uppercase;
+      font-size: 85%;
+    }
+  }
 }
 
 .ofn-drop-down.ofn-drop-down-v2 {
-	// Add very specific styling here for components that are in transition:
-	// ie. the ones using the two classes above
-	.ofn-drop-down-label {
-		padding-top: 7px;
-		padding-bottom: 7px;
-	}
+  // Add very specific styling here for components that are in transition:
+  // ie. the ones using the two classes above
+  .ofn-drop-down-label {
+    padding-top: 7px;
+    padding-bottom: 7px;
+  }
 }
diff --git a/app/webpacker/css/admin/shared/forms.scss b/app/webpacker/css/admin/shared/forms.scss
index f2ef36e111..bd5274bced 100644
--- a/app/webpacker/css/admin/shared/forms.scss
+++ b/app/webpacker/css/admin/shared/forms.scss
@@ -1,12 +1,12 @@
-$text-inputs:
-  "input[type=text], input[type=password], input[type=email], input[type=url], input[type=tel]";
+$text-inputs: "input[type=text], input[type=password], input[type=email], input[type=url], input[type=tel]";
 
 #{$text-inputs},
 input[type="date"],
 input[type="datetime"],
 input[type="time"],
 input[type="number"],
-textarea, fieldset {
+textarea,
+fieldset {
   @include border-radius($border-radius);
   padding: 7px 10px;
   border: 1px solid $color-txt-brd;
@@ -48,7 +48,9 @@ label {
   }
 }
 
-.label-block label { display: block }
+.label-block label {
+  display: block;
+}
 
 span.info {
   font-style: italic;
@@ -63,7 +65,7 @@ span.info {
   padding: 10px 0;
 
   &.checkbox {
-    min-height: 73px;
+    min-height: 70px;
 
     input[type="checkbox"] {
       display: inline-block;
@@ -85,7 +87,6 @@ span.info {
       display: inline-block;
       padding-right: 10px;
 
-
       label {
         font-weight: normal;
         text-transform: none;
@@ -171,14 +172,18 @@ fieldset {
       display: inline-block;
     }
 
-    button, .button, input[type="submit"], input[type="button"], span.or {
+    button,
+    .button,
+    input[type="submit"],
+    input[type="button"],
+    span.or {
       @include border-radius($border-radius);
 
       -webkit-box-shadow: 0 0 0 15px $color-1;
-         -moz-box-shadow: 0 0 0 15px $color-1;
-          -ms-box-shadow: 0 0 0 15px $color-1;
-           -o-box-shadow: 0 0 0 15px $color-1;
-              box-shadow: 0 0 0 15px $color-1;
+      -moz-box-shadow: 0 0 0 15px $color-1;
+      -ms-box-shadow: 0 0 0 15px $color-1;
+      -o-box-shadow: 0 0 0 15px $color-1;
+      box-shadow: 0 0 0 15px $color-1;
 
       &:hover {
         border-color: $color-1;
@@ -197,10 +202,10 @@ fieldset {
       position: relative;
 
       -webkit-box-shadow: 0 0 0 5px $color-1;
-         -moz-box-shadow: 0 0 0 5px $color-1;
-          -ms-box-shadow: 0 0 0 5px $color-1;
-           -o-box-shadow: 0 0 0 5px $color-1;
-              box-shadow: 0 0 0 5px $color-1;
+      -moz-box-shadow: 0 0 0 5px $color-1;
+      -ms-box-shadow: 0 0 0 5px $color-1;
+      -o-box-shadow: 0 0 0 5px $color-1;
+      box-shadow: 0 0 0 5px $color-1;
     }
   }
 
@@ -210,7 +215,8 @@ fieldset {
       display: table;
       width: 100%;
 
-      label, input {
+      label,
+      input {
         display: table-cell !important;
       }
       input {
@@ -219,7 +225,7 @@ fieldset {
 
       &.checkbox {
         input {
-          width: auto !important
+          width: auto !important;
         }
       }
     }
@@ -247,11 +253,12 @@ select {
   align-items: center;
   margin-top: 3px;
 
-  input, label {
+  input,
+  label {
     cursor: pointer;
   }
   label {
     margin: 0;
-    padding-left: .4rem;
+    padding-left: 0.4rem;
   }
 }
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 8e20e22529..b825c04849 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -4285,6 +4285,7 @@ See the %{link} to find out more about %{sitename}'s features and to start using
         sortable_header:
           name: "Name"
           number: "Number"
+          completed_at: "Completed At"
           state: "State"
           payment_state: "Payment State"
           shipment_state: "Shipment State"

From 73b41154cc554516b93bfc3b606c989aa8b43e14 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 19 May 2023 18:41:18 +0100
Subject: [PATCH 08/38] Update admin flashes

---
 app/reflexes/application_reflex.rb            | 6 ++++++
 app/reflexes/white_label_reflex.rb            | 2 +-
 app/views/admin/shared/_flashes.html.haml     | 6 ++++++
 app/views/spree/layouts/_admin_body.html.haml | 9 +--------
 app/views/spree/layouts/bare_admin.html.haml  | 8 ++------
 5 files changed, 16 insertions(+), 15 deletions(-)
 create mode 100644 app/views/admin/shared/_flashes.html.haml

diff --git a/app/reflexes/application_reflex.rb b/app/reflexes/application_reflex.rb
index ff41bf8288..4ed251f8bb 100644
--- a/app/reflexes/application_reflex.rb
+++ b/app/reflexes/application_reflex.rb
@@ -20,6 +20,8 @@ class ApplicationReflex < StimulusReflex::Reflex
 
   delegate :current_user, to: :connection
 
+  private
+
   def current_ability
     Spree::Ability.new(current_user)
   end
@@ -27,4 +29,8 @@ class ApplicationReflex < StimulusReflex::Reflex
   def with_locale(&block)
     I18n.with_locale(current_user.locale, &block)
   end
+
+  def morph_admin_flashes
+    morph "#flashes", render(partial: "admin/shared/flashes", locals: { flashes: flash })
+  end
 end
diff --git a/app/reflexes/white_label_reflex.rb b/app/reflexes/white_label_reflex.rb
index 667ed98912..140079add6 100644
--- a/app/reflexes/white_label_reflex.rb
+++ b/app/reflexes/white_label_reflex.rb
@@ -21,6 +21,6 @@ class WhiteLabelReflex < ApplicationReflex
       I18n.t("admin.enterprises.form.white_label.remove_logo_success")
     }
     cable_ready.dispatch_event(name: "modal:close")
-    morph "#flashes", render(partial: "shared/flashes", locals: { flashes: flash })
+    morph_admin_flashes
   end
 end
diff --git a/app/views/admin/shared/_flashes.html.haml b/app/views/admin/shared/_flashes.html.haml
new file mode 100644
index 0000000000..57673b3f48
--- /dev/null
+++ b/app/views/admin/shared/_flashes.html.haml
@@ -0,0 +1,6 @@
+#flashes
+  - if defined? flashes
+    - flashes.each do |type, msg|
+      .animate-show{"data-controller": "flash"}
+        .flash{type: "#{type}", class: "#{type}"}
+          %span= msg
diff --git a/app/views/spree/layouts/_admin_body.html.haml b/app/views/spree/layouts/_admin_body.html.haml
index f43eb3452e..e0710fdf36 100644
--- a/app/views/spree/layouts/_admin_body.html.haml
+++ b/app/views/spree/layouts/_admin_body.html.haml
@@ -4,14 +4,7 @@
 
 #wrapper
   .flash-container
-    - if flash[:error]
-      .flash.error= flash[:error]
-    - if notice
-      .flash.notice= notice
-    - if flash[:success]
-      .flash.success= flash[:success]
-
-    = render partial: "shared/flashes"
+    = render partial: "admin/shared/flashes", locals: { flashes: flash }
 
   = render partial: "spree/layouts/admin/progress_spinner"
 
diff --git a/app/views/spree/layouts/bare_admin.html.haml b/app/views/spree/layouts/bare_admin.html.haml
index db744183f1..39fe796f84 100644
--- a/app/views/spree/layouts/bare_admin.html.haml
+++ b/app/views/spree/layouts/bare_admin.html.haml
@@ -2,12 +2,8 @@
   %head= render :partial => 'spree/admin/shared/head'
   %body.admin{"data-turbo": "false", "data-ajax-root-path": main_app.root_path}
     #wrapper
-      - if flash[:error]
-        .flash.error= flash[:error]
-      - if notice
-        .flash.notice= notice
-      - if flash[:success]
-        .flash.success= flash[:success]
+      = render partial: "admin/shared/flashes", locals: { flashes: flash }
+
       = render partial: "spree/layouts/admin/progress_spinner"
 
       %header#header

From 61849d84e79e53484aee7b3b85b1dde2f8816d2b Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Sun, 7 May 2023 19:57:06 +0100
Subject: [PATCH 09/38] Extract order capturing to OrderCaptureService

---
 app/controllers/api/v0/orders_controller.rb | 10 ++++------
 app/services/order_capture_service.rb       | 22 +++++++++++++++++++++
 2 files changed, 26 insertions(+), 6 deletions(-)
 create mode 100644 app/services/order_capture_service.rb

diff --git a/app/controllers/api/v0/orders_controller.rb b/app/controllers/api/v0/orders_controller.rb
index 3f23a32e40..f36157db21 100644
--- a/app/controllers/api/v0/orders_controller.rb
+++ b/app/controllers/api/v0/orders_controller.rb
@@ -47,17 +47,15 @@ module Api
       def capture
         authorize! :admin, order
 
-        pending_payment = order.pending_payments.first
+        payment_capture = OrderCaptureService.new(order)
 
-        return payment_capture_failed unless order.payment_required? && pending_payment
-
-        if pending_payment.capture!
+        if payment_capture.call
           render json: order.reload, serializer: Api::Admin::OrderSerializer, status: :ok
+        elsif payment_capture.gateway_error.present?
+          error_during_processing(payment_capture.gateway_error)
         else
           payment_capture_failed
         end
-      rescue Spree::Core::GatewayError => e
-        error_during_processing(e)
       end
 
       private
diff --git a/app/services/order_capture_service.rb b/app/services/order_capture_service.rb
new file mode 100644
index 0000000000..78e69c9a1d
--- /dev/null
+++ b/app/services/order_capture_service.rb
@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+# Use `authorize! :admin order` before calling this service
+
+class OrderCaptureService
+  attr_reader :gateway_error
+
+  def initialize(order)
+    @order = order
+    @gateway_error = nil
+  end
+
+  def call
+    return false unless @order.payment_required?
+    return false unless (pending_payment = @order.pending_payments.first)
+
+    pending_payment.capture!
+  rescue Spree::Core::GatewayError => e
+    @gateway_error = e
+    false
+  end
+end

From e58a37f65ba150d1a8efecfd7b9d0e9a25452407 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Sun, 7 May 2023 19:58:43 +0100
Subject: [PATCH 10/38] Add reflex for capturing orders

---
 app/reflexes/admin/orders_reflex.rb            | 18 ++++++++++++++++++
 .../spree/admin/orders/_table_row.html.haml    |  2 +-
 2 files changed, 19 insertions(+), 1 deletion(-)
 create mode 100644 app/reflexes/admin/orders_reflex.rb

diff --git a/app/reflexes/admin/orders_reflex.rb b/app/reflexes/admin/orders_reflex.rb
new file mode 100644
index 0000000000..4a88592493
--- /dev/null
+++ b/app/reflexes/admin/orders_reflex.rb
@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+class Admin::OrdersReflex < ApplicationReflex
+  def capture
+    order = Spree::Order.find_by(id: element.dataset[:id])
+    authorize! :admin, order
+
+    payment_capture = OrderCaptureService.new(order)
+
+    if payment_capture.call
+      morph dom_id(order), render(partial: "spree/admin/orders/table_row",
+                                  locals: { order: order.reload, success: true })
+    else
+      flash[:error] = with_locale{ payment_capture.gateway_error || I18n.t(:payment_processing_failed) }
+      morph_admin_flashes
+    end
+  end
+end
diff --git a/app/views/spree/admin/orders/_table_row.html.haml b/app/views/spree/admin/orders/_table_row.html.haml
index 58c09d4bed..d264d2b379 100644
--- a/app/views/spree/admin/orders/_table_row.html.haml
+++ b/app/views/spree/admin/orders/_table_row.html.haml
@@ -45,4 +45,4 @@
       - if order.ready_to_ship?
         %button.icon-road.icon_link.with-tip.no-text{rel: 'nofollow', 'ofn-with-tip' => t('spree.admin.orders.index.ship')}
       - if order.payment_required? && order.pending_payments.reject(&:requires_authorization?).any?
-        %button.icon-capture.icon_link.no-text{rel: 'nofollow', 'ofn-with-tip' => t('spree.admin.orders.index.capture')}
+        %button.icon-capture.icon_link.no-text{"data-reflex": "click->Admin::OrdersReflex#capture", "data-id": order.id.to_s, 'ofn-with-tip' => t('spree.admin.orders.index.capture')}

From 25aecfa5b9c0cd997646ef6b40196f19896e4ad9 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Sun, 7 May 2023 20:25:07 +0100
Subject: [PATCH 11/38] Add reflex for shipping orders

---
 app/reflexes/admin/orders_reflex.rb           | 28 +++++++++++++++----
 .../spree/admin/orders/_table_row.html.haml   |  2 +-
 2 files changed, 23 insertions(+), 7 deletions(-)

diff --git a/app/reflexes/admin/orders_reflex.rb b/app/reflexes/admin/orders_reflex.rb
index 4a88592493..5e03440c72 100644
--- a/app/reflexes/admin/orders_reflex.rb
+++ b/app/reflexes/admin/orders_reflex.rb
@@ -1,18 +1,34 @@
 # frozen_string_literal: true
 
 class Admin::OrdersReflex < ApplicationReflex
-  def capture
-    order = Spree::Order.find_by(id: element.dataset[:id])
-    authorize! :admin, order
+  before_reflex :authorize_order, only: [:capture, :ship]
 
-    payment_capture = OrderCaptureService.new(order)
+  def capture
+    payment_capture = OrderCaptureService.new(@order)
 
     if payment_capture.call
-      morph dom_id(order), render(partial: "spree/admin/orders/table_row",
-                                  locals: { order: order.reload, success: true })
+      morph dom_id(@order), render(partial: "spree/admin/orders/table_row",
+                                   locals: { order: @order.reload, success: true })
     else
       flash[:error] = with_locale{ payment_capture.gateway_error || I18n.t(:payment_processing_failed) }
       morph_admin_flashes
     end
   end
+
+  def ship
+    if @order.ship
+      morph dom_id(@order), render(partial: "spree/admin/orders/table_row",
+                                   locals: { order: @order.reload, success: true })
+    else
+      flash[:error] = with_locale{ I18n.t("api.orders.failed_to_update") }
+      morph_admin_flashes
+    end
+  end
+
+  private
+
+  def authorize_order
+    @order = Spree::Order.find_by(id: element.dataset[:id])
+    authorize! :admin, @order
+  end
 end
diff --git a/app/views/spree/admin/orders/_table_row.html.haml b/app/views/spree/admin/orders/_table_row.html.haml
index d264d2b379..c91ef83936 100644
--- a/app/views/spree/admin/orders/_table_row.html.haml
+++ b/app/views/spree/admin/orders/_table_row.html.haml
@@ -43,6 +43,6 @@
           %i.success.icon-ok-sign{"data-controller": "ephemeral"}
       %a.icon_link.with-tip.icon-edit.no-text{href: edit_admin_order_path(order), 'ofn-with-tip' => t('spree.admin.orders.index.edit')}
       - if order.ready_to_ship?
-        %button.icon-road.icon_link.with-tip.no-text{rel: 'nofollow', 'ofn-with-tip' => t('spree.admin.orders.index.ship')}
+        %button.icon-road.icon_link.with-tip.no-text{"data-reflex": "click->Admin::OrdersReflex#ship", "data-id": order.id.to_s, 'ofn-with-tip' => t('spree.admin.orders.index.ship')}
       - if order.payment_required? && order.pending_payments.reject(&:requires_authorization?).any?
         %button.icon-capture.icon_link.no-text{"data-reflex": "click->Admin::OrdersReflex#capture", "data-id": order.id.to_s, 'ofn-with-tip' => t('spree.admin.orders.index.capture')}

From 27290e5b57ffd88f26997796d7fe529093a66fca Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Tue, 9 May 2023 18:16:42 +0100
Subject: [PATCH 12/38] Make modal controller creatable and destroyable

---
 .../controllers/mixins/useOpenAndCloseAsAModal.js          | 3 ++-
 app/webpacker/controllers/modal_controller.js              | 7 +++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/app/webpacker/controllers/mixins/useOpenAndCloseAsAModal.js b/app/webpacker/controllers/mixins/useOpenAndCloseAsAModal.js
index 0a4987806b..3c9e3d7b3d 100644
--- a/app/webpacker/controllers/mixins/useOpenAndCloseAsAModal.js
+++ b/app/webpacker/controllers/mixins/useOpenAndCloseAsAModal.js
@@ -11,7 +11,7 @@ export const useOpenAndCloseAsAModal = (controller) => {
       });
     }.bind(controller),
 
-    close: function () {
+    close: function (_event, remove = false) {
       this.modalTarget.classList.remove("in");
       this.backgroundTarget.classList.remove("in");
       document.querySelector("body").classList.remove("modal-open");
@@ -19,6 +19,7 @@ export const useOpenAndCloseAsAModal = (controller) => {
       setTimeout(() => {
         this.backgroundTarget.style.display = "none";
         this.modalTarget.style.display = "none";
+        if (remove) { this.element.remove() }
       }, 200);
     }.bind(controller),
 
diff --git a/app/webpacker/controllers/modal_controller.js b/app/webpacker/controllers/modal_controller.js
index bc8c0fcff2..3121c63ac3 100644
--- a/app/webpacker/controllers/modal_controller.js
+++ b/app/webpacker/controllers/modal_controller.js
@@ -3,13 +3,20 @@ import { useOpenAndCloseAsAModal } from "./mixins/useOpenAndCloseAsAModal";
 
 export default class extends Controller {
   static targets = ["background", "modal"];
+  static values = { instant: { type: Boolean, default: false } }
 
   connect() {
     useOpenAndCloseAsAModal(this);
     window.addEventListener("modal:close", this.close.bind(this));
+
+    if (this.instantValue) { this.open() }
   }
 
   disconnect() {
     window.removeEventListener("modal:close", this.close);
   }
+
+  remove(event) {
+    this.close(event, true)
+  }
 }

From 134f1ab151a6f2290ef36df17a6f997a7d2dc060 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Tue, 9 May 2023 18:50:20 +0100
Subject: [PATCH 13/38] Replace angular bulkInvoiceCtrl

---
 .../bulk_invoice_controller.js.coffee         | 32 -------------------
 .../directives/invoices_modal.js.coffee       |  5 ---
 app/channels/session_channel.rb               | 14 ++++++++
 app/jobs/bulk_invoice_job.rb                  | 21 ++++++++++--
 app/reflexes/admin/orders_reflex.rb           | 15 +++++++++
 .../admin/orders/_bulk_actions.html.haml      |  2 +-
 .../admin/orders/bulk/_invoice_link.html.haml |  7 ++++
 .../orders/bulk/_invoice_modal.html.haml      | 15 +++++++++
 app/webpacker/channels/session_channel.js     |  8 +++++
 .../controllers/bulk_invoice_controller.js    | 11 +++++++
 10 files changed, 90 insertions(+), 40 deletions(-)
 delete mode 100644 app/assets/javascripts/admin/orders/controllers/bulk_invoice_controller.js.coffee
 delete mode 100644 app/assets/javascripts/admin/orders/directives/invoices_modal.js.coffee
 create mode 100644 app/channels/session_channel.rb
 create mode 100644 app/views/spree/admin/orders/bulk/_invoice_link.html.haml
 create mode 100644 app/views/spree/admin/orders/bulk/_invoice_modal.html.haml
 create mode 100644 app/webpacker/channels/session_channel.js
 create mode 100644 app/webpacker/controllers/bulk_invoice_controller.js

diff --git a/app/assets/javascripts/admin/orders/controllers/bulk_invoice_controller.js.coffee b/app/assets/javascripts/admin/orders/controllers/bulk_invoice_controller.js.coffee
deleted file mode 100644
index cd6a02d40b..0000000000
--- a/app/assets/javascripts/admin/orders/controllers/bulk_invoice_controller.js.coffee
+++ /dev/null
@@ -1,32 +0,0 @@
-angular.module("admin.orders").controller "bulkInvoiceCtrl", ($scope, $http, $timeout) ->
-  $scope.createBulkInvoice = ->
-    $scope.invoice_id = null
-    $scope.poll = 1
-    $scope.loading = true
-    $scope.message = null
-    $scope.error = null
-    $scope.poll_wait = 5 # 5 Seconds between each check
-    $scope.poll_retries = 80 # Maximum checks before stopping
-
-    $http.post('/admin/orders/invoices', {order_ids: $scope.selected_orders}).then (response) ->
-      $scope.invoice_id = response.data
-      $scope.pollBulkInvoice()
-
-  $scope.pollBulkInvoice = ->
-    $timeout($scope.nextPoll, $scope.poll_wait * 1000)
-
-  $scope.nextPoll = ->
-    $http.get('/admin/orders/invoices/'+$scope.invoice_id+'/poll').then (response) ->
-      $scope.loading = false
-      $scope.message = t('js.admin.orders.index.bulk_invoice_created')
-
-    .catch (response) ->
-      $scope.poll++
-
-      if $scope.poll > $scope.poll_retries
-        $scope.loading = false
-        $scope.error = t('js.admin.orders.index.bulk_invoice_failed')
-        return
-
-      $scope.pollBulkInvoice()
-
diff --git a/app/assets/javascripts/admin/orders/directives/invoices_modal.js.coffee b/app/assets/javascripts/admin/orders/directives/invoices_modal.js.coffee
deleted file mode 100644
index 0f2eabe778..0000000000
--- a/app/assets/javascripts/admin/orders/directives/invoices_modal.js.coffee
+++ /dev/null
@@ -1,5 +0,0 @@
-angular.module("admin.orders").directive "invoicesModal", ($modal) ->
-  restrict: 'C'
-  link: (scope, elem, attrs, ctrl) ->
-    elem.on "click", (ev) =>
-      scope.uploadModal = $modal.open(templateUrl: 'admin/modals/bulk_invoice.html', controller: ctrl, scope: scope, windowClass: 'simple-modal')
diff --git a/app/channels/session_channel.rb b/app/channels/session_channel.rb
new file mode 100644
index 0000000000..ea42d56641
--- /dev/null
+++ b/app/channels/session_channel.rb
@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+class SessionChannel < ApplicationCable::Channel
+  def self.for_request(request)
+    "SessionChannel:#{request.session.id}"
+  end
+
+  def subscribed
+    return reject if current_user.nil?
+
+    stream_from "SessionChannel:#{session_id}"
+  end
+end
+
diff --git a/app/jobs/bulk_invoice_job.rb b/app/jobs/bulk_invoice_job.rb
index 0957ef393a..324554733d 100644
--- a/app/jobs/bulk_invoice_job.rb
+++ b/app/jobs/bulk_invoice_job.rb
@@ -1,7 +1,10 @@
 # frozen_string_literal: true
 
 class BulkInvoiceJob < ApplicationJob
-  def perform(order_ids, filepath)
+  include CableReady::Broadcaster
+  delegate :render, to: ActionController::Base
+
+  def perform(order_ids, filepath, options = {})
     pdf = CombinePDF.new
 
     sorted_orders(order_ids).each do |order|
@@ -11,6 +14,8 @@ class BulkInvoiceJob < ApplicationJob
     end
 
     pdf.save filepath
+
+    broadcast(filepath, options[:channel]) if options[:channel]
   end
 
   private
@@ -18,10 +23,22 @@ class BulkInvoiceJob < ApplicationJob
   # Ensures the records are returned in the same order the ids were originally given in
   def sorted_orders(order_ids)
     orders_by_id = Spree::Order.where(id: order_ids).to_a.index_by(&:id)
-    order_ids.map { |id| orders_by_id[id] }
+    order_ids.map { |id| orders_by_id[id.to_i] }
   end
 
   def renderer
     @renderer ||= InvoiceRenderer.new
   end
+
+  def broadcast(filepath, channel)
+    file_id = filepath.split("/").last.split(".").first
+
+    cable_ready[channel].
+      inner_html(
+        selector: "#bulk_invoices_modal .modal-content",
+        html: render(partial: "spree/admin/orders/bulk/invoice_link",
+                     locals: { invoice_url: "/admin/orders/invoices/#{file_id}" })
+      ).
+      broadcast
+  end
 end
diff --git a/app/reflexes/admin/orders_reflex.rb b/app/reflexes/admin/orders_reflex.rb
index 5e03440c72..6f300c82a2 100644
--- a/app/reflexes/admin/orders_reflex.rb
+++ b/app/reflexes/admin/orders_reflex.rb
@@ -25,6 +25,21 @@ class Admin::OrdersReflex < ApplicationReflex
     end
   end
 
+  def bulk_invoice(params)
+    cable_ready.append(
+      selector: "#orders-index",
+      html: render(partial: "spree/admin/orders/bulk/invoice_modal")
+    ).broadcast
+
+    BulkInvoiceJob.perform_later(
+      params[:order_ids],
+      "tmp/invoices/#{Time.zone.now.to_i}-#{SecureRandom.hex(2)}.pdf",
+      channel: SessionChannel.for_request(request)
+    )
+
+    morph :nothing
+  end
+
   private
 
   def authorize_order
diff --git a/app/views/spree/admin/orders/_bulk_actions.html.haml b/app/views/spree/admin/orders/_bulk_actions.html.haml
index bdbfdd466a..cea049867c 100644
--- a/app/views/spree/admin/orders/_bulk_actions.html.haml
+++ b/app/views/spree/admin/orders/_bulk_actions.html.haml
@@ -13,7 +13,7 @@
         %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "send_invoice" }
           = t('spree.admin.orders.index.send_invoice')
       %div.menu_item
-        %span.name.invoices-modal{'ng-controller' => 'bulkInvoiceCtrl', 'ng-click' => 'createBulkInvoice()' }
+        %span.name{ "data-controller": "bulk-invoice", "data-action": "click->bulk-invoice#generate" }
           = t('spree.admin.orders.index.print_invoices')
     %div.menu_item
       %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "cancel_orders" }
diff --git a/app/views/spree/admin/orders/bulk/_invoice_link.html.haml b/app/views/spree/admin/orders/bulk/_invoice_link.html.haml
new file mode 100644
index 0000000000..dbc5c455d5
--- /dev/null
+++ b/app/views/spree/admin/orders/bulk/_invoice_link.html.haml
@@ -0,0 +1,7 @@
+%p.message
+  = t('js.admin.orders.index.bulk_invoice_created')
+
+%br
+
+%a.button.primary{ target: '_blank', href: invoice_url }
+  = t('js.admin.orders.index.view_file')
diff --git a/app/views/spree/admin/orders/bulk/_invoice_modal.html.haml b/app/views/spree/admin/orders/bulk/_invoice_modal.html.haml
new file mode 100644
index 0000000000..07c2f30121
--- /dev/null
+++ b/app/views/spree/admin/orders/bulk/_invoice_modal.html.haml
@@ -0,0 +1,15 @@
+%div{ id: "bulk_invoices_modal", "data-controller": "modal", "data-modal-instant-value": true, "data-action": "keyup@document->modal#closeIfEscapeKey" }
+  .reveal-modal-bg.fade{ "data-modal-target": "background", "data-action": "click->modal#remove" }
+  .reveal-modal.fade.tiny.help-modal{ "data-modal-target": "modal" }
+    %div.fullwidth.align-center
+      %h4.modal-title
+        = t('js.admin.orders.index.compiling_invoices')
+        %br
+        %br
+      .modal-content
+        .modal-loading
+          %img.spinner{ src: image_path("/spinning-circles.svg") }
+          %br
+          %br
+          %p= t('js.admin.orders.index.please_wait')
+          %br
diff --git a/app/webpacker/channels/session_channel.js b/app/webpacker/channels/session_channel.js
new file mode 100644
index 0000000000..d43acef462
--- /dev/null
+++ b/app/webpacker/channels/session_channel.js
@@ -0,0 +1,8 @@
+import consumer from './consumer'
+import CableReady from 'cable_ready'
+
+consumer.subscriptions.create("SessionChannel", {
+  received(data) {
+    if (data.cableReady) CableReady.perform(data.operations)
+  }
+});
diff --git a/app/webpacker/controllers/bulk_invoice_controller.js b/app/webpacker/controllers/bulk_invoice_controller.js
new file mode 100644
index 0000000000..aebe57565c
--- /dev/null
+++ b/app/webpacker/controllers/bulk_invoice_controller.js
@@ -0,0 +1,11 @@
+import BulkActionsController from "./bulk_actions_controller";
+
+export default class extends BulkActionsController {
+  connect() {
+    super.connect();
+  }
+
+  generate() {
+    this.stimulate("Admin::OrdersReflex#bulk_invoice", { order_ids: super.getOrdersIds() });
+  }
+}

From 55d9deb5bd14d0ce86746063d46647fe892c8cb0 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Mon, 8 May 2023 14:07:28 +0100
Subject: [PATCH 14/38] Update order cancelling bulk action

---
 app/reflexes/cancel_orders_reflex.rb          | 14 ++++++--
 app/services/orders_bulk_cancel_service.rb    |  3 ++
 .../orders/messages/_cancel_orders.html.haml  |  4 +--
 .../controllers/cancel_orders_controller.js   | 32 +++++++++----------
 4 files changed, 33 insertions(+), 20 deletions(-)

diff --git a/app/reflexes/cancel_orders_reflex.rb b/app/reflexes/cancel_orders_reflex.rb
index 10876d018f..472a87bf39 100644
--- a/app/reflexes/cancel_orders_reflex.rb
+++ b/app/reflexes/cancel_orders_reflex.rb
@@ -2,8 +2,18 @@
 
 class CancelOrdersReflex < ApplicationReflex
   def confirm(params)
-    OrdersBulkCancelService.new(params, current_user).call
+    cancelled_orders = OrdersBulkCancelService.new(params, current_user).call
+
     cable_ready.dispatch_event(name: "modal:close")
-    # flash[:success] = Spree.t(:order_updated)
+
+    cancelled_orders.each do |order|
+      cable_ready.replace(
+        selector: dom_id(order),
+        html: render(partial: "spree/admin/orders/table_row", locals: { order: order })
+      )
+    end
+
+    cable_ready.broadcast
+    morph :nothing
   end
 end
diff --git a/app/services/orders_bulk_cancel_service.rb b/app/services/orders_bulk_cancel_service.rb
index 2f51709eeb..7a69b9dac5 100644
--- a/app/services/orders_bulk_cancel_service.rb
+++ b/app/services/orders_bulk_cancel_service.rb
@@ -9,11 +9,14 @@ class OrdersBulkCancelService
   end
 
   def call
+    updated = []
     editable_orders.where(id: @order_ids).find_each do |order|
       order.send_cancellation_email = @send_cancellation_email
       order.restock_items = @restock_items
       order.cancel
+      updated << order
     end
+    updated
   end
 
   private
diff --git a/app/views/spree/admin/orders/messages/_cancel_orders.html.haml b/app/views/spree/admin/orders/messages/_cancel_orders.html.haml
index 00d30d1eed..ca9093665d 100644
--- a/app/views/spree/admin/orders/messages/_cancel_orders.html.haml
+++ b/app/views/spree/admin/orders/messages/_cancel_orders.html.haml
@@ -1,10 +1,10 @@
 .modal-message
-  .form
+  %form{ "data-cancel-orders-target": "extraParams" }
     %input{ type: "checkbox", name: "send_cancellation_email", value: "1", id: "send_cancellation_email", checked: "true" }
     %label{ for: "send_cancellation_email" }
       = t("js.admin.orders.cancel_the_order_send_cancelation_email")
     %br
-    %input{ type: "checkbox", name: "restock_items", id: "restock_items", checked: "true" }
+    %input{ type: "checkbox", name: "restock_items", value: "1", id: "restock_items", checked: "true" }
     %label{ for: "restock_items" }
       = t("js.admin.orders.restock_items")
     .margin-bottom-30
diff --git a/app/webpacker/controllers/cancel_orders_controller.js b/app/webpacker/controllers/cancel_orders_controller.js
index a017edda2b..8ede1134a1 100644
--- a/app/webpacker/controllers/cancel_orders_controller.js
+++ b/app/webpacker/controllers/cancel_orders_controller.js
@@ -1,27 +1,27 @@
-import ApplicationController from "./application_controller";
+import BulkActionsController from "./bulk_actions_controller";
+
+export default class extends BulkActionsController {
+  static targets = ["extraParams"]
 
-export default class extends ApplicationController {
   connect() {
     super.connect();
   }
 
   confirm() {
-    const send_cancellation_email = document.querySelector("#send_cancellation_email").checked;
-    const restock_items = document.querySelector("#restock_items").checked;
-    const order_ids = [];
+    let data = { order_ids: super.getOrdersIds() };
 
-    document
-      .querySelectorAll("#listing_orders input[name='order_ids[]']:checked")
-      .forEach((checkbox) => {
-        order_ids.push(checkbox.value);
-      });
+    if (this.hasExtraParamsTarget) {
+      Object.assign(data, this.extraFormData())
+    }
 
-    const params = {
-      order_ids: order_ids,
-      send_cancellation_email: send_cancellation_email,
-      restock_items: restock_items,
-    };
+    this.stimulate("CancelOrdersReflex#confirm", data);
+  }
 
-    this.stimulate("CancelOrdersReflex#confirm", params);
+  // private
+
+  extraFormData() {
+    if (this.extraParamsTarget.constructor.name !== "HTMLFormElement") { return {} }
+
+    return Object.fromEntries(new FormData(this.extraParamsTarget).entries())
   }
 }

From 5930d0c1f58bc766f4689b5f678ea8449d5effd0 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Tue, 9 May 2023 20:45:13 +0100
Subject: [PATCH 15/38] Make bulk actions more generic

---
 app/reflexes/admin/orders_reflex.rb           |  2 +-
 app/services/orders_bulk_cancel_service.rb    |  2 +-
 .../spree/admin/orders/_table_row.html.haml   |  2 +-
 .../controllers/bulk_actions_controller.js    |  6 ++---
 .../controllers/bulk_invoice_controller.js    |  2 +-
 .../controllers/cancel_orders_controller.js   |  2 +-
 spec/system/admin/orders_spec.rb              | 24 +++++++++----------
 7 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/app/reflexes/admin/orders_reflex.rb b/app/reflexes/admin/orders_reflex.rb
index 6f300c82a2..db23c56a03 100644
--- a/app/reflexes/admin/orders_reflex.rb
+++ b/app/reflexes/admin/orders_reflex.rb
@@ -32,7 +32,7 @@ class Admin::OrdersReflex < ApplicationReflex
     ).broadcast
 
     BulkInvoiceJob.perform_later(
-      params[:order_ids],
+      params[:bulk_ids],
       "tmp/invoices/#{Time.zone.now.to_i}-#{SecureRandom.hex(2)}.pdf",
       channel: SessionChannel.for_request(request)
     )
diff --git a/app/services/orders_bulk_cancel_service.rb b/app/services/orders_bulk_cancel_service.rb
index 7a69b9dac5..e041f6f2a6 100644
--- a/app/services/orders_bulk_cancel_service.rb
+++ b/app/services/orders_bulk_cancel_service.rb
@@ -2,7 +2,7 @@
 
 class OrdersBulkCancelService
   def initialize(params, current_user)
-    @order_ids = params[:order_ids]
+    @order_ids = params[:bulk_ids]
     @current_user = current_user
     @send_cancellation_email = params[:send_cancellation_email]
     @restock_items = params[:restock_items]
diff --git a/app/views/spree/admin/orders/_table_row.html.haml b/app/views/spree/admin/orders/_table_row.html.haml
index c91ef83936..c4809f08f5 100644
--- a/app/views/spree/admin/orders/_table_row.html.haml
+++ b/app/views/spree/admin/orders/_table_row.html.haml
@@ -1,6 +1,6 @@
 %tr{ id: dom_id(order), class: "state-#{order.state}" }
   %td.align-center
-    %input{type: 'checkbox', value: order.id, name: 'order_ids[]', "data-checked-target": "checkbox", "data-action": "change->checked#toggleCheckbox" }
+    %input{type: 'checkbox', value: order.id, name: 'bulk_ids[]', "data-checked-target": "checkbox", "data-action": "change->checked#toggleCheckbox" }
   %td.align-center
     = order.distributor.name
   %td.align-center
diff --git a/app/webpacker/controllers/bulk_actions_controller.js b/app/webpacker/controllers/bulk_actions_controller.js
index a413222b65..791eddc820 100644
--- a/app/webpacker/controllers/bulk_actions_controller.js
+++ b/app/webpacker/controllers/bulk_actions_controller.js
@@ -7,13 +7,13 @@ export default class extends ApplicationController {
 
   // abstract
   confirm(action) {
-    this.stimulate(action, this.getOrdersIds());
+    this.stimulate(action, this.getSelectedIds());
   }
 
   // private
-  getOrdersIds() {
+  getSelectedIds() {
     const checkboxes = document.querySelectorAll(
-      "#listing_orders input[name='order_ids[]']:checked"
+      "table input[name='bulk_ids[]']:checked"
     );
     return Array.from(checkboxes).map((checkbox) => checkbox.value);
   }
diff --git a/app/webpacker/controllers/bulk_invoice_controller.js b/app/webpacker/controllers/bulk_invoice_controller.js
index aebe57565c..3b09724bcd 100644
--- a/app/webpacker/controllers/bulk_invoice_controller.js
+++ b/app/webpacker/controllers/bulk_invoice_controller.js
@@ -6,6 +6,6 @@ export default class extends BulkActionsController {
   }
 
   generate() {
-    this.stimulate("Admin::OrdersReflex#bulk_invoice", { order_ids: super.getOrdersIds() });
+    this.stimulate("Admin::OrdersReflex#bulk_invoice", { bulk_ids: super.getSelectedIds() });
   }
 }
diff --git a/app/webpacker/controllers/cancel_orders_controller.js b/app/webpacker/controllers/cancel_orders_controller.js
index 8ede1134a1..b735cea31a 100644
--- a/app/webpacker/controllers/cancel_orders_controller.js
+++ b/app/webpacker/controllers/cancel_orders_controller.js
@@ -8,7 +8,7 @@ export default class extends BulkActionsController {
   }
 
   confirm() {
-    let data = { order_ids: super.getOrdersIds() };
+    let data = { bulk_ids: super.getSelectedIds() };
 
     if (this.hasExtraParamsTarget) {
       Object.assign(data, this.extraFormData())
diff --git a/spec/system/admin/orders_spec.rb b/spec/system/admin/orders_spec.rb
index f20e839ca6..50231f03aa 100644
--- a/spec/system/admin/orders_spec.rb
+++ b/spec/system/admin/orders_spec.rb
@@ -465,10 +465,10 @@ distributors: [distributor4, distributor5]) }
 
             it "can bulk print invoices but only for the 'complete' or 'resumed' ones" do
               within "#listing_orders" do
-                page.find("input[name='order_ids[]'][value='#{order2.id}']").click
-                page.find("input[name='order_ids[]'][value='#{order3.id}']").click
-                page.find("input[name='order_ids[]'][value='#{order4.id}']").click
-                page.find("input[name='order_ids[]'][value='#{order5.id}']").click
+                page.find("input[name='bulk_ids[]'][value='#{order2.id}']").click
+                page.find("input[name='bulk_ids[]'][value='#{order3.id}']").click
+                page.find("input[name='bulk_ids[]'][value='#{order4.id}']").click
+                page.find("input[name='bulk_ids[]'][value='#{order5.id}']").click
               end
 
               page.find("span.icon-reorder", text: "ACTIONS").click
@@ -492,8 +492,8 @@ distributors: [distributor4, distributor5]) }
         end
 
         it "can bulk send email to 2 orders" do
-          page.find("#listing_orders tbody tr:nth-child(1) input[name='order_ids[]']").click
-          page.find("#listing_orders tbody tr:nth-child(2) input[name='order_ids[]']").click
+          page.find("#listing_orders tbody tr:nth-child(1) input[name='bulk_ids[]']").click
+          page.find("#listing_orders tbody tr:nth-child(2) input[name='bulk_ids[]']").click
 
           page.find("span.icon-reorder", text: "ACTIONS").click
           within ".ofn-drop-down-with-prepend .menu" do
@@ -512,8 +512,8 @@ distributors: [distributor4, distributor5]) }
         end
 
         it "can bulk print invoices from 2 orders" do
-          page.find("#listing_orders tbody tr:nth-child(1) input[name='order_ids[]']").click
-          page.find("#listing_orders tbody tr:nth-child(2) input[name='order_ids[]']").click
+          page.find("#listing_orders tbody tr:nth-child(1) input[name='bulk_ids[]']").click
+          page.find("#listing_orders tbody tr:nth-child(2) input[name='bulk_ids[]']").click
 
           page.find("span.icon-reorder", text: "ACTIONS").click
           within ".ofn-drop-down-with-prepend .menu" do
@@ -527,8 +527,8 @@ distributors: [distributor4, distributor5]) }
         end
 
         it "can bulk cancel 2 orders" do
-          page.find("#listing_orders tbody tr:nth-child(1) input[name='order_ids[]']").click
-          page.find("#listing_orders tbody tr:nth-child(2) input[name='order_ids[]']").click
+          page.find("#listing_orders tbody tr:nth-child(1) input[name='bulk_ids[]']").click
+          page.find("#listing_orders tbody tr:nth-child(2) input[name='bulk_ids[]']").click
 
           page.find("span.icon-reorder", text: "ACTIONS").click
           within ".ofn-drop-down-with-prepend .menu" do
@@ -574,10 +574,10 @@ distributors: [distributor4, distributor5]) }
         end
 
         it "cannot send emails to orders if permission have been revoked in the meantime" do
-          page.find("#listing_orders tbody tr:nth-child(1) input[name='order_ids[]']").click
+          page.find("#listing_orders tbody tr:nth-child(1) input[name='bulk_ids[]']").click
           # Find the clicked order
           order = Spree::Order.find_by(
-            id: page.find("#listing_orders tbody tr:nth-child(1) input[name='order_ids[]']").value
+            id: page.find("#listing_orders tbody tr:nth-child(1) input[name='bulk_ids[]']").value
           )
           # Revoke permission for the current user on that specific order by changing its owners
           order.update_attribute(:distributor, distributor)

From bee46720f44774121f305665ec6f7e72f5216ea4 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Tue, 9 May 2023 23:11:42 +0100
Subject: [PATCH 16/38] Combine bulk action controllers and pass reflex as an
 argument

---
 app/components/confirm_modal_component.rb     |  5 ++--
 .../confirm_modal_component.html.haml         |  2 +-
 .../admin/orders/_bulk_actions.html.haml      |  2 +-
 app/views/spree/admin/orders/index.html.haml  |  6 ++---
 .../orders/messages/_cancel_orders.html.haml  |  2 +-
 .../controllers/bulk_actions_controller.js    | 21 ++++++++++++---
 .../controllers/bulk_invoice_controller.js    | 11 --------
 .../controllers/cancel_orders_controller.js   | 27 -------------------
 .../resend_confirmation_email_controller.js   | 11 --------
 .../controllers/send_invoice_controller.js    | 11 --------
 10 files changed, 27 insertions(+), 71 deletions(-)
 delete mode 100644 app/webpacker/controllers/bulk_invoice_controller.js
 delete mode 100644 app/webpacker/controllers/cancel_orders_controller.js
 delete mode 100644 app/webpacker/controllers/resend_confirmation_email_controller.js
 delete mode 100644 app/webpacker/controllers/send_invoice_controller.js

diff --git a/app/components/confirm_modal_component.rb b/app/components/confirm_modal_component.rb
index 3a73af0e68..4fd17dc908 100644
--- a/app/components/confirm_modal_component.rb
+++ b/app/components/confirm_modal_component.rb
@@ -1,11 +1,12 @@
 # frozen_string_literal: true
 
 class ConfirmModalComponent < ModalComponent
-  def initialize(id:, confirm_actions: nil, controllers: nil, message: nil, confirm_reflexes: nil)
+  def initialize(id:, confirm_actions: nil, reflex: nil, controller: nil, message: nil, confirm_reflexes: nil)
     super(id: id, close_button: true)
     @confirm_actions = confirm_actions
+    @reflex = reflex
     @confirm_reflexes = confirm_reflexes
-    @controllers = controllers
+    @controller = controller
     @message = message
   end
 
diff --git a/app/components/confirm_modal_component/confirm_modal_component.html.haml b/app/components/confirm_modal_component/confirm_modal_component.html.haml
index 0c507885ce..1b3e1ff217 100644
--- a/app/components/confirm_modal_component/confirm_modal_component.html.haml
+++ b/app/components/confirm_modal_component/confirm_modal_component.html.haml
@@ -1,4 +1,4 @@
-%div{ id: @id, "data-controller": "modal #{@controllers}", "data-action": "keyup@document->modal#closeIfEscapeKey" }
+%div{ id: @id, "data-controller": "modal #{@controller}", "data-action": "keyup@document->modal#closeIfEscapeKey", "data-#{@controller}-reflex-value": @reflex }
   .reveal-modal-bg.fade{ "data-modal-target": "background", "data-action": "click->modal#close" }
   .reveal-modal.fade.tiny.help-modal{ "data-modal-target": "modal" }
     = content
diff --git a/app/views/spree/admin/orders/_bulk_actions.html.haml b/app/views/spree/admin/orders/_bulk_actions.html.haml
index cea049867c..ce3abc5ca7 100644
--- a/app/views/spree/admin/orders/_bulk_actions.html.haml
+++ b/app/views/spree/admin/orders/_bulk_actions.html.haml
@@ -13,7 +13,7 @@
         %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "send_invoice" }
           = t('spree.admin.orders.index.send_invoice')
       %div.menu_item
-        %span.name{ "data-controller": "bulk-invoice", "data-action": "click->bulk-invoice#generate" }
+        %span.name{ "data-controller": "bulk-actions", "data-action": "click->bulk-actions#perform", "data-bulk-actions-reflex-value": "Admin::Orders#bulk_invoice" }
           = t('spree.admin.orders.index.print_invoices')
     %div.menu_item
       %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "cancel_orders" }
diff --git a/app/views/spree/admin/orders/index.html.haml b/app/views/spree/admin/orders/index.html.haml
index d46af52b9a..a7d64de200 100644
--- a/app/views/spree/admin/orders/index.html.haml
+++ b/app/views/spree/admin/orders/index.html.haml
@@ -20,14 +20,14 @@
 
 = render 'spree/admin/shared/custom-confirm'
 
-= render ConfirmModalComponent.new(id: "resend_confirmation", confirm_actions: "click->resend-confirmation-email#confirm", controllers: "resend-confirmation-email") do
+= render ConfirmModalComponent.new(id: "resend_confirmation", confirm_actions: "click->bulk-actions#perform", controller: "bulk-actions", reflex: "BulkActionsInOrdersList#resend_confirmation_email") do
   .margin-bottom-30
     = t('.resend_confirmation_confirm_html')
 
-= render ConfirmModalComponent.new(id: "send_invoice", confirm_actions: "click->send-invoice#confirm", controllers: "send-invoice") do
+= render ConfirmModalComponent.new(id: "send_invoice", confirm_actions: "click->bulk-actions#perform", controller: "bulk-actions", reflex: "BulkActionsInOrdersList#send_invoice") do
   .margin-bottom-30
     = t('.send_invoice_confirm_html')
 
-= render ConfirmModalComponent.new(id: "cancel_orders", confirm_actions: "click->cancel-orders#confirm", controllers: "cancel-orders", message: "spree/admin/orders/messages/cancel_orders") do
+= render ConfirmModalComponent.new(id: "cancel_orders", confirm_actions: "click->bulk-actions#perform", controller: "bulk-actions", reflex: "CancelOrders#confirm", message: "spree/admin/orders/messages/cancel_orders") do
   .margin-bottom-30
     = t("js.admin.orders.cancel_the_order_html")
diff --git a/app/views/spree/admin/orders/messages/_cancel_orders.html.haml b/app/views/spree/admin/orders/messages/_cancel_orders.html.haml
index ca9093665d..9b689ff75e 100644
--- a/app/views/spree/admin/orders/messages/_cancel_orders.html.haml
+++ b/app/views/spree/admin/orders/messages/_cancel_orders.html.haml
@@ -1,5 +1,5 @@
 .modal-message
-  %form{ "data-cancel-orders-target": "extraParams" }
+  %form{ "data-bulk-actions-target": "extraParams" }
     %input{ type: "checkbox", name: "send_cancellation_email", value: "1", id: "send_cancellation_email", checked: "true" }
     %label{ for: "send_cancellation_email" }
       = t("js.admin.orders.cancel_the_order_send_cancelation_email")
diff --git a/app/webpacker/controllers/bulk_actions_controller.js b/app/webpacker/controllers/bulk_actions_controller.js
index 791eddc820..9de40fe8cb 100644
--- a/app/webpacker/controllers/bulk_actions_controller.js
+++ b/app/webpacker/controllers/bulk_actions_controller.js
@@ -1,20 +1,35 @@
 import ApplicationController from "./application_controller";
 
 export default class extends ApplicationController {
+  static targets = ["extraParams"]
+  static values = { reflex: String }
+
   connect() {
     super.connect();
   }
 
-  // abstract
-  confirm(action) {
-    this.stimulate(action, this.getSelectedIds());
+  perform() {
+    let params = { bulk_ids: this.getSelectedIds() };
+
+    if (this.hasExtraParamsTarget) {
+      Object.assign(params, this.extraFormData())
+    }
+
+    this.stimulate(this.reflexValue, params);
   }
 
   // private
+
   getSelectedIds() {
     const checkboxes = document.querySelectorAll(
       "table input[name='bulk_ids[]']:checked"
     );
     return Array.from(checkboxes).map((checkbox) => checkbox.value);
   }
+
+  extraFormData() {
+    if (this.extraParamsTarget.constructor.name !== "HTMLFormElement") { return {} }
+
+    return Object.fromEntries(new FormData(this.extraParamsTarget).entries())
+  }
 }
diff --git a/app/webpacker/controllers/bulk_invoice_controller.js b/app/webpacker/controllers/bulk_invoice_controller.js
deleted file mode 100644
index 3b09724bcd..0000000000
--- a/app/webpacker/controllers/bulk_invoice_controller.js
+++ /dev/null
@@ -1,11 +0,0 @@
-import BulkActionsController from "./bulk_actions_controller";
-
-export default class extends BulkActionsController {
-  connect() {
-    super.connect();
-  }
-
-  generate() {
-    this.stimulate("Admin::OrdersReflex#bulk_invoice", { bulk_ids: super.getSelectedIds() });
-  }
-}
diff --git a/app/webpacker/controllers/cancel_orders_controller.js b/app/webpacker/controllers/cancel_orders_controller.js
deleted file mode 100644
index b735cea31a..0000000000
--- a/app/webpacker/controllers/cancel_orders_controller.js
+++ /dev/null
@@ -1,27 +0,0 @@
-import BulkActionsController from "./bulk_actions_controller";
-
-export default class extends BulkActionsController {
-  static targets = ["extraParams"]
-
-  connect() {
-    super.connect();
-  }
-
-  confirm() {
-    let data = { bulk_ids: super.getSelectedIds() };
-
-    if (this.hasExtraParamsTarget) {
-      Object.assign(data, this.extraFormData())
-    }
-
-    this.stimulate("CancelOrdersReflex#confirm", data);
-  }
-
-  // private
-
-  extraFormData() {
-    if (this.extraParamsTarget.constructor.name !== "HTMLFormElement") { return {} }
-
-    return Object.fromEntries(new FormData(this.extraParamsTarget).entries())
-  }
-}
diff --git a/app/webpacker/controllers/resend_confirmation_email_controller.js b/app/webpacker/controllers/resend_confirmation_email_controller.js
deleted file mode 100644
index ea48c61416..0000000000
--- a/app/webpacker/controllers/resend_confirmation_email_controller.js
+++ /dev/null
@@ -1,11 +0,0 @@
-import BulkActionsController from "./bulk_actions_controller";
-
-export default class extends BulkActionsController {
-  connect() {
-    super.connect();
-  }
-
-  confirm() {
-    super.confirm("BulkActionsInOrdersList#resend_confirmation_email");
-  }
-}
diff --git a/app/webpacker/controllers/send_invoice_controller.js b/app/webpacker/controllers/send_invoice_controller.js
deleted file mode 100644
index 747735f0ee..0000000000
--- a/app/webpacker/controllers/send_invoice_controller.js
+++ /dev/null
@@ -1,11 +0,0 @@
-import BulkActionsController from "./bulk_actions_controller";
-
-export default class extends BulkActionsController {
-  connect() {
-    super.connect();
-  }
-
-  confirm() {
-    super.confirm("BulkActionsInOrdersList#send_invoice");
-  }
-}

From 95f1643cec7940faed893203b81a7390fa46fc1c Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Tue, 9 May 2023 23:42:44 +0100
Subject: [PATCH 17/38] Combine related reflex actions

---
 app/reflexes/admin/orders_reflex.rb           | 48 +++++++++++++++++++
 .../bulk_actions_in_orders_list_reflex.rb     | 35 --------------
 app/reflexes/cancel_orders_reflex.rb          | 19 --------
 app/views/spree/admin/orders/index.html.haml  |  6 +--
 4 files changed, 51 insertions(+), 57 deletions(-)
 delete mode 100644 app/reflexes/bulk_actions_in_orders_list_reflex.rb
 delete mode 100644 app/reflexes/cancel_orders_reflex.rb

diff --git a/app/reflexes/admin/orders_reflex.rb b/app/reflexes/admin/orders_reflex.rb
index db23c56a03..464a1b3c3e 100644
--- a/app/reflexes/admin/orders_reflex.rb
+++ b/app/reflexes/admin/orders_reflex.rb
@@ -40,10 +40,58 @@ class Admin::OrdersReflex < ApplicationReflex
     morph :nothing
   end
 
+  def cancel_orders(params)
+    cancelled_orders = OrdersBulkCancelService.new(params, current_user).call
+
+    cable_ready.dispatch_event(name: "modal:close")
+
+    cancelled_orders.each do |order|
+      cable_ready.replace(
+        selector: dom_id(order),
+        html: render(partial: "spree/admin/orders/table_row", locals: { order: order })
+      )
+    end
+
+    cable_ready.broadcast
+    morph :nothing
+  end
+
+  def resend_confirmation_emails(params)
+    editable_orders.where(id: params[:bulk_ids]).find_each do |order|
+      next unless can? :resend, order
+
+      Spree::OrderMailer.confirm_email_for_customer(order.id, true).deliver_later
+    end
+
+    success("admin.resend_confirmation_emails_feedback", params[:bulk_ids].count)
+  end
+
+  def send_invoices(params)
+    count = 0
+    editable_orders.where(id: params[:bulk_ids]).find_each do |o|
+      next unless o.distributor.can_invoice? && (o.resumed? || o.complete?)
+
+      Spree::OrderMailer.invoice_email(o.id).deliver_later
+      count += 1
+    end
+
+    success("admin.send_invoice_feedback", count)
+  end
+
   private
 
   def authorize_order
     @order = Spree::Order.find_by(id: element.dataset[:id])
     authorize! :admin, @order
   end
+
+  def success(i18n_key, count)
+    flash[:success] = with_locale { I18n.t(i18n_key, count: count) }
+    cable_ready.dispatch_event(name: "modal:close")
+    morph_admin_flashes
+  end
+
+  def editable_orders
+    Permissions::Order.new(current_user).editable_orders
+  end
 end
diff --git a/app/reflexes/bulk_actions_in_orders_list_reflex.rb b/app/reflexes/bulk_actions_in_orders_list_reflex.rb
deleted file mode 100644
index 03cff66633..0000000000
--- a/app/reflexes/bulk_actions_in_orders_list_reflex.rb
+++ /dev/null
@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-class BulkActionsInOrdersListReflex < ApplicationReflex
-  def resend_confirmation_email(order_ids)
-    editable_orders.where(id: order_ids).find_each do |o|
-      Spree::OrderMailer.confirm_email_for_customer(o.id, true).deliver_later if can? :resend, o
-    end
-
-    success("admin.resend_confirmation_emails_feedback", order_ids.count)
-  end
-
-  def send_invoice(order_ids)
-    count = 0
-    editable_orders.where(id: order_ids).find_each do |o|
-      next unless o.distributor.can_invoice? && (o.resumed? || o.complete?)
-
-      Spree::OrderMailer.invoice_email(o.id).deliver_later
-      count += 1
-    end
-
-    success("admin.send_invoice_feedback", count)
-  end
-
-  private
-
-  def success(i18n_key, count)
-    flash[:success] = I18n.t(i18n_key, count: count)
-    cable_ready.dispatch_event(name: "modal:close")
-    morph "#flashes", render(partial: "shared/flashes", locals: { flashes: flash })
-  end
-
-  def editable_orders
-    Permissions::Order.new(current_user).editable_orders
-  end
-end
diff --git a/app/reflexes/cancel_orders_reflex.rb b/app/reflexes/cancel_orders_reflex.rb
deleted file mode 100644
index 472a87bf39..0000000000
--- a/app/reflexes/cancel_orders_reflex.rb
+++ /dev/null
@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-class CancelOrdersReflex < ApplicationReflex
-  def confirm(params)
-    cancelled_orders = OrdersBulkCancelService.new(params, current_user).call
-
-    cable_ready.dispatch_event(name: "modal:close")
-
-    cancelled_orders.each do |order|
-      cable_ready.replace(
-        selector: dom_id(order),
-        html: render(partial: "spree/admin/orders/table_row", locals: { order: order })
-      )
-    end
-
-    cable_ready.broadcast
-    morph :nothing
-  end
-end
diff --git a/app/views/spree/admin/orders/index.html.haml b/app/views/spree/admin/orders/index.html.haml
index a7d64de200..26a7965a69 100644
--- a/app/views/spree/admin/orders/index.html.haml
+++ b/app/views/spree/admin/orders/index.html.haml
@@ -20,14 +20,14 @@
 
 = render 'spree/admin/shared/custom-confirm'
 
-= render ConfirmModalComponent.new(id: "resend_confirmation", confirm_actions: "click->bulk-actions#perform", controller: "bulk-actions", reflex: "BulkActionsInOrdersList#resend_confirmation_email") do
+= render ConfirmModalComponent.new(id: "resend_confirmation", confirm_actions: "click->bulk-actions#perform", controller: "bulk-actions", reflex: "Admin::Orders#resend_confirmation_emails") do
   .margin-bottom-30
     = t('.resend_confirmation_confirm_html')
 
-= render ConfirmModalComponent.new(id: "send_invoice", confirm_actions: "click->bulk-actions#perform", controller: "bulk-actions", reflex: "BulkActionsInOrdersList#send_invoice") do
+= render ConfirmModalComponent.new(id: "send_invoice", confirm_actions: "click->bulk-actions#perform", controller: "bulk-actions", reflex: "Admin::Orders#send_invoices") do
   .margin-bottom-30
     = t('.send_invoice_confirm_html')
 
-= render ConfirmModalComponent.new(id: "cancel_orders", confirm_actions: "click->bulk-actions#perform", controller: "bulk-actions", reflex: "CancelOrders#confirm", message: "spree/admin/orders/messages/cancel_orders") do
+= render ConfirmModalComponent.new(id: "cancel_orders", confirm_actions: "click->bulk-actions#perform", controller: "bulk-actions", reflex: "Admin::Orders#cancel_orders", message: "spree/admin/orders/messages/cancel_orders") do
   .margin-bottom-30
     = t("js.admin.orders.cancel_the_order_html")

From 71c4f2a5bec9372bcb9735de36767dae5676c7d4 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 10 May 2023 12:39:04 +0100
Subject: [PATCH 18/38] Update styling on multiselect tabs for tom-select

---
 .../css/admin/components/tom_select.scss        | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/app/webpacker/css/admin/components/tom_select.scss b/app/webpacker/css/admin/components/tom_select.scss
index 75684615fd..4c1d31d0e4 100644
--- a/app/webpacker/css/admin/components/tom_select.scss
+++ b/app/webpacker/css/admin/components/tom_select.scss
@@ -2,6 +2,23 @@
   min-height: initial;
 }
 
+.ts-wrapper.multi .ts-control [data-value] {
+  text-shadow: none;
+  background-image: none;
+  background-repeat: initial;
+  box-shadow: none;
+  background-color: $spree-blue;
+}
+
+.ts-wrapper.multi .ts-control > div {
+  border: none;
+  background-color: $spree-blue;
+}
+
+.ts-wrapper.plugin-remove_button .item .remove {
+  font-weight: bold;
+}
+
 .ts-dropdown {
   margin-top: 0;
 

From c3cf79f5efd5e5db37d71c9f1c36ab21b5c0d398 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 10 May 2023 12:44:25 +0100
Subject: [PATCH 19/38] Delete angular ordersCtrl

---
 .../controllers/orders_controller.js.coffee   | 117 ------------------
 app/views/spree/admin/orders/edit.html.haml   |   4 +-
 .../orders_controller_spec.js.coffee          |  76 ------------
 3 files changed, 2 insertions(+), 195 deletions(-)
 delete mode 100644 app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
 delete mode 100644 spec/javascripts/unit/admin/orders/controllers/orders_controller_spec.js.coffee

diff --git a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee b/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
deleted file mode 100644
index 95486ce19d..0000000000
--- a/app/assets/javascripts/admin/orders/controllers/orders_controller.js.coffee
+++ /dev/null
@@ -1,117 +0,0 @@
-angular.module("admin.orders").controller "ordersCtrl", ($scope, $timeout, RequestMonitor, Orders, SortOptions, $window, $filter, $location, KeyValueMapStore) ->
-  $scope.RequestMonitor = RequestMonitor
-  $scope.pagination = Orders.pagination
-  $scope.orders = Orders.all
-  $scope.sortOptions = SortOptions
-  $scope.per_page_options = [
-    {id: 15, name: t('js.admin.orders.index.per_page', results: 15)},
-    {id: 50, name: t('js.admin.orders.index.per_page', results: 50)},
-    {id: 100, name: t('js.admin.orders.index.per_page', results: 100)}
-  ]
-  $scope.selected_orders = []
-  $scope.checkboxes = {}
-  $scope.selected = false
-  $scope.select_all = false
-  $scope.poll = 0
-  $scope.rowStatus = {}
-
-  KeyValueMapStore.localStorageKey = 'ordersFilters'
-  KeyValueMapStore.storableKeys = ["q", "sorting", "page", "per_page"]
-
-  $scope.initialise = ->
-    unless KeyValueMapStore.restoreValues($scope)
-      $scope.setDefaults()
-
-    $scope.fetchResults()
-
-  $scope.setDefaults = ->
-    $scope.per_page = 15
-    $scope.q = {
-      completed_at_not_null: true
-    }
-    e = new CustomEvent("flatpickr_clear");
-    window.dispatchEvent(e)
-
-  $scope.clearFilters = () ->
-    KeyValueMapStore.clearKeyValueMap()
-    $scope.setDefaults()
-    $scope.fetchResults()
-
-  $scope.fetchResults = (page=1) ->
-    startDateWithTime = $scope.appendStringIfNotEmpty($scope.q?.completed_at_gteq, ' 00:00:00')
-    endDateWithTime = $scope.appendStringIfNotEmpty($scope.q?.completed_at_lteq, ' 23:59:59')
-
-    $scope.resetSelected()
-    params = {
-      'q[completed_at_gteq]': startDateWithTime,
-      'q[completed_at_lteq]': endDateWithTime,
-      'q[state_eq]': $scope.q?.state_eq,
-      'q[number_cont]': $scope.q?.number_cont,
-      'q[email_cont]': $scope.q?.email_cont,
-      'q[bill_address_firstname_start]': $scope.q?.bill_address_firstname_start,
-      'q[bill_address_lastname_start]': $scope.q?.bill_address_lastname_start,
-      # Set default checkbox values to null. See: https://github.com/openfoodfoundation/openfoodnetwork/pull/3076#issuecomment-440010498
-      'q[completed_at_not_null]': $scope.q?.completed_at_not_null || null,
-      'q[distributor_id_in][]': $scope.q?.distributor_id_in,
-      'q[order_cycle_id_in][]': $scope.q?.order_cycle_id_in,
-      'q[s]': $scope.sorting || 'completed_at desc',
-      shipping_method_id: $scope.q?.shipping_method_id,
-      per_page: $scope.per_page,
-      page: page
-    }
-    KeyValueMapStore.setStoredValues($scope)
-    RequestMonitor.load(Orders.index(params).$promise)
-
-  $scope.appendStringIfNotEmpty = (baseString, stringToAppend) ->
-    return baseString unless baseString
-    return baseString if baseString.endsWith(stringToAppend)
-
-    baseString + stringToAppend
-
-  $scope.resetSelected = ->
-    $scope.selected_orders.length = 0
-    $scope.selected = false
-    $scope.select_all = false
-    $scope.checkboxes = {}
-
-  $scope.toggleSelection = (id) ->
-    index = $scope.selected_orders.indexOf(id)
-
-    if index == -1
-      $scope.selected_orders.push(id)
-    else
-      $scope.selected_orders.splice(index, 1)
-
-  $scope.toggleAll = ->
-    $scope.selected_orders.length = 0
-    $scope.orders.forEach (order) ->
-      $scope.checkboxes[order.id] = $scope.select_all
-      $scope.selected_orders.push order.id if $scope.select_all
-
-  $scope.$watch 'sortOptions', (sort) ->
-    return unless sort && sort.predicate != ""
-
-    $scope.sorting = sort.getSortingExpr()
-    $scope.fetchResults()
-  , true
-
-  $scope.capturePayment = (order) ->
-    $scope.rowAction('capture', order)
-
-  $scope.shipOrder = (order) ->
-    $scope.rowAction('ship', order)
-
-  $scope.rowAction = (action, order) ->
-    $scope.rowStatus[order.id] = "loading"
-
-    Orders[action](order).$promise.then (data) ->
-      $scope.rowStatus[order.id] = "success"
-      $timeout(->
-        $scope.rowStatus[order.id] = null
-      , 1500)
-    , (error) ->
-      $scope.rowStatus[order.id] = "error"
-
-  $scope.changePage = (newPage) ->
-    $scope.page = newPage
-    $scope.fetchResults(newPage)
diff --git a/app/views/spree/admin/orders/edit.html.haml b/app/views/spree/admin/orders/edit.html.haml
index 1049a0849f..b8556d861a 100644
--- a/app/views/spree/admin/orders/edit.html.haml
+++ b/app/views/spree/admin/orders/edit.html.haml
@@ -8,8 +8,8 @@
     %li= event_links
   = render partial: 'spree/admin/shared/order_links'
   - if can?(:admin, Spree::Order)
-    %li{"ng-controller" => "ordersCtrl"}
-      %a.button.icon-arrow-left{icon:  'icon-arrow-left', ng: { href: admin_orders_path }}
+    %li
+      %a.button.icon-arrow-left{icon: 'icon-arrow-left', href: admin_orders_path }
         = t(:back_to_orders_list)
 
 = render partial: "spree/admin/shared/order_page_title"
diff --git a/spec/javascripts/unit/admin/orders/controllers/orders_controller_spec.js.coffee b/spec/javascripts/unit/admin/orders/controllers/orders_controller_spec.js.coffee
deleted file mode 100644
index 0ccbbe3b9a..0000000000
--- a/spec/javascripts/unit/admin/orders/controllers/orders_controller_spec.js.coffee
+++ /dev/null
@@ -1,76 +0,0 @@
-describe "ordersCtrl", ->
-  ctrl = null
-  Orders = null
-  $scope = null
-  orders = [
-    { id: 8, order_cycle: { id: 4 }, distributor: { id: 5 }, number: "R123456" }
-    { id: 9, order_cycle: { id: 5 }, distributor: { id: 7 }, number: "R213776" }
-    { id: 10, order_cycle: { id: 6 }, distributor: { id: 8 }, number: "R213777" }
-  ]
-  form = {
-    q: {
-      created_at_lt: ''
-      created_at_gt: ''
-      completed_at_not_null: true
-    }
-  }
-
-  beforeEach ->
-    module 'admin.orders'
-    inject ($controller, $rootScope, RequestMonitor, SortOptions) ->
-      $scope = $rootScope.$new()
-      Orders =
-        index: jasmine.createSpy('index').and.returnValue(orders)
-        all: orders
-      ctrl = $controller 'ordersCtrl', { $scope: $scope, RequestMonitor: RequestMonitor, SortOptions: SortOptions, Orders: Orders }
-      $scope.q = form.q
-
-  describe "initialising the controller", ->
-    it "fetches orders", ->
-      $scope.initialise()
-      expect(Orders.index).toHaveBeenCalled()
-      expect($scope.orders).toEqual orders
-
-    it "fetches them sorted by completed_at by default", ->
-      $scope.initialise()
-      expect(Orders.index).toHaveBeenCalledWith(jasmine.objectContaining({
-        'q[s]': 'completed_at desc'
-      }))
-
-  describe "using pagination", ->
-    it "changes the page", ->
-      $scope.changePage(2)
-      expect($scope.page).toEqual 2
-      expect(Orders.index).toHaveBeenCalled()
-
-  describe "sorting orders", ->
-    it "sorts orders", ->
-      spyOn $scope, "fetchResults"
-
-      $scope.sortOptions.toggle('number')
-      $scope.$apply()
-
-      expect($scope.sorting).toEqual 'number asc'
-      expect($scope.fetchResults).toHaveBeenCalled()
-
-  describe "filtering orders", ->
-    it "filters orders by all selected order cycles", ->
-      $scope['q']['order_cycle_id_in'] = ['4', '5']
-
-      $scope.fetchResults()
-
-      # Fetched with correct square brackets in field name for array value
-      expect(Orders.index).toHaveBeenCalledWith(jasmine.objectContaining({
-        'q[order_cycle_id_in][]': ['4', '5']
-      }))
-
-    it "filters orders on inclusive dates", ->
-      $scope['q']['completed_at_gteq'] = '2020-06-08'
-      $scope['q']['completed_at_lteq'] = '2020-06-09'
-
-      $scope.fetchResults()
-
-      expect(Orders.index).toHaveBeenCalledWith(jasmine.objectContaining({
-        'q[completed_at_gteq]': '2020-06-08 00:00:00'
-        'q[completed_at_lteq]': '2020-06-09 23:59:59'
-      }))

From 310577c49d8a5ec9914c96807f898e233300792a Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 10 May 2023 12:49:11 +0100
Subject: [PATCH 20/38] Close dropdown after selection with multiselect

This conforms with the previous select2 multiselect behaviour
---
 app/webpacker/controllers/tom_select_controller.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/webpacker/controllers/tom_select_controller.js b/app/webpacker/controllers/tom_select_controller.js
index ebf163d129..9cf4401fe6 100644
--- a/app/webpacker/controllers/tom_select_controller.js
+++ b/app/webpacker/controllers/tom_select_controller.js
@@ -8,6 +8,7 @@ export default class extends Controller {
     maxOptions: null,
     plugins: ["dropdown_input"],
     allowEmptyOption: true,
+    closeAfterSelect: true,
     onItemAdd: function () {
       this.setTextboxValue("");
     },
@@ -34,7 +35,6 @@ export default class extends Controller {
 
   #placeholder() {
     const optionsArray = [...this.element.options];
-    return optionsArray.find((option) => [null, ""].includes(option.value))
-      ?.text;
+    return optionsArray.find((option) => [null, ""].includes(option.value))?.text;
   }
 }

From 770880c06257f28c7e04b79f11101f875c8e7f16 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 10 May 2023 13:07:28 +0100
Subject: [PATCH 21/38] Update specs

---
 spec/support/request/web_helper.rb            |  10 ++
 .../admin/bulk_order_cancellation_spec.rb     |   5 +-
 spec/system/admin/orders_spec.rb              | 102 +++++++++---------
 3 files changed, 64 insertions(+), 53 deletions(-)

diff --git a/spec/support/request/web_helper.rb b/spec/support/request/web_helper.rb
index 6a6e53b517..92d7333de2 100644
--- a/spec/support/request/web_helper.rb
+++ b/spec/support/request/web_helper.rb
@@ -84,6 +84,16 @@ module WebHelper
     find(:css, ".select2-result-label", text: options[:select_text] || value).click
   end
 
+  def tomselect_open(field_name)
+    page.find("##{field_name}-ts-control").click
+  end
+
+  def tomselect_multiselect(value, options)
+    tomselect_wrapper = page.find("[name='#{options[:from]}']").sibling(".ts-wrapper")
+    tomselect_wrapper.find(".ts-control").click
+    tomselect_wrapper.find(:css, '.ts-dropdown.multi .ts-dropdown-content .option', text: value).click
+  end
+
   def tomselect_search_and_select(value, options)
     tomselect_wrapper = page.find("[name='#{options[:from]}']").sibling(".ts-wrapper")
     tomselect_wrapper.find(".ts-control").click
diff --git a/spec/system/admin/bulk_order_cancellation_spec.rb b/spec/system/admin/bulk_order_cancellation_spec.rb
index 8d519e2a76..c07ccfe9e1 100644
--- a/spec/system/admin/bulk_order_cancellation_spec.rb
+++ b/spec/system/admin/bulk_order_cancellation_spec.rb
@@ -29,9 +29,10 @@ describe '
       # Verify that the orders have a STATE of COMPLETE
       expect(page).to have_selector('span', text: 'COMPLETE', count: 2)
 
-      page.check('selectAll')
+      page.find('#selectAll').trigger('click')
       page.find("span.icon-reorder", text: "ACTIONS").click
-      within ".ofn-drop-down-with-prepend .menu" do
+      within ".ofn-drop-down .menu" do
+        expect(page).to have_selector("span", text: "Cancel Orders")
         page.find("span", text: "Cancel Orders").click
       end
 
diff --git a/spec/system/admin/orders_spec.rb b/spec/system/admin/orders_spec.rb
index 50231f03aa..957b903f03 100644
--- a/spec/system/admin/orders_spec.rb
+++ b/spec/system/admin/orders_spec.rb
@@ -99,17 +99,17 @@ distributors: [distributor4, distributor5]) }
       end
 
       it "order cycles appear in descending order by close date on orders page" do
-        open_select2('#s2id_q_order_cycle_id_in')
+        tomselect_open('q_order_cycle_id_in').click
 
         expect(find('#q_order_cycle_id_in',
                     visible: :all)[:innerHTML]).to have_content(/.*Four.*Three.*Two.*Five/m)
       end
 
       it "filter by multiple order cycles" do
-        select2_select 'Two', from: 'q_order_cycle_id_in'
-        select2_select 'Three', from: 'q_order_cycle_id_in'
+        tomselect_multiselect 'Two', from: 'q[order_cycle_id_in][]'
+        tomselect_multiselect 'Three', from: 'q[order_cycle_id_in][]'
 
-        page.find('.filter-actions .button.icon-search').click
+        page.find('.filter-actions .button[type=submit]').click
 
         # Order 2 and 3 should show, but not 4
         expect(page).to have_content order2.number
@@ -118,10 +118,10 @@ distributors: [distributor4, distributor5]) }
       end
 
       it "filter by distributors" do
-        select2_select distributor2.name.to_s, from: 'q_distributor_id_in'
-        select2_select distributor4.name.to_s, from: 'q_distributor_id_in'
+        tomselect_multiselect distributor2.name.to_s, from: 'q[distributor_id_in][]'
+        tomselect_multiselect distributor4.name.to_s, from: 'q[distributor_id_in][]'
 
-        page.find('.filter-actions .button.icon-search').click
+        page.find('.filter-actions .button[type=submit]').click
 
         # Order 2 and 4 should show, but not 3
         expect(page).to have_content order2.number
@@ -134,7 +134,7 @@ distributors: [distributor4, distributor5]) }
         select_dates_from_daterangepicker(order3.completed_at.yesterday,
                                           order4.completed_at.tomorrow)
 
-        page.find('.filter-actions .button.icon-search').click
+        page.find('.filter-actions .button[type=submit]').click
 
         # Order 3 and 4 should show, but not 2
         expect(page).to_not have_content order2.number
@@ -145,7 +145,7 @@ distributors: [distributor4, distributor5]) }
       it "filter by email" do
         fill_in "Email", with: customer3.email
 
-        page.find('.filter-actions .button.icon-search').click
+        page.find('.filter-actions .button[type=submit]').click
 
         # Order 3 should show, but not 2 and 4
         expect(page).to_not have_content order2.number
@@ -157,28 +157,28 @@ distributors: [distributor4, distributor5]) }
         # NOTE: this field refers to the name given in billing addresses and not to customer name
         # filtering by first name
         fill_in "First name begins with", with: billing_address2.firstname
-        page.find('.filter-actions .button.icon-search').click
+        page.find('.filter-actions .button[type=submit]').click
         # Order 2 should show, but not 3 and 4
         expect(page).to have_content order2.number
         expect(page).to_not have_content order3.number
         expect(page).to_not have_content order4.number
 
-        find("a#clear_filters_button").click
+        find("#clear_filters_button").click
         # filtering by last name
 
         fill_in "Last name begins with", with: billing_address4.lastname
-        page.find('.filter-actions .button.icon-search').click
+        page.find('.filter-actions .button[type=submit]').click
         # Order 4 should show, but not 2 and 3
         expect(page).to_not have_content order2.number
         expect(page).to_not have_content order3.number
         expect(page).to have_content order4.number
 
-        find("a#clear_filters_button").click
+        find("#clear_filters_button").click
         # filtering by first and last name together
 
         fill_in "First name begins with", with: billing_address3.firstname
         fill_in "Last name begins with", with: billing_address3.lastname
-        page.find('.filter-actions .button.icon-search').click
+        page.find('.filter-actions .button[type=submit]').click
         # Order 3 should show, but not 2 and 4
         expect(page).not_to have_content order2.number
         expect(page).to have_content order3.number
@@ -189,17 +189,17 @@ distributors: [distributor4, distributor5]) }
         order2.select_shipping_method(shipping_method.id)
         order4.select_shipping_method(shipping_method2.id)
 
-        select2_select "Pick-up at the farm", from: 'q_shipping_method_id'
-        page.find('.filter-actions .button.icon-search').click
+        tomselect_search_and_select "Pick-up at the farm", from: 'shipping_method_id'
+        page.find('.filter-actions .button[type=submit]').click
         # Order 2 should show, but not 3 and 5
         expect(page).to have_content order2.number
         expect(page).to_not have_content order3.number
         expect(page).to_not have_content order4.number
 
-        find("a#clear_filters_button").click
+        find("#clear_filters_button").click
 
-        select2_select "Signed, sealed, delivered", from: 'q_shipping_method_id'
-        page.find('.filter-actions .button.icon-search').click
+        tomselect_search_and_select "Signed, sealed, delivered", from: 'shipping_method_id'
+        page.find('.filter-actions .button[type=submit]').click
         # Order 4 should show, but not 2 and 3
         expect(page).to_not have_content order2.number
         expect(page).to_not have_content order3.number
@@ -209,7 +209,7 @@ distributors: [distributor4, distributor5]) }
       it "filter by invoice number" do
         fill_in "Invoice number:", with: order2.number
 
-        page.find('.filter-actions .button.icon-search').click
+        page.find('.filter-actions .button[type=submit]').click
 
         # Order 2 should show, but not 3 and 4
         expect(page).to have_content order2.number
@@ -221,7 +221,7 @@ distributors: [distributor4, distributor5]) }
         order.update(state: "payment")
 
         uncheck 'Only show complete orders'
-        page.find('.filter-actions .button.icon-search').click
+        page.find('.filter-actions .button[type=submit]').click
 
         expect(page).to have_content order.number
         expect(page).to have_content order2.number
@@ -229,9 +229,9 @@ distributors: [distributor4, distributor5]) }
         expect(page).to have_content order4.number
         expect(page).to have_content order5.number
 
-        select2_select "payment", from: 'q_state_eq'
+        tomselect_search_and_select "payment", from: 'q[state_eq]'
 
-        page.find('.filter-actions .button.icon-search').click
+        page.find('.filter-actions .button[type=submit]').click
 
         # Order 2 should show, but not 3 and 4
         expect(page).to have_content order.number
@@ -295,7 +295,7 @@ distributors: [distributor4, distributor5]) }
           login_as_admin
           visit spree.admin_orders_path
           uncheck 'Only show complete orders'
-          page.find('.filter-actions .button.icon-search').click
+          page.find('.filter-actions .button[type=submit]').click
         end
 
         it "orders by order state" do
@@ -432,7 +432,7 @@ distributors: [distributor4, distributor5]) }
         page.find("span.icon-reorder", text: "ACTIONS").click
         expect(page).to have_content "Print Invoices"
         # unselect all orders
-        page.find("#listing_orders thead th:first-child input[type=checkbox]").click
+        page.find("#listing_orders thead th:first-child input[type=checkbox]").trigger("click")
         expect(page.find(
           "#listing_orders tbody tr td:first-child input[type=checkbox]")
         ).to_not be_checked
@@ -472,7 +472,7 @@ distributors: [distributor4, distributor5]) }
               end
 
               page.find("span.icon-reorder", text: "ACTIONS").click
-              within ".ofn-drop-down-with-prepend .menu" do
+              within ".ofn-drop-down .menu" do
                 page.find("span", text: "Send Invoices").click
               end
 
@@ -496,7 +496,7 @@ distributors: [distributor4, distributor5]) }
           page.find("#listing_orders tbody tr:nth-child(2) input[name='bulk_ids[]']").click
 
           page.find("span.icon-reorder", text: "ACTIONS").click
-          within ".ofn-drop-down-with-prepend .menu" do
+          within ".ofn-drop-down .menu" do
             page.find("span", text: "Resend Confirmation").click
           end
 
@@ -516,7 +516,7 @@ distributors: [distributor4, distributor5]) }
           page.find("#listing_orders tbody tr:nth-child(2) input[name='bulk_ids[]']").click
 
           page.find("span.icon-reorder", text: "ACTIONS").click
-          within ".ofn-drop-down-with-prepend .menu" do
+          within ".ofn-drop-down .menu" do
             page.find("span", text: "Print Invoices").click
           end
 
@@ -531,7 +531,7 @@ distributors: [distributor4, distributor5]) }
           page.find("#listing_orders tbody tr:nth-child(2) input[name='bulk_ids[]']").click
 
           page.find("span.icon-reorder", text: "ACTIONS").click
-          within ".ofn-drop-down-with-prepend .menu" do
+          within ".ofn-drop-down .menu" do
             page.find("span", text: "Cancel Orders").click
           end
 
@@ -545,7 +545,7 @@ distributors: [distributor4, distributor5]) }
           end
 
           page.find("span.icon-reorder", text: "ACTIONS").click
-          within ".ofn-drop-down-with-prepend .menu" do
+          within ".ofn-drop-down .menu" do
             page.find("span", text: "Cancel Orders").click
           end
 
@@ -584,7 +584,7 @@ distributors: [distributor4, distributor5]) }
           order.update_attribute(:order_cycle, order_cycle)
 
           page.find("span.icon-reorder", text: "ACTIONS").click
-          within ".ofn-drop-down-with-prepend .menu" do
+          within ".ofn-drop-down .menu" do
             page.find("span", text: "Resend Confirmation").click
           end
 
@@ -608,11 +608,11 @@ distributors: [distributor4, distributor5]) }
       it "displays pagination options" do
         # displaying 4 orders (one order per table row)
         within('tbody') do
-          expect(page).to have_css('tr.ng-scope', count: 4)
+          expect(page).to have_css('tr', count: 4)
         end
         # pagination options also refer 4 order
         expect(page).to have_content "4 Results found. Viewing 1 to 4."
-        page.find(".per-page-select").click # toggling the pagination dropdown
+        page.find(".per-page-dropdown .ts-control .item").click # toggling the pagination dropdown
         expect(page).to have_content "15 per page"
         expect(page).to have_content "50 per page"
         expect(page).to have_content "100 per page"
@@ -631,7 +631,7 @@ distributors: [distributor4, distributor5]) }
         expect(page).to have_current_path spree.admin_orders_path
 
         # click the 'capture' link for the order
-        page.find("[data-powertip=Capture]").click
+        page.find("button.icon-capture").click
 
         expect(page).to have_css "i.success"
         expect(page).to have_css "button.icon-road"
@@ -648,7 +648,7 @@ distributors: [distributor4, distributor5]) }
         login_as_admin
         visit spree.admin_orders_path
 
-        page.find("[data-powertip=Ship]").click
+        page.find("button.icon-road").click
 
         expect(page).to have_css "i.success"
         expect(order.reload.shipments.any?(&:shipped?)).to be true
@@ -666,7 +666,7 @@ distributors: [distributor4, distributor5]) }
       login_as_admin
       visit spree.admin_orders_path
       uncheck 'Only show complete orders'
-      page.find('a.icon-search').click
+      page.find('button[type=submit]').click
 
       find(".icon-edit").click
 
@@ -711,7 +711,7 @@ distributors: [distributor4, distributor5]) }
       expect(page).to have_no_content empty_order.number
 
       uncheck 'Only show complete orders'
-      page.find('a.icon-search').click
+      page.find('button[type=submit]').click
 
       expect(page).to have_content complete_order.number
       expect(page).to have_content incomplete_order.number
@@ -741,17 +741,17 @@ distributors: [distributor4, distributor5]) }
       # Specify each filters
       uncheck 'Only show complete orders'
       fill_in "Invoice number", with: "R123456"
-      select2_select order_cycle.name, from: 'q_order_cycle_id_in'
-      select2_select distributor.name, from: 'q_distributor_id_in'
-      select2_select shipping_method.name, from: 'q_shipping_method_id'
-      select2_select "complete", from: 'q_state_eq'
+      tomselect_multiselect order_cycle.name, from: 'q[order_cycle_id_in][]'
+      tomselect_multiselect distributor.name, from: 'q[distributor_id_in][]'
+      tomselect_search_and_select shipping_method.name, from: 'shipping_method_id'
+      tomselect_search_and_select "complete", from: 'q[state_eq]'
       fill_in "Email", with: user.email
       fill_in "First name begins with", with: "J"
       fill_in "Last name begins with", with: "D"
       find("input.datepicker").click
       select_dates_from_daterangepicker(Time.zone.at(1.week.ago), Time.zone.now.tomorrow)
 
-      page.find('a.icon-search').click
+      page.find('.button[type=submit]').click
     end
 
     it "when reloading the page" do
@@ -760,10 +760,10 @@ distributors: [distributor4, distributor5]) }
       # Check every filters to be equal
       expect(find_field("Only show complete orders")).not_to be_checked
       expect(find_field("Invoice number").value).to eq "R123456"
-      expect(find("#s2id_q_shipping_method_id").text).to eq shipping_method.name
-      expect(find("#s2id_q_state_eq").text).to eq "complete"
-      expect(find("#s2id_q_distributor_id_in").text).to eq distributor.name
-      expect(find("#s2id_q_order_cycle_id_in").text).to eq order_cycle.name
+      expect(find("#shipping_method_id-ts-control .item").text).to eq shipping_method.name
+      expect(find("#q_state_eq-ts-control .item").text).to eq "complete"
+      expect(find("#q_distributor_id_in").value).to eq [distributor.id.to_s]
+      expect(find("#q_order_cycle_id_in").value).to eq [order_cycle.id.to_s]
       expect(find_field("Email").value).to eq user.email
       expect(find_field("First name begins with").value).to eq "J"
       expect(find_field("Last name begins with").value).to eq "D"
@@ -773,13 +773,13 @@ distributors: [distributor4, distributor5]) }
     end
 
     it "and clear filters" do
-      find("a#clear_filters_button").click
+      find("#clear_filters_button").click
       expect(find_field("Only show complete orders")).to be_checked
       expect(find_field("Invoice number").value).to eq ""
-      expect(find("#s2id_q_shipping_method_id").text).to be_empty
-      expect(find("#s2id_q_state_eq").text).to be_empty
-      expect(find("#s2id_q_distributor_id_in").text).to be_empty
-      expect(find("#s2id_q_order_cycle_id_in").text).to be_empty
+      expect(find("#shipping_method_id").value).to be_empty
+      expect(find("#q_state_eq").value).to be_empty
+      expect(find("#q_distributor_id_in").value).to be_empty
+      expect(find("#q_order_cycle_id_in").value).to be_empty
       expect(find_field("Email").value).to be_empty
       expect(find_field("First name begins with").value).to be_empty
       expect(find_field("Last name begins with").value).to be_empty

From d64a9afece84105e96e591bb935726ff489bff6c Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 10 May 2023 17:21:48 +0100
Subject: [PATCH 22/38] Replace angular ofn-with-tip directive on capture/ship
 buttons

---
 app/views/admin/shared/_tooltip.html.haml     |  3 +-
 .../spree/admin/orders/_table_row.html.haml   |  9 +++-
 .../controllers/tooltip_controller.js         | 43 ++++++++++++++++---
 .../css/admin/components/tooltip.scss         |  1 -
 4 files changed, 45 insertions(+), 11 deletions(-)

diff --git a/app/views/admin/shared/_tooltip.html.haml b/app/views/admin/shared/_tooltip.html.haml
index 3d0f140518..0f193e60b9 100644
--- a/app/views/admin/shared/_tooltip.html.haml
+++ b/app/views/admin/shared/_tooltip.html.haml
@@ -1,5 +1,6 @@
 %div{"data-controller": "tooltip"}
-  %a{"data-tooltip-target": "element", "data-action": "mouseenter->tooltip#showTooltip mouseleave->tooltip#hideTooltip"}= t('admin.whats_this')
+  %a{"data-tooltip-target": "element"}
+    = t('admin.whats_this')
   .tooltip-container
     .tooltip{"data-tooltip-target": "tooltip"}
       = sanitize tooltip_text
diff --git a/app/views/spree/admin/orders/_table_row.html.haml b/app/views/spree/admin/orders/_table_row.html.haml
index c4809f08f5..c7cdfbc78a 100644
--- a/app/views/spree/admin/orders/_table_row.html.haml
+++ b/app/views/spree/admin/orders/_table_row.html.haml
@@ -43,6 +43,11 @@
           %i.success.icon-ok-sign{"data-controller": "ephemeral"}
       %a.icon_link.with-tip.icon-edit.no-text{href: edit_admin_order_path(order), 'ofn-with-tip' => t('spree.admin.orders.index.edit')}
       - if order.ready_to_ship?
-        %button.icon-road.icon_link.with-tip.no-text{"data-reflex": "click->Admin::OrdersReflex#ship", "data-id": order.id.to_s, 'ofn-with-tip' => t('spree.admin.orders.index.ship')}
+        %div{ "data-controller": "tooltip", "data-tooltip-tip-value": t('spree.admin.orders.index.ship') }
+          %button.icon-road.icon_link.with-tip.no-text{"data-reflex": "click->Admin::OrdersReflex#ship", "data-id": order.id.to_s,
+          "data-tooltip-target": "element" }
+
       - if order.payment_required? && order.pending_payments.reject(&:requires_authorization?).any?
-        %button.icon-capture.icon_link.no-text{"data-reflex": "click->Admin::OrdersReflex#capture", "data-id": order.id.to_s, 'ofn-with-tip' => t('spree.admin.orders.index.capture')}
+        %div{ "data-controller": "tooltip", "data-tooltip-tip-value": t('spree.admin.orders.index.capture') }
+          %button.icon-capture.icon_link.no-text{"data-reflex": "click->Admin::OrdersReflex#capture", "data-id": order.id.to_s,
+          "data-tooltip-target": "element" }
diff --git a/app/webpacker/controllers/tooltip_controller.js b/app/webpacker/controllers/tooltip_controller.js
index 5a71ceb441..b75e7eab6c 100644
--- a/app/webpacker/controllers/tooltip_controller.js
+++ b/app/webpacker/controllers/tooltip_controller.js
@@ -4,12 +4,22 @@ import { computePosition, offset, arrow } from "@floating-ui/dom";
 export default class extends Controller {
   static targets = ["element", "tooltip", "arrow"];
   static values = {
-    placement: {
-      type: String,
-      default: "top",
-    },
+    tip: String,
+    placement: { type: String, default: "top" },
   };
 
+  connect() {
+    if (this.hasTipValue) { this.insertToolTipMarkup() }
+
+    this.elementTarget.addEventListener("mouseenter", this.showTooltip);
+    this.elementTarget.addEventListener("mouseleave", this.hideTooltip);
+  }
+
+  disconnect() {
+    this.elementTarget.removeEventListener("mouseenter", this.showTooltip);
+    this.elementTarget.removeEventListener("mouseleave", this.hideTooltip);
+  }
+
   update() {
     computePosition(this.elementTarget, this.tooltipTarget, {
       placement: this.placementValue,
@@ -38,12 +48,31 @@ export default class extends Controller {
     });
   }
 
-  showTooltip() {
+  showTooltip = () => {
     this.tooltipTarget.style.display = "block";
     this.update();
-  }
+  };
 
-  hideTooltip() {
+  hideTooltip = () => {
     this.tooltipTarget.style.display = "";
+  };
+
+  insertToolTipMarkup() {
+    let container = document.createElement("div");
+    let tooltip = document.createElement("div");
+    let arrow = document.createElement("div");
+    let text = document.createTextNode(this.tipValue);
+
+    container.classList.add("tooltip-container");
+    tooltip.classList.add("tooltip");
+    tooltip.setAttribute("data-tooltip-target", "tooltip");
+    arrow.classList.add("arrow");
+    arrow.setAttribute("data-tooltip-target", "arrow");
+
+    container.appendChild(tooltip);
+    tooltip.appendChild(text);
+    tooltip.appendChild(arrow);
+
+    this.elementTarget.appendChild(container);
   }
 }
diff --git a/app/webpacker/css/admin/components/tooltip.scss b/app/webpacker/css/admin/components/tooltip.scss
index 77612b180f..c8a68cf11f 100644
--- a/app/webpacker/css/admin/components/tooltip.scss
+++ b/app/webpacker/css/admin/components/tooltip.scss
@@ -28,5 +28,4 @@
 
 .tooltip-container {
   position: relative;
-  width: 240px;
 }

From 2ba2a826db695e8f433e4c791ba3a2d98a471ffb Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Thu, 11 May 2023 12:47:01 +0100
Subject: [PATCH 23/38] Clean up event handlers on disconnect in Flatpickr
 controller

---
 .../controllers/flatpickr_controller.js       | 41 +++++++++++--------
 1 file changed, 25 insertions(+), 16 deletions(-)

diff --git a/app/webpacker/controllers/flatpickr_controller.js b/app/webpacker/controllers/flatpickr_controller.js
index c9294b0f1f..e85017e189 100644
--- a/app/webpacker/controllers/flatpickr_controller.js
+++ b/app/webpacker/controllers/flatpickr_controller.js
@@ -39,8 +39,8 @@ export default class extends Flatpickr {
   };
 
   initialize() {
-    const datetimepicker = this.enableTimeValue == true;
-    const mode = this.modeValue == "range" ? "range" : "single";
+    const datetimepicker = this.enableTimeValue === true;
+    const mode = this.modeValue === "range" ? "range" : "single";
     // sets your language (you can also set some global setting for all time pickers)
     this.config = {
       altInput: true,
@@ -54,23 +54,34 @@ export default class extends Flatpickr {
       plugins: this.plugins(mode, datetimepicker),
       mode,
     };
-    window.addEventListener("flatpickr:change", this.onChangeEvent.bind(this));
-    window.addEventListener("flatpickr:clear", this.clear.bind(this));
   }
 
-  clear(e) {
-    this.fp.setDate(null);
+  connect() {
+    super.connect();
+    window.addEventListener("flatpickr:change", this.onChangeEvent);
+    window.addEventListener("flatpickr:clear", this.clear);
   }
 
+  disconnect() {
+    super.disconnect();
+    window.removeEventListener("flatpickr:change", this.onChangeEvent);
+    window.removeEventListener("flatpickr:clear", this.clear);
+  }
+
+  clear = (e) => {
+    this.fp.setDate(null);
+  };
+
   open() {
     this.fp.element.dispatchEvent(new Event("focus"));
     if (!this.fp.selectedDates.length) {
       this.setDefaultDateValue();
     }
   }
-  onChangeEvent(e) {
+
+  onChangeEvent = (e) => {
     if (
-      this.modeValue == "range" &&
+      this.modeValue === "range" &&
       this.hasStartTarget &&
       this.hasEndTarget &&
       e.detail.startDate &&
@@ -84,10 +95,10 @@ export default class extends Flatpickr {
       // single date mode
       this.fp.setDate(e.detail.date);
     }
-  }
+  };
 
   change(selectedDates, dateStr, instance) {
-    if (this.hasStartTarget && this.hasEndTarget && this.modeValue == "range") {
+    if (this.hasStartTarget && this.hasEndTarget && this.modeValue === "range") {
       this.startTarget.value = selectedDates[0]
         ? this.fp.formatDate(selectedDates[0], this.config.dateFormat)
         : "";
@@ -112,11 +123,9 @@ export default class extends Flatpickr {
 
   plugins = (mode, datetimepicker) => {
     const buttons = [{ label: Spree.translations.close }];
-    if (mode == "single") {
+    if (mode === "single") {
       buttons.unshift({
-        label: datetimepicker
-          ? Spree.translations.now
-          : Spree.translations.today,
+        label: datetimepicker ? Spree.translations.now : Spree.translations.today,
       });
     }
     return [
@@ -132,8 +141,8 @@ export default class extends Flatpickr {
     // Memorize index used for the 'Close' and 'Today|Now' buttons
     // it has index of 1 in case of single mode (ie. can set Today or Now date)
     // it has index of 0 in case of range mode (no Today or Now button)
-    const closeButtonIndex = this.modeValue == "range" ? 0 : 1;
-    const todayButtonIndex = this.modeValue == "range" ? null : 0;
+    const closeButtonIndex = this.modeValue === "range" ? 0 : 1;
+    const todayButtonIndex = this.modeValue === "range" ? null : 0;
     switch (index) {
       case todayButtonIndex:
         fp.setDate(new Date(), true);

From 7d33e0f74def632cba508e1d3eaf942b030bf82d Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Thu, 11 May 2023 12:50:27 +0100
Subject: [PATCH 24/38] Allow programmatically refreshing flatpickr element via
 "flatpickr:change" event after changing the select's value externally

---
 .../controllers/flatpickr_controller.js          | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/app/webpacker/controllers/flatpickr_controller.js b/app/webpacker/controllers/flatpickr_controller.js
index e85017e189..66a5d53a5d 100644
--- a/app/webpacker/controllers/flatpickr_controller.js
+++ b/app/webpacker/controllers/flatpickr_controller.js
@@ -80,17 +80,13 @@ export default class extends Flatpickr {
   }
 
   onChangeEvent = (e) => {
-    if (
-      this.modeValue === "range" &&
-      this.hasStartTarget &&
-      this.hasEndTarget &&
-      e.detail.startDate &&
-      e.detail.endDate
-    ) {
+    if (this.modeValue === "range" && this.hasStartTarget && this.hasEndTarget) {
       // date range mode
-      this.startTarget.value = e.detail.startDate;
-      this.endTarget.value = e.detail.endDate;
-      this.fp.setDate([e.detail.startDate, e.detail.endDate]);
+      if (e.detail) {
+        this.startTarget.value = e.detail.startDate;
+        this.endTarget.value = e.detail.endDate;
+      }
+      this.fp.setDate([this.startTarget.value, this.endTarget.value]);
     } else if (e.detail.date) {
       // single date mode
       this.fp.setDate(e.detail.date);

From 4ddde65a04b5933161caa481cfec610c376c5d85 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Thu, 11 May 2023 11:23:15 +0100
Subject: [PATCH 25/38] Reimplement saving and restoring submitted search
 filters between page loads

---
 .../spree/admin/orders_controller.rb          | 11 +++++++++-
 .../spree/admin/orders/_filters.html.haml     |  2 +-
 .../controllers/search_controller.js          | 21 +++++++++++++++++++
 3 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/app/controllers/spree/admin/orders_controller.rb b/app/controllers/spree/admin/orders_controller.rb
index 43cbdf2d9c..cd985eff12 100644
--- a/app/controllers/spree/admin/orders_controller.rb
+++ b/app/controllers/spree/admin/orders_controller.rb
@@ -12,8 +12,8 @@ module Spree
       before_action :load_order, only: [:edit, :update, :fire, :resend,
                                         :invoice, :print, :distribution]
       before_action :load_distribution_choices, only: [:new, :edit, :update, :distribution]
-
       before_action :require_distributor_abn, only: :invoice
+      before_action :restore_saved_query!, only: :index
 
       respond_to :html, :json
 
@@ -119,6 +119,8 @@ module Spree
       private
 
       def update_search_results
+        session[:admin_orders_search] = search_params
+
         render cable_ready: cable_car.inner_html(
           "#orders-index",
           partial("spree/admin/orders/table", locals: { pagy: @pagy, orders: @orders })
@@ -137,6 +139,13 @@ module Spree
         { q: { completed_at_not_null: 1, s: "completed_at desc" } }
       end
 
+      def restore_saved_query!
+        return unless request.format.html?
+
+        @_params = ActionController::Parameters.new(session[:admin_orders_search] || {})
+        @stored_query = search_params.to_query
+      end
+
       def on_update
         @order.recreate_all_fees!
 
diff --git a/app/views/spree/admin/orders/_filters.html.haml b/app/views/spree/admin/orders/_filters.html.haml
index 9f924fffa1..89109ae14d 100644
--- a/app/views/spree/admin/orders/_filters.html.haml
+++ b/app/views/spree/admin/orders/_filters.html.haml
@@ -1,4 +1,4 @@
-%div.admin-orders-index-search{ "data-controller": "search" }
+%div.admin-orders-index-search{ "data-controller": "search", "data-search-restore-value": @stored_query }
   = form_with url: spree.admin_orders_url, id: "orders_form", method: :get, data: { remote: true, "search-target": "form" } do
     = hidden_field_tag :page, 1, class: "page"
     = hidden_field_tag :per_page, 15, class: "per-page"
diff --git a/app/webpacker/controllers/search_controller.js b/app/webpacker/controllers/search_controller.js
index fdcc13439b..c79774b52a 100644
--- a/app/webpacker/controllers/search_controller.js
+++ b/app/webpacker/controllers/search_controller.js
@@ -2,6 +2,7 @@ import { Controller } from "stimulus";
 
 export default class extends Controller {
   static targets = ["form"];
+  static values = { restore: String }; // Query string, eg: "?color=red&size=small"
 
   connect() {
     this.#setup();
@@ -49,6 +50,7 @@ export default class extends Controller {
     if (this.hasFormTarget) {
       this.form = this.formTarget;
       this.form.controller = this;
+      if (this.restoreValue) this.#restoreFormState(this.form, this.restoreValue);
     } else {
       this.form = document.querySelector("form[data-search-target=form]");
     }
@@ -65,4 +67,23 @@ export default class extends Controller {
       select.tomselect?.clear();
     });
   }
+
+  #restoreFormState(form, queryString) {
+    const params = new URLSearchParams(queryString);
+
+    // Apply non-checkbox values
+    for (const [key, value] of params.entries()) {
+      const input = form.elements[key];
+      if (input && input.type !== "checkbox") input.value = value;
+    }
+
+    // Deal with checkbox values
+    form.querySelectorAll("[type=checkbox]").forEach((checkbox) => {
+      checkbox.checked = !!params.get(checkbox.name);
+    });
+
+    setTimeout(() => {
+      window.dispatchEvent(new CustomEvent("flatpickr:change"));
+    });
+  }
 }

From d50ac4bf45c44d6202939f0679ae4540c6951dc1 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 12 May 2023 12:23:34 +0100
Subject: [PATCH 26/38] Reinstate dropdown-with-prepend

---
 .../admin/orders/_bulk_actions.html.haml      | 39 +++++++++++--------
 .../controllers/checked_controller.js         | 28 ++++++++++---
 .../checked_feedback_controller.js            | 19 +++++++++
 3 files changed, 63 insertions(+), 23 deletions(-)
 create mode 100644 app/webpacker/controllers/checked_feedback_controller.js

diff --git a/app/views/spree/admin/orders/_bulk_actions.html.haml b/app/views/spree/admin/orders/_bulk_actions.html.haml
index ce3abc5ca7..7351399aa7 100644
--- a/app/views/spree/admin/orders/_bulk_actions.html.haml
+++ b/app/views/spree/admin/orders/_bulk_actions.html.haml
@@ -1,20 +1,25 @@
-%button.plain.ofn-drop-down.disabled{ "data-checked-target": "disable" }
-  %span{ class: 'icon-reorder' }
-    ="#{t('admin.actions')}".html_safe
-  %span.toggle-off.icon-caret-up
-  %span.toggle-on.icon-caret-down
+.ofn-drop-down-with-prepend
+  .ofn-drop-down-prepend.disabled{ "data-checked-target": "disable" }
+    %span{ "data-controller": "checked-feedback", "data-checked-feedback-translation-value": "spree.admin.orders.index.selected" }
+      = t("spree.admin.orders.index.selected", count: 0)
 
-  %div.menu.dropdown-content
-    %div.menu_item
-      %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "resend_confirmation" }
-        = t('spree.admin.orders.index.resend_confirmation')
-    - if Spree::Config[:enable_invoices?]
+  %button.plain.ofn-drop-down.disabled{ "data-checked-target": "disable" }
+    %span{ class: 'icon-reorder' }
+      ="#{t('admin.actions')}".html_safe
+    %span.toggle-off.icon-caret-up
+    %span.toggle-on.icon-caret-down
+
+    %div.menu.dropdown-content
       %div.menu_item
-        %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "send_invoice" }
-          = t('spree.admin.orders.index.send_invoice')
+        %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "resend_confirmation" }
+          = t('spree.admin.orders.index.resend_confirmation')
+      - if Spree::Config[:enable_invoices?]
+        %div.menu_item
+          %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "send_invoice" }
+            = t('spree.admin.orders.index.send_invoice')
+        %div.menu_item
+          %span.name{ "data-controller": "bulk-actions", "data-action": "click->bulk-actions#perform", "data-bulk-actions-reflex-value": "Admin::Orders#bulk_invoice" }
+            = t('spree.admin.orders.index.print_invoices')
       %div.menu_item
-        %span.name{ "data-controller": "bulk-actions", "data-action": "click->bulk-actions#perform", "data-bulk-actions-reflex-value": "Admin::Orders#bulk_invoice" }
-          = t('spree.admin.orders.index.print_invoices')
-    %div.menu_item
-      %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "cancel_orders" }
-        = t('spree.admin.orders.index.cancel_orders')
+        %span.name{ "data-controller": "modal-link", "data-action": "click->modal-link#open", "data-modal-link-target-value": "cancel_orders" }
+          = t('spree.admin.orders.index.cancel_orders')
diff --git a/app/webpacker/controllers/checked_controller.js b/app/webpacker/controllers/checked_controller.js
index 66ab32ae0c..6317635fa4 100644
--- a/app/webpacker/controllers/checked_controller.js
+++ b/app/webpacker/controllers/checked_controller.js
@@ -2,6 +2,7 @@ import { Controller } from "stimulus";
 
 export default class extends Controller {
   static targets = ["all", "checkbox", "disable"];
+  static values = { count: Number };
 
   connect() {
     this.toggleCheckbox();
@@ -11,29 +12,44 @@ export default class extends Controller {
     this.checkboxTargets.forEach((checkbox) => {
       checkbox.checked = this.allTarget.checked;
     });
+
+    this.countValue = this.allTarget.checked ? this.checkboxTargets.length : 0;
+
     this.#toggleDisabled();
   }
 
   toggleCheckbox() {
-    this.allTarget.checked = this.checkboxTargets.every((checkbox) => checkbox.checked);
+    this.countValue = this.#checkedCount();
+    this.allTarget.checked = this.#allChecked();
+
     this.#toggleDisabled();
   }
 
+  countValueChanged() {
+    window.dispatchEvent(
+      new CustomEvent("checked:updated", { detail: { count: this.countValue } })
+    );
+  }
+
   // private
 
+  #checkedCount() {
+    return this.checkboxTargets.filter((checkbox) => checkbox.checked).length;
+  }
+
+  #allChecked() {
+    return this.countValue === this.checkboxTargets.length;
+  }
+
   #toggleDisabled() {
     if (!this.hasDisableTarget) {
       return;
     }
 
-    if (this.#noneChecked()) {
+    if (this.#checkedCount() === 0) {
       this.disableTargets.forEach((element) => element.classList.add("disabled"));
     } else {
       this.disableTargets.forEach((element) => element.classList.remove("disabled"));
     }
   }
-
-  #noneChecked() {
-    return this.checkboxTargets.every((checkbox) => !checkbox.checked);
-  }
 }
diff --git a/app/webpacker/controllers/checked_feedback_controller.js b/app/webpacker/controllers/checked_feedback_controller.js
new file mode 100644
index 0000000000..1cb0501e0c
--- /dev/null
+++ b/app/webpacker/controllers/checked_feedback_controller.js
@@ -0,0 +1,19 @@
+import { Controller } from "stimulus";
+
+export default class extends Controller {
+  static values = { translation: String };
+
+  connect() {
+    window.addEventListener("checked:updated", this.updateFeedback);
+  }
+
+  disconnect() {
+    window.removeEventListener("checked:updated", this.updateFeedback);
+  }
+
+  updateFeedback = (event) => {
+    this.element.textContent = I18n.t(this.translationValue, {
+      count: event?.detail?.count ? event.detail.count : 0,
+    });
+  };
+}

From 52450028a1b1133887f0fcf7c8c769a053c95c78 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 12 May 2023 13:04:33 +0100
Subject: [PATCH 27/38] Fix checkbox alignment

---
 app/views/spree/admin/orders/_filters.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/views/spree/admin/orders/_filters.html.haml b/app/views/spree/admin/orders/_filters.html.haml
index 89109ae14d..8a32ceb052 100644
--- a/app/views/spree/admin/orders/_filters.html.haml
+++ b/app/views/spree/admin/orders/_filters.html.haml
@@ -31,7 +31,7 @@
         = label_tag "q_bill_address_lastname_start", t(:last_name_begins_with)
         = text_field_tag "q[bill_address_lastname_start]", nil, size: 25
     .omega.four.columns
-      .field.checkbox
+      .field.checkbox.inline-checkbox
         %label
           = check_box_tag "q[completed_at_not_null]", 1, true
           = t(:show_only_complete_orders)

From be1ed2bbcfa8b0a4427ae507f0cda8a34da75ab7 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 12 May 2023 13:11:38 +0100
Subject: [PATCH 28/38] Update tomselect multiselect styling

---
 .../css/admin/components/tom_select.scss      | 31 +++++++++++++------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/app/webpacker/css/admin/components/tom_select.scss b/app/webpacker/css/admin/components/tom_select.scss
index 4c1d31d0e4..076f0a55b2 100644
--- a/app/webpacker/css/admin/components/tom_select.scss
+++ b/app/webpacker/css/admin/components/tom_select.scss
@@ -2,17 +2,28 @@
   min-height: initial;
 }
 
-.ts-wrapper.multi .ts-control [data-value] {
-  text-shadow: none;
-  background-image: none;
-  background-repeat: initial;
-  box-shadow: none;
-  background-color: $spree-blue;
-}
+.ts-wrapper.multi {
+  .ts-control {
+    box-shadow: none;
+    border-color: $pale-blue;
 
-.ts-wrapper.multi .ts-control > div {
-  border: none;
-  background-color: $spree-blue;
+    &:focus {
+      border-color: $spree-green;
+    }
+
+    [data-value] {
+      text-shadow: none;
+      background-image: none;
+      background-repeat: initial;
+      box-shadow: none;
+      background-color: $spree-blue;
+    }
+  }
+
+  .ts-control > div {
+    border: none;
+    background-color: $spree-blue;
+  }
 }
 
 .ts-wrapper.plugin-remove_button .item .remove {

From abf00353ea61f4ce6c1d09fa80ad93180455fb31 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 12 May 2023 13:15:34 +0100
Subject: [PATCH 29/38] Permit explicit params

---
 app/controllers/spree/admin/orders_controller.rb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/controllers/spree/admin/orders_controller.rb b/app/controllers/spree/admin/orders_controller.rb
index cd985eff12..d1e59b4c1a 100644
--- a/app/controllers/spree/admin/orders_controller.rb
+++ b/app/controllers/spree/admin/orders_controller.rb
@@ -132,10 +132,12 @@ module Spree
       end
 
       def search_params
-        search_defaults.deep_merge(params.permit!).to_h.with_indifferent_access
+        default_filters.deep_merge(
+          params.permit(:page, :per_page, :shipping_method_id, q: {})
+        ).to_h.with_indifferent_access
       end
 
-      def search_defaults
+      def default_filters
         { q: { completed_at_not_null: 1, s: "completed_at desc" } }
       end
 

From dcdcdb4fc008266dbbe0d523b949cb0ab8aca0f3 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 12 May 2023 14:29:59 +0100
Subject: [PATCH 30/38] Align filter buttons centrally

---
 .../spree/admin/orders/_filters.html.haml     | 15 +++++----
 app/webpacker/css/admin/shared/layout.scss    | 32 +++++++++++++++----
 2 files changed, 34 insertions(+), 13 deletions(-)

diff --git a/app/views/spree/admin/orders/_filters.html.haml b/app/views/spree/admin/orders/_filters.html.haml
index 8a32ceb052..fcf14a4441 100644
--- a/app/views/spree/admin/orders/_filters.html.haml
+++ b/app/views/spree/admin/orders/_filters.html.haml
@@ -51,10 +51,11 @@
         options_for_select(OrderCycle.managed_by(spree_current_user).where('order_cycles.orders_close_at is not null').order('order_cycles.orders_close_at DESC').map {|oc| [oc.name, oc.id]}, params[:order_cycle_ids]),
         { class: "fullwidth", multiple: true, data: { controller: "tom-select", "tom-select-options-value": { plugins: ['remove_button'], maxItems: nil } }})
     .clearfix
-    .actions.filter-actions
-      %button{type: "submit", class: "button"}
-        %i.icon-search
-        = t(:filter_results)
-      %button{"id": "clear_filters_button", type: "button", "data-controller": "search", "data-action": "click->search#reset" }
-        =  t(:clear_filters)
-          
+    .actions.filter-actions{ style: "column-gap: 0" }
+      .eight.columns.alpha
+        %button.float-right.mr-0{type: "submit", class: "button"}
+          %i.icon-search
+          = t(:filter_results)
+      .eight.columns.omega
+        %button.float-left{"id": "clear_filters_button", type: "button", "data-controller": "search", "data-action": "click->search#reset" }
+          =  t(:clear_filters)
diff --git a/app/webpacker/css/admin/shared/layout.scss b/app/webpacker/css/admin/shared/layout.scss
index 099912c744..35d4c2613d 100644
--- a/app/webpacker/css/admin/shared/layout.scss
+++ b/app/webpacker/css/admin/shared/layout.scss
@@ -2,8 +2,8 @@
 //---------------------------------------------------
 * {
   -webkit-box-sizing: border-box;
-     -moz-box-sizing: border-box;
-          box-sizing: border-box;
+  -moz-box-sizing: border-box;
+  box-sizing: border-box;
 }
 
 .admin {
@@ -68,6 +68,23 @@
 .hidden {
   display: none;
 }
+
+.float-right {
+  float: right;
+}
+
+.float-left {
+  float: left;
+}
+
+.mr-0 {
+  margin-right: 0 !important;
+}
+
+.ml-0 {
+  margin-left: 0 !important;
+}
+
 @media print {
   .print-hidden {
     display: none !important;
@@ -81,7 +98,9 @@
   padding: 5px 0;
 }
 
-#logo { height: 40px }
+#logo {
+  height: 40px;
+}
 
 .page-title {
   i {
@@ -108,7 +127,8 @@
 }
 
 @media print {
-  header, nav {
-    display:none;
+  header,
+  nav {
+    display: none;
   }
-}
\ No newline at end of file
+}

From 005d95e882b51410c64e72799af4b4ebecaabe7c Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Sun, 21 May 2023 13:33:29 +0100
Subject: [PATCH 31/38] Fix "Resend Confirmation" link and add missing test
 coverage

---
 app/helpers/spree/admin/orders_helper.rb |  1 -
 config/routes/spree.rb                   |  2 +-
 spec/system/admin/order_spec.rb          | 18 ++++++++++++++++++
 3 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/app/helpers/spree/admin/orders_helper.rb b/app/helpers/spree/admin/orders_helper.rb
index 9032f7b787..81f9066f90 100644
--- a/app/helpers/spree/admin/orders_helper.rb
+++ b/app/helpers/spree/admin/orders_helper.rb
@@ -62,7 +62,6 @@ module Spree
         { name: t(:resend_confirmation),
           url: spree.resend_admin_order_path(@order),
           icon: 'icon-email',
-          method: 'post',
           confirm: t(:confirm_resend_order_confirmation) }
       end
 
diff --git a/config/routes/spree.rb b/config/routes/spree.rb
index 6959454e22..28834db308 100644
--- a/config/routes/spree.rb
+++ b/config/routes/spree.rb
@@ -86,7 +86,7 @@ Spree::Core::Engine.routes.draw do
       member do
         put :fire
         get :fire
-        post :resend
+        get :resend
         get :invoice
         get :print
         get :distribution
diff --git a/spec/system/admin/order_spec.rb b/spec/system/admin/order_spec.rb
index 8bb0f3c1b9..366c2f2a9a 100644
--- a/spec/system/admin/order_spec.rb
+++ b/spec/system/admin/order_spec.rb
@@ -611,6 +611,24 @@ describe '
                                     href: spree.fire_admin_order_path(order, e: 'cancel')
         end
       end
+
+      context "Resending confirmation email" do
+        before do
+          visit spree.edit_admin_order_path(order)
+          find("#links-dropdown .ofn-drop-down").click
+        end
+
+        it "shows the link" do
+          expect(page).to have_link "Resend Confirmation", href: spree.resend_admin_order_path(order)
+        end
+
+        it "resends the confirmation email" do
+          accept_alert "Are you sure you want to resend the order confirmation email?" do
+            click_link "Resend Confirmation"
+          end
+          expect(page).to have_content "Order email has been resent"
+        end
+      end
       
       context "Check send/print invoice links" do
         

From 7c5067ff42321bd51f6e8553bafb3325629b0a94 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Sun, 21 May 2023 13:52:30 +0100
Subject: [PATCH 32/38] Update "special instructions" note tooltip and add
 missing test coverage

---
 app/views/spree/admin/orders/_table_row.html.haml |  7 ++++---
 spec/system/admin/orders_spec.rb                  | 15 +++++++++++++++
 2 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/app/views/spree/admin/orders/_table_row.html.haml b/app/views/spree/admin/orders/_table_row.html.haml
index c7cdfbc78a..591b915147 100644
--- a/app/views/spree/admin/orders/_table_row.html.haml
+++ b/app/views/spree/admin/orders/_table_row.html.haml
@@ -8,11 +8,12 @@
   %td
     %a{ href: edit_admin_order_path(order) }
       = order.number
-    - if order.special_instructions
+    - if order.special_instructions.present?
       %div
         %br
-        %span.icon-warning-sign{'ofn-with-tip' => order.special_instructions.to_s }
-          = t('spree.admin.orders.index.note')
+        %div{ "data-controller": "tooltip", "data-tooltip-tip-value": order.special_instructions.to_s }
+          %span.icon-warning-sign{ "data-tooltip-target": "element" }
+            = t('spree.admin.orders.index.note')
   %td.align-center
     %span.state{ class: order.state.to_s }
       = t('js.admin.orders.order_state.' + order.state.to_s)
diff --git a/spec/system/admin/orders_spec.rb b/spec/system/admin/orders_spec.rb
index 957b903f03..ec6c2fff8e 100644
--- a/spec/system/admin/orders_spec.rb
+++ b/spec/system/admin/orders_spec.rb
@@ -389,6 +389,21 @@ distributors: [distributor4, distributor5]) }
         end
       end
 
+      context "displaying order special instructions" do
+        before do
+          order3.update(special_instructions: "Leave it next to the porch. Thanks!")
+          login_as_admin
+          visit spree.admin_orders_path
+        end
+
+        it "displays a note with order instructions" do
+          within "tr#order_#{order3.id}" do
+            expect(page).to have_content I18n.t('spree.admin.orders.index.note')
+            expect(page).to have_css "[data-tooltip-tip-value='#{order3.special_instructions}']"
+          end
+        end
+      end
+
       context "orders with different order totals" do
         before do
           Spree::LineItem.where(order_id: order2.id).first.update!(quantity: 5)

From f674d5cd378baa953f0c6fbcea370a2e852e8a30 Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Fri, 26 May 2023 13:26:30 +1000
Subject: [PATCH 33/38] Style Layout/TrailingEmptyLines

---
 app/channels/session_channel.rb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/app/channels/session_channel.rb b/app/channels/session_channel.rb
index ea42d56641..be7d418860 100644
--- a/app/channels/session_channel.rb
+++ b/app/channels/session_channel.rb
@@ -11,4 +11,3 @@ class SessionChannel < ApplicationCable::Channel
     stream_from "SessionChannel:#{session_id}"
   end
 end
-

From 15ef826ac158a82de418f364d9a0bbeb53577e60 Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Fri, 26 May 2023 13:27:34 +1000
Subject: [PATCH 34/38] Style Style/ClassAndModuleChildren

---
 app/reflexes/admin/orders_reflex.rb | 146 ++++++++++++++--------------
 1 file changed, 75 insertions(+), 71 deletions(-)

diff --git a/app/reflexes/admin/orders_reflex.rb b/app/reflexes/admin/orders_reflex.rb
index 464a1b3c3e..7e722a2705 100644
--- a/app/reflexes/admin/orders_reflex.rb
+++ b/app/reflexes/admin/orders_reflex.rb
@@ -1,97 +1,101 @@
 # frozen_string_literal: true
 
-class Admin::OrdersReflex < ApplicationReflex
-  before_reflex :authorize_order, only: [:capture, :ship]
+module Admin
+  class OrdersReflex < ApplicationReflex
+    before_reflex :authorize_order, only: [:capture, :ship]
 
-  def capture
-    payment_capture = OrderCaptureService.new(@order)
+    def capture
+      payment_capture = OrderCaptureService.new(@order)
 
-    if payment_capture.call
-      morph dom_id(@order), render(partial: "spree/admin/orders/table_row",
-                                   locals: { order: @order.reload, success: true })
-    else
-      flash[:error] = with_locale{ payment_capture.gateway_error || I18n.t(:payment_processing_failed) }
-      morph_admin_flashes
+      if payment_capture.call
+        morph dom_id(@order), render(partial: "spree/admin/orders/table_row",
+                                     locals: { order: @order.reload, success: true })
+      else
+        flash[:error] = with_locale{
+          payment_capture.gateway_error || I18n.t(:payment_processing_failed)
+        }
+        morph_admin_flashes
+      end
     end
-  end
 
-  def ship
-    if @order.ship
-      morph dom_id(@order), render(partial: "spree/admin/orders/table_row",
-                                   locals: { order: @order.reload, success: true })
-    else
-      flash[:error] = with_locale{ I18n.t("api.orders.failed_to_update") }
-      morph_admin_flashes
+    def ship
+      if @order.ship
+        morph dom_id(@order), render(partial: "spree/admin/orders/table_row",
+                                     locals: { order: @order.reload, success: true })
+      else
+        flash[:error] = with_locale{ I18n.t("api.orders.failed_to_update") }
+        morph_admin_flashes
+      end
     end
-  end
 
-  def bulk_invoice(params)
-    cable_ready.append(
-      selector: "#orders-index",
-      html: render(partial: "spree/admin/orders/bulk/invoice_modal")
-    ).broadcast
+    def bulk_invoice(params)
+      cable_ready.append(
+        selector: "#orders-index",
+        html: render(partial: "spree/admin/orders/bulk/invoice_modal")
+      ).broadcast
 
-    BulkInvoiceJob.perform_later(
-      params[:bulk_ids],
-      "tmp/invoices/#{Time.zone.now.to_i}-#{SecureRandom.hex(2)}.pdf",
-      channel: SessionChannel.for_request(request)
-    )
-
-    morph :nothing
-  end
-
-  def cancel_orders(params)
-    cancelled_orders = OrdersBulkCancelService.new(params, current_user).call
-
-    cable_ready.dispatch_event(name: "modal:close")
-
-    cancelled_orders.each do |order|
-      cable_ready.replace(
-        selector: dom_id(order),
-        html: render(partial: "spree/admin/orders/table_row", locals: { order: order })
+      BulkInvoiceJob.perform_later(
+        params[:bulk_ids],
+        "tmp/invoices/#{Time.zone.now.to_i}-#{SecureRandom.hex(2)}.pdf",
+        channel: SessionChannel.for_request(request)
       )
+
+      morph :nothing
     end
 
-    cable_ready.broadcast
-    morph :nothing
-  end
+    def cancel_orders(params)
+      cancelled_orders = OrdersBulkCancelService.new(params, current_user).call
 
-  def resend_confirmation_emails(params)
-    editable_orders.where(id: params[:bulk_ids]).find_each do |order|
-      next unless can? :resend, order
+      cable_ready.dispatch_event(name: "modal:close")
 
-      Spree::OrderMailer.confirm_email_for_customer(order.id, true).deliver_later
+      cancelled_orders.each do |order|
+        cable_ready.replace(
+          selector: dom_id(order),
+          html: render(partial: "spree/admin/orders/table_row", locals: { order: order })
+        )
+      end
+
+      cable_ready.broadcast
+      morph :nothing
     end
 
-    success("admin.resend_confirmation_emails_feedback", params[:bulk_ids].count)
-  end
+    def resend_confirmation_emails(params)
+      editable_orders.where(id: params[:bulk_ids]).find_each do |order|
+        next unless can? :resend, order
 
-  def send_invoices(params)
-    count = 0
-    editable_orders.where(id: params[:bulk_ids]).find_each do |o|
-      next unless o.distributor.can_invoice? && (o.resumed? || o.complete?)
+        Spree::OrderMailer.confirm_email_for_customer(order.id, true).deliver_later
+      end
 
-      Spree::OrderMailer.invoice_email(o.id).deliver_later
-      count += 1
+      success("admin.resend_confirmation_emails_feedback", params[:bulk_ids].count)
     end
 
-    success("admin.send_invoice_feedback", count)
-  end
+    def send_invoices(params)
+      count = 0
+      editable_orders.where(id: params[:bulk_ids]).find_each do |o|
+        next unless o.distributor.can_invoice? && (o.resumed? || o.complete?)
 
-  private
+        Spree::OrderMailer.invoice_email(o.id).deliver_later
+        count += 1
+      end
 
-  def authorize_order
-    @order = Spree::Order.find_by(id: element.dataset[:id])
-    authorize! :admin, @order
-  end
+      success("admin.send_invoice_feedback", count)
+    end
 
-  def success(i18n_key, count)
-    flash[:success] = with_locale { I18n.t(i18n_key, count: count) }
-    cable_ready.dispatch_event(name: "modal:close")
-    morph_admin_flashes
-  end
+    private
 
-  def editable_orders
-    Permissions::Order.new(current_user).editable_orders
+    def authorize_order
+      @order = Spree::Order.find_by(id: element.dataset[:id])
+      authorize! :admin, @order
+    end
+
+    def success(i18n_key, count)
+      flash[:success] = with_locale { I18n.t(i18n_key, count: count) }
+      cable_ready.dispatch_event(name: "modal:close")
+      morph_admin_flashes
+    end
+
+    def editable_orders
+      Permissions::Order.new(current_user).editable_orders
+    end
   end
 end

From 2e52a633aec2d5fd20f408037a5a0f48cd7ac9f2 Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Fri, 26 May 2023 13:34:48 +1000
Subject: [PATCH 35/38] Acknowledge new style violations

---
 .rubocop_todo.yml | 50 ++++++++++++++++++++---------------------------
 1 file changed, 21 insertions(+), 29 deletions(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 4abfdc4d3a..b0b1d1447c 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 1400 --no-auto-gen-timestamp`
-# using RuboCop version 1.50.2.
+# using RuboCop version 1.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -100,7 +100,7 @@ Layout/FirstHashElementIndentation:
   Exclude:
     - 'spec/services/products_renderer_spec.rb'
 
-# Offense count: 11
+# Offense count: 10
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
 # SupportedHashRocketStyles: key, separator, table
@@ -109,7 +109,6 @@ Layout/FirstHashElementIndentation:
 Layout/HashAlignment:
   Exclude:
     - 'app/controllers/spree/users_controller.rb'
-    - 'app/models/spree/image.rb'
     - 'spec/migrations/migrate_customer_names_spec.rb'
     - 'spec/models/enterprise_spec.rb'
     - 'spec/system/admin/customers_spec.rb'
@@ -142,7 +141,7 @@ Layout/LeadingCommentSpace:
   Exclude:
     - 'spec/system/admin/enterprises_spec.rb'
 
-# Offense count: 114
+# Offense count: 115
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: space, no_space
@@ -199,12 +198,13 @@ Layout/LineEndStringConcatenationIndentation:
     - 'spec/system/consumer/cookies_spec.rb'
     - 'spec/system/consumer/shopping/cart_spec.rb'
 
-# Offense count: 615
+# Offense count: 643
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https
 Layout/LineLength:
   Exclude:
+    - 'app/components/confirm_modal_component.rb'
     - 'app/controllers/admin/bulk_line_items_controller.rb'
     - 'app/controllers/admin/enterprise_fees_controller.rb'
     - 'app/controllers/admin/enterprise_relationships_controller.rb'
@@ -367,6 +367,8 @@ Layout/LineLength:
     - 'spec/system/admin/adjustments_spec.rb'
     - 'spec/system/admin/bulk_order_management_spec.rb'
     - 'spec/system/admin/bulk_product_update_spec.rb'
+    - 'spec/system/admin/order_spec.rb'
+    - 'spec/system/admin/product_import_spec.rb'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
@@ -412,7 +414,7 @@ Layout/TrailingEmptyLines:
   Exclude:
     - 'Rakefile'
 
-# Offense count: 70
+# Offense count: 73
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
@@ -420,7 +422,6 @@ Layout/TrailingWhitespace:
     - 'app/controllers/spree/users_controller.rb'
     - 'app/controllers/user_confirmations_controller.rb'
     - 'app/models/enterprise.rb'
-    - 'app/models/spree/image.rb'
     - 'spec/controllers/spree/credit_cards_controller_spec.rb'
     - 'spec/controllers/user_confirmations_controller_spec.rb'
     - 'spec/factories/order_factory.rb'
@@ -438,7 +439,6 @@ Layout/TrailingWhitespace:
     - 'spec/system/admin/order_spec.rb'
     - 'spec/system/admin/product_import_spec.rb'
     - 'spec/system/admin/shipping_methods_spec.rb'
-    - 'spec/system/consumer/split_checkout_spec.rb'
 
 # Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
@@ -468,7 +468,7 @@ Lint/ConstantDefinitionInBlock:
     - 'spec/validators/date_time_string_validator_spec.rb'
     - 'spec/validators/integer_array_validator_spec.rb'
 
-# Offense count: 8
+# Offense count: 6
 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
 Lint/DuplicateBranch:
   Exclude:
@@ -581,6 +581,7 @@ Lint/UselessMethodDefinition:
     - 'app/models/spree/gateway.rb'
 
 # Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: CheckForMethodsWithNoSideEffects.
 Lint/Void:
   Exclude:
@@ -651,7 +652,7 @@ Metrics/BlockNesting:
   Exclude:
     - 'app/models/spree/payment/processing.rb'
 
-# Offense count: 46
+# Offense count: 47
 # Configuration parameters: CountComments, Max, CountAsOne.
 Metrics/ClassLength:
   Exclude:
@@ -659,7 +660,6 @@ Metrics/ClassLength:
     - 'app/controllers/admin/enterprise_fees_controller.rb'
     - 'app/controllers/admin/enterprises_controller.rb'
     - 'app/controllers/admin/order_cycles_controller.rb'
-    - 'app/controllers/admin/product_import_controller.rb'
     - 'app/controllers/admin/resource_controller.rb'
     - 'app/controllers/admin/schedules_controller.rb'
     - 'app/controllers/admin/subscriptions_controller.rb'
@@ -704,7 +704,7 @@ Metrics/ClassLength:
     - 'lib/reporting/reports/enterprise_fee_summary/scope.rb'
     - 'lib/reporting/reports/xero_invoices/base.rb'
 
-# Offense count: 35
+# Offense count: 36
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/CyclomaticComplexity:
   Exclude:
@@ -759,7 +759,7 @@ Metrics/MethodLength:
     - 'lib/reporting/reports/xero_invoices/base.rb'
     - 'lib/tasks/sample_data/product_factory.rb'
 
-# Offense count: 50
+# Offense count: 49
 # Configuration parameters: CountComments, Max, CountAsOne.
 Metrics/ModuleLength:
   Exclude:
@@ -808,16 +808,16 @@ Metrics/ModuleLength:
     - 'spec/models/spree/product_spec.rb'
     - 'spec/models/spree/shipping_method_spec.rb'
     - 'spec/models/spree/tax_rate_spec.rb'
-    - 'spec/models/spree/variant_spec.rb'
     - 'spec/services/permissions/order_spec.rb'
     - 'spec/services/variant_units/option_value_namer_spec.rb'
     - 'spec/support/request/shop_workflow.rb'
     - 'spec/support/request/stripe_stubs.rb'
 
-# Offense count: 7
+# Offense count: 8
 # Configuration parameters: Max, CountKeywordArgs, MaxOptionalParameters.
 Metrics/ParameterLists:
   Exclude:
+    - 'app/components/confirm_modal_component.rb'
     - 'app/helpers/angular_form_builder.rb'
     - 'app/models/product_import/entry_processor.rb'
     - 'lib/reporting/reports/xero_invoices/base.rb'
@@ -852,6 +852,7 @@ Naming/HeredocDelimiterNaming:
     - 'app/models/content_configuration.rb'
 
 # Offense count: 5
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
@@ -930,12 +931,6 @@ Rails/ApplicationController:
   Exclude:
     - 'engines/dfc_provider/app/controllers/dfc_provider/base_controller.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Rails/ApplicationJob:
-  Exclude:
-    - 'app/jobs/report_job.rb'
-
 # Offense count: 5
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
@@ -1083,7 +1078,6 @@ Rails/InverseOf:
   Exclude:
     - 'app/models/enterprise.rb'
     - 'app/models/order_cycle.rb'
-    - 'app/models/spree/adjustment.rb'
     - 'app/models/spree/country.rb'
     - 'app/models/spree/inventory_unit.rb'
     - 'app/models/spree/line_item.rb'
@@ -1122,7 +1116,7 @@ Rails/LexicallyScopedActionFilter:
     - 'app/controllers/spree/admin/zones_controller.rb'
     - 'app/controllers/spree/users_controller.rb'
 
-# Offense count: 9
+# Offense count: 8
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Rails/NegateInclude:
   Exclude:
@@ -1131,11 +1125,10 @@ Rails/NegateInclude:
     - 'app/models/product_import/spreadsheet_entry.rb'
     - 'app/models/spree/order/checkout.rb'
     - 'app/services/order_cart_reset.rb'
-    - 'engines/order_management/app/services/order_management/stock/estimator.rb'
     - 'lib/spree/localized_number.rb'
     - 'spec/support/matchers/table_matchers.rb'
 
-# Offense count: 18
+# Offense count: 17
 Rails/OutputSafety:
   Exclude:
     - 'app/helpers/angular_form_helper.rb'
@@ -1180,7 +1173,7 @@ Rails/PluckInWhere:
   Exclude:
     - 'app/models/spree/variant.rb'
 
-# Offense count: 28
+# Offense count: 30
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Rails/RedundantPresenceValidationOnBelongsTo:
   Exclude:
@@ -1690,7 +1683,7 @@ Style/RedundantStringEscape:
     - 'spec/controllers/spree/admin/shipping_methods_controller_spec.rb'
     - 'spec/system/admin/enterprise_fees_spec.rb'
 
-# Offense count: 206
+# Offense count: 208
 Style/Send:
   Exclude:
     - 'app/controllers/split_checkout_controller.rb'
@@ -1740,7 +1733,7 @@ Style/SlicingWithRange:
     - 'engines/order_management/app/services/order_management/subscriptions/validator.rb'
     - 'lib/discourse/single_sign_on.rb'
 
-# Offense count: 29
+# Offense count: 28
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Mode.
 Style/StringConcatenation:
@@ -1761,7 +1754,6 @@ Style/StringConcatenation:
     - 'lib/spree/core/environment_extension.rb'
     - 'spec/models/spree/line_item_spec.rb'
     - 'spec/models/spree/product_spec.rb'
-    - 'spec/models/spree/variant_spec.rb'
     - 'spec/services/embedded_page_service_spec.rb'
     - 'spec/support/api_helper.rb'
     - 'spec/support/features/datepicker_helper.rb'

From 2373d044f7cbe8e9e634cb8247e1877ace246ed4 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 26 May 2023 10:33:23 +0100
Subject: [PATCH 36/38] Update app/services/orders_bulk_cancel_service.rb

Co-authored-by: Maikel <maikel@email.org.au>
---
 app/services/orders_bulk_cancel_service.rb | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/app/services/orders_bulk_cancel_service.rb b/app/services/orders_bulk_cancel_service.rb
index e041f6f2a6..a788183ffc 100644
--- a/app/services/orders_bulk_cancel_service.rb
+++ b/app/services/orders_bulk_cancel_service.rb
@@ -9,14 +9,11 @@ class OrdersBulkCancelService
   end
 
   def call
-    updated = []
-    editable_orders.where(id: @order_ids).find_each do |order|
+    editable_orders.where(id: @order_ids).each do |order|
       order.send_cancellation_email = @send_cancellation_email
       order.restock_items = @restock_items
       order.cancel
-      updated << order
     end
-    updated
   end
 
   private

From e34c2acba8d9cf119e6421caa14cc36d28df9303 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Fri, 26 May 2023 10:35:41 +0100
Subject: [PATCH 37/38] Move CablecarResponses include to ApplicationController

---
 app/controllers/application_controller.rb        | 1 +
 app/controllers/spree/admin/orders_controller.rb | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
index 4c590b7792..3587072cc1 100644
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -9,6 +9,7 @@ require 'spree/core/controller_helpers/common'
 require 'open_food_network/referer_parser'
 
 class ApplicationController < ActionController::Base
+  include CablecarResponses
   include Pagy::Backend
   include RequestTimeouts
 
diff --git a/app/controllers/spree/admin/orders_controller.rb b/app/controllers/spree/admin/orders_controller.rb
index d1e59b4c1a..8f3e73bf9e 100644
--- a/app/controllers/spree/admin/orders_controller.rb
+++ b/app/controllers/spree/admin/orders_controller.rb
@@ -5,7 +5,6 @@ require 'open_food_network/spree_api_key_loader'
 module Spree
   module Admin
     class OrdersController < Spree::Admin::BaseController
-      include CablecarResponses
       include OpenFoodNetwork::SpreeApiKeyLoader
       helper CheckoutHelper
 

From 1128fd9c02f235c018647d155b0b98504218c53a Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Thu, 1 Jun 2023 12:12:28 +0100
Subject: [PATCH 38/38] Visual tweak to ship/capture buttons and success
 feedback

---
 .../spree/admin/orders/_table_row.html.haml   | 25 +++++++++----------
 .../css/admin/components/table_loading.scss   |  7 +-----
 2 files changed, 13 insertions(+), 19 deletions(-)

diff --git a/app/views/spree/admin/orders/_table_row.html.haml b/app/views/spree/admin/orders/_table_row.html.haml
index 591b915147..42357d161e 100644
--- a/app/views/spree/admin/orders/_table_row.html.haml
+++ b/app/views/spree/admin/orders/_table_row.html.haml
@@ -38,17 +38,16 @@
     %span
       = order.display_total
   %td.actions
-    .flex
-      %div.row-loading-icons
-        - if local_assigns[:success]
-          %i.success.icon-ok-sign{"data-controller": "ephemeral"}
-      %a.icon_link.with-tip.icon-edit.no-text{href: edit_admin_order_path(order), 'ofn-with-tip' => t('spree.admin.orders.index.edit')}
-      - if order.ready_to_ship?
-        %div{ "data-controller": "tooltip", "data-tooltip-tip-value": t('spree.admin.orders.index.ship') }
-          %button.icon-road.icon_link.with-tip.no-text{"data-reflex": "click->Admin::OrdersReflex#ship", "data-id": order.id.to_s,
-          "data-tooltip-target": "element" }
+    %div.row-loading-icons
+      - if local_assigns[:success]
+        %i.success.icon-ok-sign{"data-controller": "ephemeral"}
+    %a.icon_link.with-tip.icon-edit.no-text{href: edit_admin_order_path(order), 'ofn-with-tip' => t('spree.admin.orders.index.edit')}
+    - if order.ready_to_ship?
+      %div{ "data-controller": "tooltip", "data-tooltip-tip-value": t('spree.admin.orders.index.ship') }
+        %button.icon-road.icon_link.with-tip.no-text{"data-reflex": "click->Admin::OrdersReflex#ship", "data-id": order.id.to_s,
+        "data-tooltip-target": "element" }
 
-      - if order.payment_required? && order.pending_payments.reject(&:requires_authorization?).any?
-        %div{ "data-controller": "tooltip", "data-tooltip-tip-value": t('spree.admin.orders.index.capture') }
-          %button.icon-capture.icon_link.no-text{"data-reflex": "click->Admin::OrdersReflex#capture", "data-id": order.id.to_s,
-          "data-tooltip-target": "element" }
+    - if order.payment_required? && order.pending_payments.reject(&:requires_authorization?).any?
+      %div{ "data-controller": "tooltip", "data-tooltip-tip-value": t('spree.admin.orders.index.capture') }
+        %button.icon-capture.icon_link.no-text{"data-reflex": "click->Admin::OrdersReflex#capture", "data-id": order.id.to_s,
+        "data-tooltip-target": "element" }
diff --git a/app/webpacker/css/admin/components/table_loading.scss b/app/webpacker/css/admin/components/table_loading.scss
index 4890d82164..6c97aabc3d 100644
--- a/app/webpacker/css/admin/components/table_loading.scss
+++ b/app/webpacker/css/admin/components/table_loading.scss
@@ -3,14 +3,9 @@
 }
 
 .row-loading-icons {
-  margin-left: 3em;
+  margin-left: 2.5em;
   position: absolute;
 
-  .spinner {
-    border: 0;
-    width: 2.3em;
-  }
-
   i {
     font-size: 2.3em;
     opacity: 0.75;