From 11a1d4e09ec30c795a2a1318a0d646cf7db0c3da Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Thu, 13 Feb 2025 13:42:58 +1100
Subject: [PATCH] Reduce complexity of controller

---
 .../dfc_provider/catalog_items_controller.rb          | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/engines/dfc_provider/app/controllers/dfc_provider/catalog_items_controller.rb b/engines/dfc_provider/app/controllers/dfc_provider/catalog_items_controller.rb
index e9e6fc2232..00d0b63da7 100644
--- a/engines/dfc_provider/app/controllers/dfc_provider/catalog_items_controller.rb
+++ b/engines/dfc_provider/app/controllers/dfc_provider/catalog_items_controller.rb
@@ -13,14 +13,15 @@ module DfcProvider
         EnterpriseBuilder.enterprise(enterprise)
       end
       person.affiliatedOrganizations = enterprises
+      catalog_items = enterprises.flat_map(&:catalogItems)
 
       render json: DfcIo.export(
         person,
-        *person.affiliatedOrganizations,
-        *person.affiliatedOrganizations.flat_map(&:catalogItems),
-        *person.affiliatedOrganizations.flat_map(&:catalogItems).map(&:product),
-        *person.affiliatedOrganizations.flat_map(&:catalogItems).map(&:product).flat_map(&:isVariantOf),
-        *person.affiliatedOrganizations.flat_map(&:catalogItems).flat_map(&:offers),
+        *enterprises,
+        *catalog_items,
+        *catalog_items.map(&:product),
+        *catalog_items.map(&:product).flat_map(&:isVariantOf),
+        *catalog_items.flat_map(&:offers),
       )
     end