From 10c6e5ad9bea92dc5029013c80bc45a00c23f22c Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Sat, 22 Feb 2020 11:24:30 +0000 Subject: [PATCH] Rebuild rubocop todo after latest rebase --- .rubocop_todo.yml | 482 ++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 405 insertions(+), 77 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 7be6d93eb5..d77216e023 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,19 +1,11 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 1400` -# on 2019-12-22 15:36:14 +0100 using RuboCop version 0.78.0. +# on 2020-02-22 11:23:29 +0000 using RuboCop version 0.80.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: TreatCommentsAsGroupSeparators, Include. -# Include: **/*.gemfile, **/Gemfile, **/gems.rb -Bundler/OrderedGems: - Exclude: - - 'Gemfile' - # Offense count: 6 # Cop supports --auto-correct. Layout/EmptyLineAfterGuardClause: @@ -45,7 +37,7 @@ Layout/EndAlignment: Exclude: - 'lib/open_food_network/permalink_generator.rb' -# Offense count: 3 +# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. # SupportedHashRocketStyles: key, separator, table @@ -53,24 +45,23 @@ Layout/EndAlignment: # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit Layout/HashAlignment: Exclude: - - 'app/models/enterprise.rb' - 'spec/lib/open_food_network/orders_and_fulfillments_report/customer_totals_report_spec.rb' -# Offense count: 9 +# Offense count: 8 # Cop supports --auto-correct. -# Configuration parameters: AllowDoxygenCommentStyle. +# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment. Layout/LeadingCommentSpace: Exclude: - 'Gemfile' - 'app/helpers/application_helper.rb' - 'app/models/enterprise.rb' -# Offense count: 27 +# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: - Max: 129 + Max: 115 # Offense count: 1 # Cop supports --auto-correct. @@ -87,14 +78,26 @@ Layout/SpaceAroundOperators: - 'app/services/cart_service.rb' - 'spec/support/cancan_helper.rb' -# Offense count: 4 +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. +# SupportedStyles: space, no_space, compact +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceInsideHashLiteralBraces: + Exclude: + - 'spec/controllers/checkout_controller_spec.rb' + +# Offense count: 2 Lint/AmbiguousOperator: Exclude: - - 'app/controllers/spree/admin/orders/customer_details_controller_decorator.rb' - - 'app/controllers/spree/admin/orders_controller_decorator.rb' - 'spec/controllers/api/enterprise_fees_controller_spec.rb' - 'spec/controllers/spree/admin/payments_controller_spec.rb' +# Offense count: 2 +Lint/Debugger: + Exclude: + - 'app/services/order_factory.rb' + # Offense count: 1 Lint/DuplicateHashKey: Exclude: @@ -162,10 +165,20 @@ Lint/Void: Exclude: - 'app/serializers/api/enterprise_serializer.rb' +# Offense count: 1 +Metrics/AbcSize: + Max: 16 + +# Offense count: 1 +# Configuration parameters: CountComments, ExcludedMethods. +# ExcludedMethods: refine +Metrics/BlockLength: + Max: 27 + # Offense count: 1 # Configuration parameters: CountComments. Metrics/ModuleLength: - Max: 114 + Max: 121 # Offense count: 8 Naming/AccessorMethodName: @@ -183,34 +196,18 @@ Naming/HeredocDelimiterNaming: Exclude: - 'app/models/content_configuration.rb' -# Offense count: 5 +# Offense count: 3 # Configuration parameters: EnforcedStyleForLeadingUnderscores. # SupportedStylesForLeadingUnderscores: disallowed, required, optional Naming/MemoizedInstanceVariableName: Exclude: - - 'app/controllers/spree/admin/payments_controller_decorator.rb' - 'lib/open_food_network/address_finder.rb' - - 'lib/spree/authentication_helpers.rb' -# Offense count: 8 +# Offense count: 7 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. -# AllowedNames: io, id, to, by, on, in, at, ip, db, os +# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp Naming/MethodParameterName: Exclude: - - 'app/helpers/spree/admin/base_helper_decorator.rb' - - 'app/helpers/spree/base_helper_decorator.rb' - - 'app/services/subscription_validator.rb' - - 'lib/open_food_network/reports/bulk_coop_report.rb' - - 'lib/open_food_network/xero_invoices_report.rb' - - 'spec/lib/open_food_network/reports/report_spec.rb' - - 'spec/mailers/producer_mailer_spec.rb' - -# Offense count: 8 -# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. -# AllowedNames: io, id, to, by, on, in, at, ip, db, os -Naming/MethodParameterName: - Exclude: - - 'app/helpers/spree/admin/base_helper_decorator.rb' - 'app/helpers/spree/base_helper_decorator.rb' - 'app/services/subscription_validator.rb' - 'lib/open_food_network/reports/bulk_coop_report.rb' @@ -245,19 +242,359 @@ Naming/PredicateName: - 'lib/open_food_network/packing_report.rb' - 'lib/tasks/data.rake' -# Offense count: 13 +# Offense count: 154 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: braces, no_braces, context_dependent -Style/BracesAroundHashParameters: +# Configuration parameters: EnforcedStyle, Include. +# SupportedStyles: action, filter +# Include: app/controllers/**/*.rb +Rails/ActionFilter: Exclude: - - 'app/models/spree/payment_decorator.rb' - - 'lib/open_food_network/variant_and_line_item_naming.rb' + - 'app/controllers/admin/column_preferences_controller.rb' + - 'app/controllers/admin/customers_controller.rb' + - 'app/controllers/admin/enterprise_fees_controller.rb' + - 'app/controllers/admin/enterprise_groups_controller.rb' + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/controllers/admin/producer_properties_controller.rb' + - 'app/controllers/admin/product_import_controller.rb' + - 'app/controllers/admin/schedules_controller.rb' + - 'app/controllers/admin/stripe_connect_settings_controller.rb' + - 'app/controllers/admin/subscription_line_items_controller.rb' + - 'app/controllers/admin/subscriptions_controller.rb' + - 'app/controllers/admin/variant_overrides_controller.rb' + - 'app/controllers/api/base_controller.rb' + - 'app/controllers/api/enterprise_attachment_controller.rb' + - 'app/controllers/api/enterprises_controller.rb' + - 'app/controllers/api/shipments_controller.rb' + - 'app/controllers/api/variants_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/base_controller.rb' + - 'app/controllers/cart_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/discourse_sso_controller.rb' + - 'app/controllers/enterprises_controller.rb' + - 'app/controllers/home_controller.rb' + - 'app/controllers/line_items_controller.rb' + - 'app/controllers/producers_controller.rb' + - 'app/controllers/registration_controller.rb' + - 'app/controllers/shop_controller.rb' + - 'app/controllers/shops_controller.rb' + - 'app/controllers/spree/admin/adjustments_controller.rb' + - 'app/controllers/spree/admin/base_controller.rb' + - 'app/controllers/spree/admin/images_controller.rb' + - 'app/controllers/spree/admin/mail_methods_controller.rb' + - 'app/controllers/spree/admin/orders/customer_details_controller.rb' + - 'app/controllers/spree/admin/orders_controller.rb' + - 'app/controllers/spree/admin/payment_methods_controller.rb' + - 'app/controllers/spree/admin/payments_controller.rb' + - 'app/controllers/spree/admin/product_properties_controller.rb' + - 'app/controllers/spree/admin/products_controller.rb' + - 'app/controllers/spree/admin/reports/enterprise_fee_summaries_controller.rb' + - 'app/controllers/spree/admin/reports_controller.rb' + - 'app/controllers/spree/admin/resource_controller.rb' + - 'app/controllers/spree/admin/search_controller.rb' + - 'app/controllers/spree/admin/shipping_methods_controller.rb' + - 'app/controllers/spree/admin/states_controller.rb' + - 'app/controllers/spree/admin/tax_rates_controller.rb' + - 'app/controllers/spree/admin/users_controller.rb' + - 'app/controllers/spree/admin/zones_controller.rb' + - 'app/controllers/spree/orders_controller.rb' + - 'app/controllers/spree/store_controller.rb' + - 'app/controllers/spree/user_registrations_controller.rb' + - 'app/controllers/spree/user_sessions_controller.rb' + - 'app/controllers/spree/users_controller.rb' + - 'app/controllers/stripe/webhooks_controller.rb' + - 'app/controllers/user_passwords_controller.rb' + - 'app/controllers/user_registrations_controller.rb' + +# Offense count: 192 +# Cop supports --auto-correct. +Rails/ActiveRecordAliases: + Exclude: + - 'app/controllers/admin/bulk_line_items_controller.rb' + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/admin/subscriptions_controller.rb' + - 'app/controllers/api/customers_controller.rb' + - 'app/controllers/api/enterprise_attachment_controller.rb' + - 'app/controllers/api/enterprises_controller.rb' + - 'app/controllers/api/product_images_controller.rb' + - 'app/controllers/api/products_controller.rb' + - 'app/controllers/api/shipments_controller.rb' + - 'app/controllers/api/taxons_controller.rb' + - 'app/controllers/api/variants_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/spree/admin/orders/customer_details_controller.rb' + - 'app/controllers/spree/admin/orders_controller.rb' + - 'app/controllers/spree/admin/payment_methods_controller.rb' + - 'app/controllers/spree/admin/resource_controller.rb' + - 'app/controllers/spree/admin/taxons_controller.rb' + - 'app/controllers/spree/admin/users_controller.rb' + - 'app/controllers/spree/credit_cards_controller.rb' + - 'app/controllers/spree/orders_controller.rb' + - 'app/controllers/spree/users_controller.rb' + - 'app/helpers/i18n_helper.rb' + - 'app/jobs/subscription_placement_job.rb' + - 'app/models/spree/adjustment_decorator.rb' + - 'app/models/spree/line_item_decorator.rb' + - 'app/models/spree/product_set.rb' + - 'app/services/line_item_syncer.rb' + - 'app/services/order_factory.rb' + - 'app/services/order_syncer.rb' + - 'app/services/user_default_address_setter.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/subscription_payment_updater.rb' + - 'lib/stripe/profile_storer.rb' + - 'spec/controllers/admin/proxy_orders_controller_spec.rb' + - 'spec/controllers/admin/subscriptions_controller_spec.rb' + - 'spec/controllers/api/orders_controller_spec.rb' + - 'spec/controllers/line_items_controller_spec.rb' + - 'spec/controllers/spree/admin/payment_methods_controller_spec.rb' + - 'spec/controllers/spree/orders_controller_spec.rb' + - 'spec/features/admin/order_cycles_spec.rb' + - 'spec/features/admin/subscriptions_spec.rb' + - 'spec/features/admin/variant_overrides_spec.rb' + - 'spec/features/admin/variants_spec.rb' + - 'spec/features/consumer/account_spec.rb' - 'spec/features/consumer/registration_spec.rb' - - 'spec/models/enterprise_fee_spec.rb' + - 'spec/features/consumer/shopping/cart_spec.rb' + - 'spec/features/consumer/shopping/orders_spec.rb' + - 'spec/features/consumer/shopping/shopping_spec.rb' + - 'spec/jobs/subscription_confirm_job_spec.rb' + - 'spec/jobs/subscription_placement_job_spec.rb' + - 'spec/lib/open_food_network/proxy_order_syncer_spec.rb' + - 'spec/models/customer_spec.rb' + - 'spec/models/enterprise_caching_spec.rb' + - 'spec/models/exchange_spec.rb' + - 'spec/models/order_cycle_spec.rb' + - 'spec/models/producer_property_spec.rb' + - 'spec/models/proxy_order_spec.rb' + - 'spec/models/spree/adjustment_spec.rb' + - 'spec/models/spree/credit_card_spec.rb' + - 'spec/models/spree/line_item_spec.rb' + - 'spec/models/spree/order_spec.rb' - 'spec/models/spree/product_spec.rb' + - 'spec/models/spree/user_spec.rb' + - 'spec/models/spree/variant_spec.rb' + - 'spec/requests/checkout/stripe_connect_spec.rb' + - 'spec/services/order_syncer_spec.rb' + - 'spec/services/subscription_estimator_spec.rb' + +# Offense count: 1 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: strict, flexible +Rails/Date: + Exclude: + - 'app/models/order_cycle.rb' + +# Offense count: 5 +# Cop supports --auto-correct. +# Configuration parameters: Whitelist. +# Whitelist: find_by_sql +Rails/DynamicFindBy: + Exclude: + - 'app/controllers/spree/admin/orders/customer_details_controller.rb' + - 'app/controllers/spree/admin/orders_controller.rb' + - 'app/controllers/spree/admin/payments_controller.rb' + - 'app/controllers/spree/admin/products_controller.rb' + - 'spec/support/request/web_helper.rb' + +# Offense count: 16 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: slashes, arguments +Rails/FilePath: + Exclude: + - 'app/models/product_import/product_importer.rb' + - 'lib/tasks/karma.rake' + - 'spec/controllers/api/logos_controller_spec.rb' + - 'spec/controllers/api/product_images_controller_spec.rb' + - 'spec/controllers/api/promo_images_controller_spec.rb' + - 'spec/factories/product_factory.rb' + - 'spec/features/admin/content_spec.rb' + - 'spec/features/admin/enterprises/images_spec.rb' + - 'spec/models/content_configuration_spec.rb' + - 'spec/models/spree/variant_spec.rb' + - 'spec/serializers/api/admin/enterprise_serializer_spec.rb' + - 'spec/support/downloads_helper.rb' + +# Offense count: 7 +# Cop supports --auto-correct. +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/FindBy: + Exclude: + - 'app/models/enterprise.rb' + - 'app/models/product_import/entry_processor.rb' + - 'app/models/product_import/entry_validator.rb' + - 'app/models/product_import/spreadsheet_data.rb' + - 'app/models/spree/user.rb' + +# Offense count: 7 +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/HasAndBelongsToMany: + Exclude: + - 'app/models/enterprise.rb' + - 'app/models/enterprise_group.rb' + - 'app/models/order_cycle.rb' + - 'app/models/schedule.rb' + - 'app/models/spree/concerns/payment_method_distributors.rb' + - 'app/models/spree/line_item_decorator.rb' + +# Offense count: 24 +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/HasManyOrHasOneDependent: + Exclude: + - 'app/models/customer.rb' + - 'app/models/enterprise.rb' + - 'app/models/order_cycle.rb' + - 'app/models/spree/adjustment_decorator.rb' + - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/payment_method_decorator.rb' + - 'app/models/spree/property_decorator.rb' + - 'app/models/spree/shipping_method_decorator.rb' + - 'app/models/spree/user.rb' + - 'app/models/spree/variant_decorator.rb' + - 'app/models/subscription.rb' + +# Offense count: 83 +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: + Exclude: + - 'app/helpers/admin/injection_helper.rb' + - 'app/helpers/angular_form_builder.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/enterprises_helper.rb' + - 'app/helpers/injection_helper.rb' + - 'app/helpers/order_cycles_helper.rb' + - 'app/helpers/shared_helper.rb' + - 'app/helpers/shop_helper.rb' + - 'app/helpers/spree/admin/orders_helper.rb' + - 'app/helpers/spree/orders_helper.rb' + +# Offense count: 1 +# Configuration parameters: Include. +# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb +Rails/Output: + Exclude: + - 'app/services/order_factory.rb' + +# Offense count: 12 +Rails/OutputSafety: + Exclude: + - 'app/controllers/spree/admin/reports_controller.rb' + - 'app/helpers/angular_form_helper.rb' + - 'app/helpers/spree/admin/base_helper.rb' + - 'app/helpers/spree/admin/navigation_helper.rb' + - 'app/helpers/spree/admin/orders_helper.rb' + - 'app/helpers/spree/admin/zones_helper.rb' + - 'app/helpers/spree/reports_helper.rb' + - 'app/serializers/api/product_serializer.rb' + - 'lib/spree/money_decorator.rb' + - 'spec/features/admin/orders_spec.rb' + +# Offense count: 2 +# Configuration parameters: Include. +# Include: **/Rakefile, **/*.rake +Rails/RakeEnvironment: + Exclude: + - 'lib/tasks/specs.rake' + +# Offense count: 9 +Rails/ReflectionClassName: + Exclude: + - 'app/models/customer.rb' + - 'app/models/distributor_shipping_method.rb' + - 'app/models/enterprise_role.rb' + - 'app/models/subscription.rb' + +# Offense count: 213 +# Configuration parameters: Blacklist, Whitelist. +# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters +Rails/SkipsModelValidations: + Exclude: + - 'app/controllers/spree/admin/payment_methods_controller.rb' + - 'app/controllers/spree/admin/resource_controller.rb' + - 'app/controllers/spree/admin/shipping_methods_controller.rb' + - 'app/controllers/spree/admin/taxons_controller.rb' + - 'app/controllers/spree/orders_controller.rb' + - 'app/jobs/subscription_confirm_job.rb' + - 'app/jobs/subscription_placement_job.rb' + - 'app/models/enterprise.rb' + - 'app/models/enterprise_relationship.rb' + - 'app/models/product_import/inventory_reset_strategy.rb' + - 'app/models/proxy_order.rb' + - 'app/models/spree/address_decorator.rb' + - 'app/models/spree/credit_card_decorator.rb' + - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/payment_decorator.rb' + - 'app/models/subscription.rb' + - 'app/models/variant_override.rb' + - 'app/services/order_factory.rb' + - 'engines/order_management/spec/services/order_management/reports/enterprise_fee_summary/report_service_spec.rb' + - 'lib/tasks/data/anonymize_data.rake' + - 'lib/tasks/sample_data/product_factory.rb' + - 'lib/tasks/users.rake' + - 'spec/controllers/admin/subscription_line_items_controller_spec.rb' + - 'spec/controllers/admin/variant_overrides_controller_spec.rb' + - 'spec/controllers/api/order_cycles_controller_spec.rb' + - 'spec/controllers/api/orders_controller_spec.rb' + - 'spec/controllers/api/products_controller_spec.rb' + - 'spec/controllers/api/shipments_controller_spec.rb' + - 'spec/controllers/api/variants_controller_spec.rb' + - 'spec/controllers/checkout_controller_spec.rb' + - 'spec/controllers/enterprises_controller_spec.rb' + - 'spec/controllers/spree/admin/orders_controller_spec.rb' + - 'spec/controllers/spree/admin/overview_controller_spec.rb' + - 'spec/controllers/spree/admin/payment_methods_controller_spec.rb' + - 'spec/controllers/spree/credit_cards_controller_spec.rb' + - 'spec/factories.rb' + - 'spec/factories/order_factory.rb' + - 'spec/features/admin/bulk_order_management_spec.rb' + - 'spec/features/admin/bulk_product_update_spec.rb' + - 'spec/features/admin/configuration/tax_rates_spec.rb' + - 'spec/features/admin/order_cycles_spec.rb' + - 'spec/features/admin/orders_spec.rb' + - 'spec/features/admin/reports_spec.rb' + - 'spec/features/consumer/shopping/checkout_spec.rb' + - 'spec/features/consumer/shopping/products_spec.rb' + - 'spec/features/consumer/shopping/shopping_spec.rb' + - 'spec/helpers/enterprises_helper_spec.rb' + - 'spec/helpers/order_cycles_helper_spec.rb' + - 'spec/jobs/subscription_placement_job_spec.rb' + - 'spec/lib/open_food_network/address_finder_spec.rb' + - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' + - 'spec/lib/open_food_network/permissions_spec.rb' + - 'spec/lib/open_food_network/products_and_inventory_report_spec.rb' + - 'spec/lib/open_food_network/scope_variant_to_hub_spec.rb' + - 'spec/lib/open_food_network/subscription_payment_updater_spec.rb' + - 'spec/models/calculator/weight_spec.rb' + - 'spec/models/concerns/variant_stock_spec.rb' + - 'spec/models/enterprise_relationship_spec.rb' + - 'spec/models/exchange_spec.rb' + - 'spec/models/spree/adjustment_spec.rb' + - 'spec/models/spree/line_item_spec.rb' + - 'spec/models/spree/order_spec.rb' + - 'spec/models/spree/product_spec.rb' + - 'spec/models/spree/variant_spec.rb' - 'spec/models/tag_rule/discount_order_spec.rb' - - 'spec/support/seeds.rb' + - 'spec/performance/proxy_order_syncer_spec.rb' + - 'spec/serializers/api/admin/subscription_line_item_serializer_spec.rb' + - 'spec/services/order_cycle_distributed_products_spec.rb' + - 'spec/services/order_factory_spec.rb' + - 'spec/services/order_syncer_spec.rb' + - 'spec/services/product_tag_rules_filterer_spec.rb' + - 'spec/services/products_renderer_spec.rb' + - 'spec/services/restart_checkout_spec.rb' + - 'spec/support/request/shop_workflow.rb' + +# Offense count: 1 +# Configuration parameters: Environments. +# Environments: development, test, production +Rails/UnknownEnv: + Exclude: + - 'app/models/spree/app_configuration_decorator.rb' # Offense count: 2 Style/CaseEquality: @@ -372,10 +709,10 @@ Style/FormatStringToken: - 'lib/open_food_network/sales_tax_report.rb' - 'spec/features/admin/bulk_order_management_spec.rb' -# Offense count: 925 +# Offense count: 920 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. -# SupportedStyles: always, never +# SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Exclude: - 'Gemfile' @@ -410,7 +747,6 @@ Style/FrozenStringLiteralComment: - 'app/controllers/api/enterprise_attachment_controller.rb' - 'app/controllers/api/enterprise_fees_controller.rb' - 'app/controllers/api/enterprises_controller.rb' - - 'app/controllers/api/exchange_products_controller.rb' - 'app/controllers/api/logos_controller.rb' - 'app/controllers/api/order_cycles_controller.rb' - 'app/controllers/api/orders_controller.rb' @@ -425,7 +761,6 @@ Style/FrozenStringLiteralComment: - 'app/controllers/application_controller.rb' - 'app/controllers/base_controller.rb' - 'app/controllers/cart_controller.rb' - - 'app/controllers/checkout_controller.rb' - 'app/controllers/discourse_sso_controller.rb' - 'app/controllers/enterprises_controller.rb' - 'app/controllers/groups_controller.rb' @@ -446,19 +781,18 @@ Style/FrozenStringLiteralComment: - 'app/controllers/spree/admin/images_controller.rb' - 'app/controllers/spree/admin/invoices_controller.rb' - 'app/controllers/spree/admin/mail_methods_controller.rb' - - 'app/controllers/spree/admin/orders/customer_details_controller_decorator.rb' - - 'app/controllers/spree/admin/orders_controller_decorator.rb' + - 'app/controllers/spree/admin/orders/customer_details_controller.rb' + - 'app/controllers/spree/admin/orders_controller.rb' - 'app/controllers/spree/admin/overview_controller.rb' - 'app/controllers/spree/admin/payment_methods_controller.rb' - - 'app/controllers/spree/admin/payments_controller_decorator.rb' - 'app/controllers/spree/admin/product_properties_controller.rb' - - 'app/controllers/spree/admin/products_controller_decorator.rb' + - 'app/controllers/spree/admin/products_controller.rb' - 'app/controllers/spree/admin/properties_controller.rb' - 'app/controllers/spree/admin/reports/enterprise_fee_summaries_controller.rb' - 'app/controllers/spree/admin/reports_controller.rb' - - 'app/controllers/spree/admin/resource_controller_decorator.rb' + - 'app/controllers/spree/admin/resource_controller.rb' - 'app/controllers/spree/admin/return_authorizations_controller.rb' - - 'app/controllers/spree/admin/search_controller_decorator.rb' + - 'app/controllers/spree/admin/search_controller.rb' - 'app/controllers/spree/admin/shipping_categories_controller.rb' - 'app/controllers/spree/admin/shipping_methods_controller.rb' - 'app/controllers/spree/admin/states_controller.rb' @@ -468,9 +802,8 @@ Style/FrozenStringLiteralComment: - 'app/controllers/spree/admin/taxonomies_controller.rb' - 'app/controllers/spree/admin/taxons_controller.rb' - 'app/controllers/spree/admin/users_controller.rb' - - 'app/controllers/spree/admin/variants_controller_decorator.rb' + - 'app/controllers/spree/admin/variants_controller.rb' - 'app/controllers/spree/admin/zones_controller.rb' - - 'app/controllers/spree/checkout_controller.rb' - 'app/controllers/spree/credit_cards_controller.rb' - 'app/controllers/spree/home_controller.rb' - 'app/controllers/spree/orders_controller.rb' @@ -484,6 +817,7 @@ Style/FrozenStringLiteralComment: - 'app/controllers/user_confirmations_controller.rb' - 'app/controllers/user_passwords_controller.rb' - 'app/controllers/user_registrations_controller.rb' + - 'app/helpers/admin/enterprises_helper.rb' - 'app/helpers/admin/image_settings_helper.rb' - 'app/helpers/admin/injection_helper.rb' - 'app/helpers/admin/orders_helper.rb' @@ -502,16 +836,16 @@ Style/FrozenStringLiteralComment: - 'app/helpers/injection_helper.rb' - 'app/helpers/map_helper.rb' - 'app/helpers/markdown_helper.rb' - - 'app/helpers/order_cycles_helper.rb' - 'app/helpers/serializer_helper.rb' - 'app/helpers/shared_helper.rb' - 'app/helpers/shop_helper.rb' - 'app/helpers/shop_mail_helper.rb' - - 'app/helpers/spree/admin/base_helper_decorator.rb' + - 'app/helpers/spree/admin/base_helper.rb' - 'app/helpers/spree/admin/general_settings_helper.rb' - - 'app/helpers/spree/admin/navigation_helper_decorator.rb' - - 'app/helpers/spree/admin/orders_helper_decorator.rb' + - 'app/helpers/spree/admin/orders_helper.rb' + - 'app/helpers/spree/admin/payments_helper.rb' - 'app/helpers/spree/admin/taxons_helper.rb' + - 'app/helpers/spree/admin/zones_helper.rb' - 'app/helpers/spree/api/api_helpers.rb' - 'app/helpers/spree/base_helper_decorator.rb' - 'app/helpers/spree/orders_helper.rb' @@ -639,7 +973,6 @@ Style/FrozenStringLiteralComment: - 'app/models/tag_rule/filter_shipping_methods.rb' - 'app/models/variant_override.rb' - 'app/models/variant_override_set.rb' - - 'app/presenters/variant_presenter.rb' - 'app/serializers/api/address_serializer.rb' - 'app/serializers/api/adjustment_serializer.rb' - 'app/serializers/api/admin/basic_enterprise_fee_serializer.rb' @@ -719,6 +1052,7 @@ Style/FrozenStringLiteralComment: - 'app/serializers/api/uncached_enterprise_serializer.rb' - 'app/serializers/api/user_serializer.rb' - 'app/serializers/api/variant_serializer.rb' + - 'app/services/action_callbacks.rb' - 'app/services/advance_order_service.rb' - 'app/services/bulk_invoice_service.rb' - 'app/services/cart_service.rb' @@ -727,7 +1061,6 @@ Style/FrozenStringLiteralComment: - 'app/services/default_shipping_category.rb' - 'app/services/default_stock_location.rb' - 'app/services/embedded_page_service.rb' - - 'app/services/exchange_products_renderer.rb' - 'app/services/exchange_variant_bulk_updater.rb' - 'app/services/exchange_variant_deleter.rb' - 'app/services/invoice_renderer.rb' @@ -826,7 +1159,6 @@ Style/FrozenStringLiteralComment: - 'lib/open_food_network/lettuce_share_report.rb' - 'lib/open_food_network/locking.rb' - 'lib/open_food_network/model_class_from_controller_name.rb' - - 'lib/open_food_network/option_value_namer.rb' - 'lib/open_food_network/order_and_distributor_report.rb' - 'lib/open_food_network/order_cycle_form_applicator.rb' - 'lib/open_food_network/order_cycle_management_report.rb' @@ -964,7 +1296,6 @@ Style/FrozenStringLiteralComment: - 'spec/controllers/spree/admin/shipping_methods_controller_spec.rb' - 'spec/controllers/spree/admin/users_controller_spec.rb' - 'spec/controllers/spree/admin/variants_controller_spec.rb' - - 'spec/controllers/spree/checkout_controller_spec.rb' - 'spec/controllers/spree/credit_cards_controller_spec.rb' - 'spec/controllers/spree/orders_controller_spec.rb' - 'spec/controllers/spree/store_controller_spec.rb' @@ -1243,6 +1574,7 @@ Style/FrozenStringLiteralComment: - 'spec/services/order_cycle_distributed_products_spec.rb' - 'spec/services/order_cycle_distributed_variants_spec.rb' - 'spec/services/order_cycle_form_spec.rb' + - 'spec/services/order_cycle_warning_spec.rb' - 'spec/services/order_factory_spec.rb' - 'spec/services/order_syncer_spec.rb' - 'spec/services/permissions/order_spec.rb' @@ -1304,7 +1636,7 @@ Style/FrozenStringLiteralComment: - 'spec/views/spree/admin/orders/edit.html.haml_spec.rb' - 'spec/views/spree/admin/orders/index.html.haml_spec.rb' -# Offense count: 59 +# Offense count: 50 # Configuration parameters: MinBodyLength. Style/GuardClause: Exclude: @@ -1315,9 +1647,6 @@ Style/GuardClause: - 'app/controllers/base_controller.rb' - 'app/controllers/checkout_controller.rb' - 'app/controllers/home_controller.rb' - - 'app/controllers/spree/admin/orders_controller_decorator.rb' - - 'app/controllers/spree/admin/variants_controller_decorator.rb' - - 'app/controllers/spree/checkout_controller.rb' - 'app/controllers/spree/orders_controller.rb' - 'app/models/enterprise.rb' - 'app/models/enterprise_group.rb' @@ -1338,14 +1667,13 @@ Style/GuardClause: - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/shop_workflow.rb' -# Offense count: 4 +# Offense count: 3 # Configuration parameters: AllowIfModifier. Style/IfInsideElse: Exclude: - 'app/controllers/admin/column_preferences_controller.rb' - 'app/controllers/admin/variant_overrides_controller.rb' - 'app/controllers/api/taxons_controller.rb' - - 'app/controllers/spree/admin/products_controller_decorator.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -1381,7 +1709,7 @@ Style/NegatedUnless: Exclude: - 'app/services/cart_service.rb' -# Offense count: 42 +# Offense count: 41 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. # SupportedStyles: predicate, comparison @@ -1413,16 +1741,17 @@ Style/NumericPredicate: - 'lib/spree/money_decorator.rb' - 'lib/tasks/sample_data.rake' -# Offense count: 15 +# Offense count: 16 # Cop supports --auto-correct. # Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods. # AllowedMethods: present?, blank?, presence, try, try! Style/SafeNavigation: Exclude: - - 'app/controllers/checkout_controller.rb' + - 'app/controllers/spree/admin/payments_controller.rb' - 'app/controllers/spree/credit_cards_controller.rb' - 'app/controllers/spree/orders_controller.rb' - 'app/helpers/i18n_helper.rb' + - 'app/helpers/shop_helper.rb' - 'app/models/producer_property.rb' - 'app/models/product_import/entry_validator.rb' - 'app/models/product_import/product_importer.rb' @@ -1430,10 +1759,9 @@ Style/SafeNavigation: - 'lib/discourse/single_sign_on.rb' - 'spec/factories.rb' -# Offense count: 235 +# Offense count: 232 Style/Send: Exclude: - - 'app/controllers/spree/checkout_controller.rb' - 'app/models/spree/shipping_method_decorator.rb' - 'spec/controllers/admin/subscriptions_controller_spec.rb' - 'spec/controllers/checkout_controller_spec.rb'