From 1085da83a9bf4fa37d8a0a27693c0ff38f10682e Mon Sep 17 00:00:00 2001
From: filipefurtad0 <filipefurtado@gmail.com>
Date: Thu, 20 Jun 2024 10:11:55 -0600
Subject: [PATCH] Moves sorting, pagination, and search describe blocks into
 new file

Deletes describe blocks from products_spec
---
 spec/system/admin/products_v3/index_spec.rb   | 237 ++++++++++++++++
 .../system/admin/products_v3/products_spec.rb | 265 ------------------
 2 files changed, 237 insertions(+), 265 deletions(-)
 create mode 100644 spec/system/admin/products_v3/index_spec.rb

diff --git a/spec/system/admin/products_v3/index_spec.rb b/spec/system/admin/products_v3/index_spec.rb
new file mode 100644
index 0000000000..b4c6575b71
--- /dev/null
+++ b/spec/system/admin/products_v3/index_spec.rb
@@ -0,0 +1,237 @@
+# frozen_string_literal: true
+
+require "system_helper"
+
+RSpec.describe 'As an enterprise user, I can manage my products', feature: :admin_style_v3 do
+  include AdminHelper
+  include WebHelper
+  include AuthenticationHelper
+  include FileHelper
+
+  let(:producer) { create(:supplier_enterprise) }
+  let(:user) { create(:user, enterprises: [producer]) }
+
+  before do
+    login_as user
+  end
+
+  let(:producer_search_selector) { 'input[placeholder="Search for producers"]' }
+  let(:categories_search_selector) { 'input[placeholder="Search for categories"]' }
+  let(:tax_categories_search_selector) { 'input[placeholder="Search for tax categories"]' }
+
+  describe "sorting" do
+    let!(:product_b) { create(:simple_product, name: "Bananas") }
+    let!(:product_a) { create(:simple_product, name: "Apples") }
+    let(:products_table) { "table.products" }
+
+    before do
+      visit admin_products_url
+    end
+
+    it "Should sort products alphabetically by default in ascending order" do
+      within products_table do
+        # Products are in correct order.
+        expect(all_input_values).to match /Apples.*Bananas/
+      end
+    end
+
+    context "when clicked on 'Name' column header" do
+      it "Should sort products alphabetically in descending/ascending order" do
+        within products_table do
+          name_header = page.find('th > a[data-column="name"]')
+
+          # Sort in descending order
+          name_header.click
+          expect(page).to have_content("Name ▼") # this indicates the re-sorted content has loaded
+          expect(all_input_values).to match /Bananas.*Apples/
+
+          # Sort in ascending order
+          name_header.click
+          expect(page).to have_content("Name ▲") # this indicates the re-sorted content has loaded
+          expect(all_input_values).to match /Apples.*Bananas/
+        end
+      end
+    end
+  end
+
+  describe "pagination" do
+    it "has a pagination, has 15 products per page by default and can change the page" do
+      create_products 16
+      visit admin_products_url
+
+      expect(page).to have_selector ".pagination"
+      expect_products_count_to_be 15
+      within ".pagination" do
+        click_on "2"
+      end
+
+      expect(page).to have_content "Showing 16 to 16" # todo: remove unnecessary duplication
+      expect_page_to_be 2
+      expect_per_page_to_be 15
+      expect_products_count_to_be 1
+    end
+
+    it "can change the number of products per page" do
+      create_products 51
+      visit admin_products_url
+
+      select "50", from: "per_page"
+
+      expect(page).to have_content "Showing 1 to 50", wait: 10
+      expect_page_to_be 1
+      expect_per_page_to_be 50
+      expect_products_count_to_be 50
+    end
+  end
+
+  describe "search" do
+    context "product has searchable term" do
+      # create a product with a name that can be searched
+      let!(:product_by_name) { create(:simple_product, name: "searchable product") }
+      let!(:variant_a) {
+        create(:variant, product_id: product_by_name.id, display_name: "Medium box")
+      }
+      let!(:variant_b) { create(:variant, product_id: product_by_name.id, display_name: "Big box") }
+
+      it "can search for a product" do
+        create_products 1
+        visit admin_products_url
+
+        search_for "searchable product"
+
+        expect(page).to have_field "search_term", with: "searchable product"
+        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
+        expect_products_count_to_be 1
+      end
+
+      it "with multiple products" do
+        create_products 2
+        visit admin_products_url
+
+        # returns no results, if the product does not exist
+        search_for "a product which does not exist"
+
+        expect(page).to have_field "search_term", with: "a product which does not exist"
+        expect(page).to have_content "No products found for your search criteria"
+        expect_products_count_to_be 0
+
+        # returns the existing product
+        search_for "searchable product"
+
+        expect(page).to have_field "search_term", with: "searchable product"
+        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
+        expect_products_count_to_be 1
+      end
+
+      it "can search variant names" do
+        create_products 1
+        visit admin_products_url
+
+        expect_products_count_to_be 2
+
+        search_for "Big box"
+
+        expect(page).to have_field "search_term", with: "Big box"
+        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
+        expect_products_count_to_be 1
+      end
+
+      it "reset the page when searching" do
+        create_products 15
+        visit admin_products_url
+
+        within ".pagination" do
+          click_on "2"
+        end
+
+        expect(page).to have_content "Showing 16 to 16"
+        expect_page_to_be 2
+        expect_per_page_to_be 15
+        expect_products_count_to_be 1
+        search_for "searchable product"
+        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
+        expect_products_count_to_be 1
+      end
+
+      it "can clear filters" do
+        create_products 1
+        visit admin_products_url
+
+        search_for "searchable product"
+        expect(page).to have_field "search_term", with: "searchable product"
+        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
+        expect_products_count_to_be 1
+        expect(page).to have_field "Name", with: product_by_name.name
+
+        click_link "Clear search"
+        expect(page).to have_field "search_term", with: ""
+        expect(page).to have_content "Showing 1 to 2"
+        expect_products_count_to_be 2
+      end
+
+      it "shows a message when there are no results" do
+        visit admin_products_url
+
+        search_for "no results"
+        expect(page).to have_content "No products found for your search criteria"
+        expect(page).to have_link "Clear search"
+      end
+    end
+
+    context "product has producer" do
+      before { create_products 1 }
+
+      # create a product with a different supplier
+      let!(:producer1) { create(:supplier_enterprise, name: "Producer 1") }
+      let!(:product_by_supplier) { create(:simple_product, name: "Apples", supplier: producer1) }
+
+      before { user.enterprise_roles.create(enterprise: producer1) }
+
+      it "can search for and update a product" do
+        visit admin_products_url
+
+        search_by_producer "Producer 1"
+
+        # expect(page).to have_content "1 product found for your search criteria."
+        expect(page).to have_select "producer_id", selected: "Producer 1", wait: 5
+        expect_products_count_to_be 1
+
+        within row_containing_name("Apples") do
+          fill_in "Name", with: "Pommes"
+        end
+
+        expect {
+          click_button "Save changes"
+
+          expect(page).to have_content "Changes saved"
+          product_by_supplier.reload
+        }.to change { product_by_supplier.name }.to("Pommes")
+
+        # Search is still applied
+        # expect(page).to have_content "1 product found for your search criteria."
+        expect(page).to have_select "producer_id", selected: "Producer 1"
+        expect_products_count_to_be 1
+      end
+    end
+
+    context "product has category" do
+      before { create_products 1 }
+
+      # create a product with a different category
+      let!(:product_by_category) {
+        create(:simple_product, primary_taxon: create(:taxon, name: "Category 1"))
+      }
+
+      it "can search for a product" do
+        visit admin_products_url
+
+        search_by_category "Category 1"
+
+        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
+        expect(page).to have_select "category_id", selected: "Category 1"
+        expect_products_count_to_be 1
+        expect(page).to have_field "Name", with: product_by_category.name
+      end
+    end
+  end
+end
diff --git a/spec/system/admin/products_v3/products_spec.rb b/spec/system/admin/products_v3/products_spec.rb
index dbcc5f4e19..8c500682ea 100644
--- a/spec/system/admin/products_v3/products_spec.rb
+++ b/spec/system/admin/products_v3/products_spec.rb
@@ -73,55 +73,6 @@ RSpec.describe 'As an enterprise user, I can manage my products', feature: :admi
     end
   end
 
-  describe "listing" do
-    let!(:p1) { create(:product) }
-    let!(:p2) { create(:product) }
-
-    before do
-      visit admin_products_url
-    end
-
-    it "displays a list of products" do
-      within ".products" do
-        # displays table header
-        expect(page).to have_selector "th", text: "Name"
-        expect(page).to have_selector "th", text: "SKU"
-        expect(page).to have_selector "th", text: "Unit scale"
-        expect(page).to have_selector "th", text: "Unit"
-        expect(page).to have_selector "th", text: "Price"
-        expect(page).to have_selector "th", text: "On Hand"
-        expect(page).to have_selector "th", text: "Producer"
-        expect(page).to have_selector "th", text: "Category"
-        expect(page).to have_selector "th", text: "Tax Category"
-        expect(page).to have_selector "th", text: "Inherits Properties?"
-        expect(page).to have_selector "th", text: "Actions"
-
-        # displays product list
-        expect(page).to have_selector row_containing_name(p1.name.to_s)
-        expect(page).to have_selector row_containing_name(p2.name.to_s)
-      end
-    end
-
-    context "with several variants" do
-      let!(:variant1) { p1.variants.first }
-      let!(:variant2) { p2.variants.first }
-      let!(:variant3) { create(:variant, product: p2, on_demand: false, on_hand: 4) }
-
-      before do
-        variant1.update!(on_hand: 0, on_demand: true)
-        variant2.update!(on_hand: 16, on_demand: false)
-        visit spree.admin_products_path
-      end
-
-      it "displays an on hand count in a span for each product" do
-        expect(page).to have_content "On demand"
-        expect(page).not_to have_content "20" # does not display the total stock
-        expect(page).to have_content "16" # displays the stock for variant_2
-        expect(page).to have_content "4"  # displays the stock for variant_3
-      end
-    end
-  end
-
   describe "listing" do
     let!(:p1) { create(:product) }
     let!(:p2) { create(:product) }
@@ -208,222 +159,6 @@ RSpec.describe 'As an enterprise user, I can manage my products', feature: :admi
     end
   end
 
-  describe "sorting" do
-    let!(:product_b) { create(:simple_product, name: "Bananas") }
-    let!(:product_a) { create(:simple_product, name: "Apples") }
-    let(:products_table) { "table.products" }
-
-    before do
-      visit admin_products_url
-    end
-
-    it "Should sort products alphabetically by default in ascending order" do
-      within products_table do
-        # Products are in correct order.
-        expect(all_input_values).to match /Apples.*Bananas/
-      end
-    end
-
-    context "when clicked on 'Name' column header" do
-      it "Should sort products alphabetically in descending/ascending order" do
-        within products_table do
-          name_header = page.find('th > a[data-column="name"]')
-
-          # Sort in descending order
-          name_header.click
-          expect(page).to have_content("Name ▼") # this indicates the re-sorted content has loaded
-          expect(all_input_values).to match /Bananas.*Apples/
-
-          # Sort in ascending order
-          name_header.click
-          expect(page).to have_content("Name ▲") # this indicates the re-sorted content has loaded
-          expect(all_input_values).to match /Apples.*Bananas/
-        end
-      end
-    end
-  end
-
-  describe "pagination" do
-    it "has a pagination, has 15 products per page by default and can change the page" do
-      create_products 16
-      visit admin_products_url
-
-      expect(page).to have_selector ".pagination"
-      expect_products_count_to_be 15
-      within ".pagination" do
-        click_on "2"
-      end
-
-      expect(page).to have_content "Showing 16 to 16" # todo: remove unnecessary duplication
-      expect_page_to_be 2
-      expect_per_page_to_be 15
-      expect_products_count_to_be 1
-    end
-
-    it "can change the number of products per page" do
-      create_products 51
-      visit admin_products_url
-
-      select "50", from: "per_page"
-
-      expect(page).to have_content "Showing 1 to 50", wait: 10
-      expect_page_to_be 1
-      expect_per_page_to_be 50
-      expect_products_count_to_be 50
-    end
-  end
-
-  describe "search" do
-    context "product has searchable term" do
-      # create a product with a name that can be searched
-      let!(:product_by_name) { create(:simple_product, name: "searchable product") }
-      let!(:variant_a) {
-        create(:variant, product_id: product_by_name.id, display_name: "Medium box")
-      }
-      let!(:variant_b) { create(:variant, product_id: product_by_name.id, display_name: "Big box") }
-
-      it "can search for a product" do
-        create_products 1
-        visit admin_products_url
-
-        search_for "searchable product"
-
-        expect(page).to have_field "search_term", with: "searchable product"
-        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
-        expect_products_count_to_be 1
-      end
-
-      it "with multiple products" do
-        create_products 2
-        visit admin_products_url
-
-        # returns no results, if the product does not exist
-        search_for "a product which does not exist"
-
-        expect(page).to have_field "search_term", with: "a product which does not exist"
-        expect(page).to have_content "No products found for your search criteria"
-        expect_products_count_to_be 0
-
-        # returns the existing product
-        search_for "searchable product"
-
-        expect(page).to have_field "search_term", with: "searchable product"
-        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
-        expect_products_count_to_be 1
-      end
-
-      it "can search variant names" do
-        create_products 1
-        visit admin_products_url
-
-        expect_products_count_to_be 2
-
-        search_for "Big box"
-
-        expect(page).to have_field "search_term", with: "Big box"
-        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
-        expect_products_count_to_be 1
-      end
-
-      it "reset the page when searching" do
-        create_products 15
-        visit admin_products_url
-
-        within ".pagination" do
-          click_on "2"
-        end
-
-        expect(page).to have_content "Showing 16 to 16"
-        expect_page_to_be 2
-        expect_per_page_to_be 15
-        expect_products_count_to_be 1
-        search_for "searchable product"
-        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
-        expect_products_count_to_be 1
-      end
-
-      it "can clear filters" do
-        create_products 1
-        visit admin_products_url
-
-        search_for "searchable product"
-        expect(page).to have_field "search_term", with: "searchable product"
-        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
-        expect_products_count_to_be 1
-        expect(page).to have_field "Name", with: product_by_name.name
-
-        click_link "Clear search"
-        expect(page).to have_field "search_term", with: ""
-        expect(page).to have_content "Showing 1 to 2"
-        expect_products_count_to_be 2
-      end
-
-      it "shows a message when there are no results" do
-        visit admin_products_url
-
-        search_for "no results"
-        expect(page).to have_content "No products found for your search criteria"
-        expect(page).to have_link "Clear search"
-      end
-    end
-
-    context "product has producer" do
-      before { create_products 1 }
-
-      # create a product with a different supplier
-      let!(:producer1) { create(:supplier_enterprise, name: "Producer 1") }
-      let!(:product_by_supplier) { create(:simple_product, name: "Apples", supplier: producer1) }
-
-      before { user.enterprise_roles.create(enterprise: producer1) }
-
-      it "can search for and update a product" do
-        visit admin_products_url
-
-        search_by_producer "Producer 1"
-
-        # expect(page).to have_content "1 product found for your search criteria."
-        expect(page).to have_select "producer_id", selected: "Producer 1", wait: 5
-        expect_products_count_to_be 1
-
-        within row_containing_name("Apples") do
-          fill_in "Name", with: "Pommes"
-        end
-
-        expect {
-          click_button "Save changes"
-
-          expect(page).to have_content "Changes saved"
-          product_by_supplier.reload
-        }.to change { product_by_supplier.name }.to("Pommes")
-
-        # Search is still applied
-        # expect(page).to have_content "1 product found for your search criteria."
-        expect(page).to have_select "producer_id", selected: "Producer 1"
-        expect_products_count_to_be 1
-      end
-    end
-
-    context "product has category" do
-      before { create_products 1 }
-
-      # create a product with a different category
-      let!(:product_by_category) {
-        create(:simple_product, primary_taxon: create(:taxon, name: "Category 1"))
-      }
-
-      it "can search for a product" do
-        visit admin_products_url
-
-        search_by_category "Category 1"
-
-        expect(page).to have_content "1 products found for your search criteria. Showing 1 to 1."
-        expect(page).to have_select "category_id", selected: "Category 1"
-        expect_products_count_to_be 1
-        expect(page).to have_field "Name", with: product_by_category.name
-      end
-    end
-  end
-
   describe "columns"
 
   describe "updating" do