From 106bb7a27f9b09f6c61363ce4891c9c77bed8474 Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Mon, 20 Apr 2020 23:00:50 +0200 Subject: [PATCH] Rename some variables and add comments for clarity in cart_service --- app/services/cart_service.rb | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/app/services/cart_service.rb b/app/services/cart_service.rb index a7a48123d5..f47f27ccba 100644 --- a/app/services/cart_service.rb +++ b/app/services/cart_service.rb @@ -15,17 +15,17 @@ class CartService @distributor, @order_cycle = distributor_and_order_cycle @order.with_lock do - variants = read_variants from_hash - attempt_cart_add_variants variants - overwrite_variants variants unless !overwrite + variants_data = read_variants from_hash + attempt_cart_add_variants variants_data + overwrite_variants variants_data if overwrite end valid? end - def attempt_cart_add_variants(variants) - variants.each do |v| - if varies_from_cart(v) - attempt_cart_add(v[:variant_id], v[:quantity], v[:max_quantity]) + def attempt_cart_add_variants(variants_data) + variants_data.each do |variant_data| + if varies_from_cart(variant_data) + attempt_cart_add(variant_data[:variant_id], variant_data[:quantity], variant_data[:max_quantity]) end end end @@ -99,6 +99,7 @@ class CartService [@order.distributor, @order.order_cycle] end + # Returns true if the saved cart differs from what's in the posted data, otherwise false def varies_from_cart(variant_data) li = line_item_for_variant_id variant_data[:variant_id]