From 0ee1e2cd722e5e398b32096a1611e0860fb11a7f Mon Sep 17 00:00:00 2001 From: Pau Perez Date: Mon, 1 Feb 2021 14:43:31 +0100 Subject: [PATCH] Eager load taggings related to variant overrides This removes an N+1 with taggings but doesn't solve the one with tags. Using `includes(taggings: :base_tags)` based on https://github.com/mbleigh/acts-as-taggable-on/blob/47da5036dea61cb971bfaf72de5fa93c85255307/lib/acts_as_taggable_on/taggable.rb#L83-L84 wasn't enough to solve it and I got to stop here. This is scope-creeping too much. --- app/controllers/admin/variant_overrides_controller.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/app/controllers/admin/variant_overrides_controller.rb b/app/controllers/admin/variant_overrides_controller.rb index 3172201770..de58a3b514 100644 --- a/app/controllers/admin/variant_overrides_controller.rb +++ b/app/controllers/admin/variant_overrides_controller.rb @@ -75,6 +75,7 @@ module Admin def collection @variant_overrides = VariantOverride. + includes(:taggings). joins(variant: :product). preload(variant: :product). for_hubs(params[:hub_id] || @hubs)