From 0eb14bc0a4012e8f16774e25c23ae6f5930e5171 Mon Sep 17 00:00:00 2001 From: Pau Perez Date: Wed, 10 Mar 2021 16:22:22 +0100 Subject: [PATCH] Do not modify the HTML returned by Money gem It was due to these lines that we were returning a broken HTML tag but also, there's no need to remove blanks. --- lib/spree/money.rb | 8 +------- spec/lib/spree/money_spec.rb | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/spree/money.rb b/lib/spree/money.rb index 7ac0bd2722..994aceabb7 100644 --- a/lib/spree/money.rb +++ b/lib/spree/money.rb @@ -28,13 +28,7 @@ module Spree end def to_html(options = { html_wrap: true }) - output = @money.format(@options.merge(options)) - if options[:html_wrap] - # 1) prevent blank, breaking spaces - # 2) prevent escaping of HTML character entities - output = output.sub(" ", " ").html_safe - end - output + @money.format(@options.merge(options)).html_safe end def format(options = {}) diff --git a/spec/lib/spree/money_spec.rb b/spec/lib/spree/money_spec.rb index e1ab7663af..676572eff6 100644 --- a/spec/lib/spree/money_spec.rb +++ b/spec/lib/spree/money_spec.rb @@ -123,7 +123,7 @@ describe Spree::Money do money = Spree::Money.new(10) # The HTMLified version of the euro sign expect(money.to_html).to eq( - "10.00 " + "10.00 " ) end # rubocop:enable Layout/LineLength