From 0dd8959bf7bb6ee523f453507602b9dcfcffccc8 Mon Sep 17 00:00:00 2001 From: Rob Harrington Date: Wed, 12 Apr 2017 12:17:00 +1000 Subject: [PATCH] Use an actual completed order for OrdersController#order_to_update spec --- spec/controllers/spree/orders_controller_spec.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/spec/controllers/spree/orders_controller_spec.rb b/spec/controllers/spree/orders_controller_spec.rb index 3707bd194d..36e2182cd6 100644 --- a/spec/controllers/spree/orders_controller_spec.rb +++ b/spec/controllers/spree/orders_controller_spec.rb @@ -193,8 +193,6 @@ describe Spree::OrdersController do describe "#order_to_update" do let!(:current_order) { double(:current_order) } - let!(:order) { create(:order) } - let(:li) { order.line_items.first } let(:params) { { } } before do @@ -214,15 +212,15 @@ describe Spree::OrdersController do end context "and the order is not complete" do + let!(:order) { create(:order) } + it "returns the current_order" do expect(controller.send(:order_to_update)).to eq current_order end end context "and the order is complete" do - before do - allow(Spree::Order).to receive(:complete) { Spree::Order.where(id: order.id) } - end + let!(:order) { create(:completed_order_with_totals) } context "and the user doesn't have permisson to 'update' the order" do before { allow(controller).to receive(:can?).with(:update, order) { false } }