From 0cb2739139c0ec6f7b203b20cd10ff5d11488896 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Bellet Date: Tue, 8 Jun 2021 09:46:24 +0200 Subject: [PATCH] Handle case when price is not a number And return a `null` if so. --- .../admin/utils/filters/unlocalize_currency.js.coffee | 7 ++++++- .../unit/admin/filters/unlocalize_currency_spec.js.coffee | 3 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/admin/utils/filters/unlocalize_currency.js.coffee b/app/assets/javascripts/admin/utils/filters/unlocalize_currency.js.coffee index c8fe429bc3..59f0513193 100644 --- a/app/assets/javascripts/admin/utils/filters/unlocalize_currency.js.coffee +++ b/app/assets/javascripts/admin/utils/filters/unlocalize_currency.js.coffee @@ -18,4 +18,9 @@ angular.module("admin.utils").filter "unlocalizeCurrency", ()-> if (decimal_separator == ",") price = price.replace(",", ".") - return parseFloat(price) + price = parseFloat(price) + + if (isNaN(price)) + return null + + return price diff --git a/spec/javascripts/unit/admin/filters/unlocalize_currency_spec.js.coffee b/spec/javascripts/unit/admin/filters/unlocalize_currency_spec.js.coffee index 4b60c20de3..8a92d99b5e 100644 --- a/spec/javascripts/unit/admin/filters/unlocalize_currency_spec.js.coffee +++ b/spec/javascripts/unit/admin/filters/unlocalize_currency_spec.js.coffee @@ -129,3 +129,6 @@ describe 'convert string to number with configurated currency', -> it "undefined case ", -> expect(filter(undefined)).toEqual null + + it "wtf case", -> + expect(filter("wtf")).toEqual null