From 0c4f22f84722f7da07c7f3304c45aab963cf618d Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Thu, 20 Feb 2020 11:17:21 +0000 Subject: [PATCH] Fix images/new.js path and add simple spec to verify the page loads correctly Testing the file upload would be a bit more complicated --- app/views/spree/admin/images/new.html.haml | 2 +- spec/features/admin/products_spec.rb | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/views/spree/admin/images/new.html.haml b/app/views/spree/admin/images/new.html.haml index 22a1e01998..4026cef6fb 100644 --- a/app/views/spree/admin/images/new.html.haml +++ b/app/views/spree/admin/images/new.html.haml @@ -7,4 +7,4 @@ %span.or= t('spree.or') = link_to_with_icon 'icon-remove', t('spree.actions.cancel'), admin_product_images_url(@product), id: 'cancel_link', class: 'button' -= javascript_include_tag 'admin/images/new.js' += javascript_include_tag 'admin/spree/images/new.js' diff --git a/spec/features/admin/products_spec.rb b/spec/features/admin/products_spec.rb index 26c0af02ba..54c99ba8ea 100644 --- a/spec/features/admin/products_spec.rb +++ b/spec/features/admin/products_spec.rb @@ -203,6 +203,16 @@ feature ' expect(p.reload.property('fooprop')).to be_nil end + scenario "loading new image page", js: true do + product = create(:simple_product, supplier: @supplier2) + + visit spree.admin_product_images_path(product) + expect(page).to have_selector ".no-objects-found" + + page.find('a#new_image_link').click + expect(page).to have_selector "#image_attachment" + end + scenario "deleting product images", js: true do product = create(:simple_product, supplier: @supplier2) image = File.open(File.expand_path('../../../app/assets/images/logo-white.png', __dir__))