From 0c4e191f3bd8d18b9efbc405369384f2e4e3cf37 Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Tue, 18 May 2021 20:09:54 +0100 Subject: [PATCH] Render enterprise rows as a collection Note: this is a bit like an N+1 query, but for rendering. If there are 30 enterprises, the partial file would be loaded and parsed 30 times; but if we render it as a collection it'll load the partial once and substantially improve the performance. --- app/views/spree/admin/overview/_enterprises.html.haml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/views/spree/admin/overview/_enterprises.html.haml b/app/views/spree/admin/overview/_enterprises.html.haml index 1ffb68e8cb..e022623928 100644 --- a/app/views/spree/admin/overview/_enterprises.html.haml +++ b/app/views/spree/admin/overview/_enterprises.html.haml @@ -25,8 +25,7 @@ %span.centered.three.columns = t "spree_admin_enterprises_fees" %div.sixteen.columns.alpha.list - - @enterprises.each do |enterprise| - = render 'enterprise_row', { enterprise: enterprise } + = render partial: 'enterprise_row', collection: @enterprises, as: :enterprise %a.sixteen.columns.alpha.button.bottom.blue{ href: "#{main_app.admin_enterprises_path}" } = t "spree_admin_overview_enterprises_footer"