From 0aea14832abd13cd8612f0e904058a8a659573c8 Mon Sep 17 00:00:00 2001 From: Ana Nunes da Silva Date: Tue, 26 Mar 2024 11:06:47 +0000 Subject: [PATCH] Fix offense constant definition in block in validators/date_time_string_validator_spec.rb --- .rubocop_todo.yml | 1 - .../date_time_string_validator_spec.rb | 17 ++++++++--------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a1825eba7d..e1e44cee6f 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -11,7 +11,6 @@ # AllowedMethods: enums Lint/ConstantDefinitionInBlock: Exclude: - - 'spec/validators/date_time_string_validator_spec.rb' - 'spec/validators/integer_array_validator_spec.rb' # Offense count: 2 diff --git a/spec/validators/date_time_string_validator_spec.rb b/spec/validators/date_time_string_validator_spec.rb index 5476b0f6a0..a4b5d7a468 100644 --- a/spec/validators/date_time_string_validator_spec.rb +++ b/spec/validators/date_time_string_validator_spec.rb @@ -3,14 +3,6 @@ require "spec_helper" describe DateTimeStringValidator do - class TestModel - include ActiveModel::Validations - - attr_accessor :timestamp - - validates :timestamp, date_time_string: true - end - describe "internationalization" do it "has translation for NOT_STRING_ERROR" do expect(described_class.not_string_error).not_to be_blank @@ -22,7 +14,14 @@ describe DateTimeStringValidator do end describe "validation" do - let(:instance) { TestModel.new } + let(:instance) do + Class.new do + include ActiveModel::Validations + attr_accessor :timestamp + + validates :timestamp, date_time_string: true + end.new + end it "does not add error when nil" do instance.timestamp = nil