From 0663f045356b430bbcf800c6ba6770251a4afd4f Mon Sep 17 00:00:00 2001
From: Neal Chambers <macanudo@yahoo.com>
Date: Tue, 24 Oct 2023 09:42:23 +0900
Subject: [PATCH] Remove Simple References to Bogus Gateway

---
 app/controllers/spree/admin/payment_methods_controller.rb | 4 ----
 config/application.rb                                     | 2 --
 spec/controllers/admin/subscriptions_controller_spec.rb   | 3 +--
 spec/factories/payment_method_factory.rb                  | 5 -----
 spec/models/spree/payment_method_spec.rb                  | 2 --
 spec/services/order_syncer_spec.rb                        | 1 -
 6 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/app/controllers/spree/admin/payment_methods_controller.rb b/app/controllers/spree/admin/payment_methods_controller.rb
index 077cddbca8..37c8529f3d 100644
--- a/app/controllers/spree/admin/payment_methods_controller.rb
+++ b/app/controllers/spree/admin/payment_methods_controller.rb
@@ -128,10 +128,6 @@ module Spree
       def load_providers
         providers = Gateway.providers.sort_by(&:name)
 
-        unless Rails.env.development? || Rails.env.test?
-          providers.reject! { |provider| provider.name.include? "Bogus" }
-        end
-
         unless show_stripe?
           providers.reject! { |provider| stripe_provider?(provider) }
         end
diff --git a/config/application.rb b/config/application.rb
index 0d2ae298fc..52c77186c4 100644
--- a/config/application.rb
+++ b/config/application.rb
@@ -59,8 +59,6 @@ module Openfoodnetwork
     initializer "spree.register.payment_methods" do |app|
       Rails.application.reloader.to_prepare do
         app.config.spree.payment_methods = [
-          Spree::Gateway::Bogus,
-          Spree::Gateway::BogusSimple,
           Spree::PaymentMethod::Check
         ]
       end
diff --git a/spec/controllers/admin/subscriptions_controller_spec.rb b/spec/controllers/admin/subscriptions_controller_spec.rb
index 818a3a2e12..5f807d5110 100644
--- a/spec/controllers/admin/subscriptions_controller_spec.rb
+++ b/spec/controllers/admin/subscriptions_controller_spec.rb
@@ -767,12 +767,11 @@ describe Admin::SubscriptionsController, type: :controller do
       let!(:paypal) {
         Spree::Gateway::PayPalExpress.create!(name: "PayPalExpress", distributor_ids: [shop.id])
       }
-      let!(:bogus) { create(:bogus_payment_method, distributors: [shop]) }
 
       it "only loads Stripe and Cash payment methods" do
         controller.send(:load_form_data)
         expect(assigns(:payment_methods)).to include payment_method, stripe
-        expect(assigns(:payment_methods)).to_not include paypal, bogus
+        expect(assigns(:payment_methods)).to_not include paypal
       end
     end
   end
diff --git a/spec/factories/payment_method_factory.rb b/spec/factories/payment_method_factory.rb
index aadb01f9d6..98e8d36a35 100644
--- a/spec/factories/payment_method_factory.rb
+++ b/spec/factories/payment_method_factory.rb
@@ -18,11 +18,6 @@ FactoryBot.define do
     end
   end
 
-  factory :bogus_payment_method, class: Spree::Gateway::Bogus do
-    name { 'Credit Card' }
-    environment { 'test' }
-  end
-
   factory :stripe_sca_payment_method, class: Spree::Gateway::StripeSCA do
     name { 'StripeSCA' }
     environment { 'test' }
diff --git a/spec/models/spree/payment_method_spec.rb b/spec/models/spree/payment_method_spec.rb
index 2cc9de695e..e3a72dcb28 100644
--- a/spec/models/spree/payment_method_spec.rb
+++ b/spec/models/spree/payment_method_spec.rb
@@ -138,8 +138,6 @@ describe Spree::PaymentMethod do
       .to eq('Cash/EFT/etc. (payments for which automatic validation is not required)')
     expect(Spree::Gateway::PayPalExpress.clean_name).to eq('PayPal Express')
     expect(Spree::Gateway::StripeSCA.clean_name).to eq('Stripe SCA')
-    expect(Spree::Gateway::BogusSimple.clean_name).to eq('BogusSimple')
-    expect(Spree::Gateway::Bogus.clean_name).to eq('Bogus')
   end
 
   it "computes the amount of fees" do
diff --git a/spec/services/order_syncer_spec.rb b/spec/services/order_syncer_spec.rb
index 38c10b56c0..1c431eb9d2 100644
--- a/spec/services/order_syncer_spec.rb
+++ b/spec/services/order_syncer_spec.rb
@@ -88,7 +88,6 @@ describe OrderSyncer do
     let(:payment_method) { subscription.payment_method }
     let(:new_payment_method) { create(:payment_method, distributors: [subscription.shop]) }
     let(:invalid_payment_method) { create(:payment_method, distributors: [create(:enterprise)]) }
-    let(:bogus_payment_method) { create(:bogus_payment_method, distributors: [subscription.shop]) }
     let(:syncer) { OrderSyncer.new(subscription) }
 
     context "when the payment method on an order is the same as the subscription" do