From fd8973862e8066c88af32ed55747eb9bfef9c7c9 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Wed, 7 Aug 2024 13:50:51 +1000 Subject: [PATCH] Stabilise flaky spec with unique taxons The test was creating two "Soft Drinks" taxons and it was random which one was applied to a new product. Changing one taxon to a different one removes the ambiguity. --- .../spec/services/supplied_product_builder_spec.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/engines/dfc_provider/spec/services/supplied_product_builder_spec.rb b/engines/dfc_provider/spec/services/supplied_product_builder_spec.rb index 4b3fa4c445..c93f1f3f2b 100644 --- a/engines/dfc_provider/spec/services/supplied_product_builder_spec.rb +++ b/engines/dfc_provider/spec/services/supplied_product_builder_spec.rb @@ -176,12 +176,12 @@ RSpec.describe SuppliedProductBuilder do spree_product_id: variant.product.id ) end - let(:product_type) { DfcLoader.connector.PRODUCT_TYPES.DRINK.SOFT_DRINK } + let(:product_type) { DfcLoader.connector.PRODUCT_TYPES.DRINK.SOFT_DRINK.FRUIT_JUICE } let!(:new_taxon) { create( :taxon, - name: "Soft Drink", - dfc_id: "https://github.com/datafoodconsortium/taxonomies/releases/latest/download/productTypes.rdf#soft-drink" + name: "Fruit Juice", + dfc_id: "https://github.com/datafoodconsortium/taxonomies/releases/latest/download/productTypes.rdf#fruit-juice" ) }