From 032dce1a8876597ab58306a53f54f9b4a87e7324 Mon Sep 17 00:00:00 2001 From: Pau Perez Date: Fri, 29 May 2020 10:46:29 +0200 Subject: [PATCH] Move OC save within success block This makes more evident there are two scenarios: schedule save success or failure. We deal with OCs failures raising an exception. --- app/controllers/admin/schedules_controller.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/controllers/admin/schedules_controller.rb b/app/controllers/admin/schedules_controller.rb index 7b356701c9..39e1ffc625 100644 --- a/app/controllers/admin/schedules_controller.rb +++ b/app/controllers/admin/schedules_controller.rb @@ -34,10 +34,11 @@ module Admin end @schedule.attributes = permitted_resource_params - @schedule.save! - @schedule.order_cycle_ids = params[:order_cycle_ids] if @schedule.save + @schedule.order_cycle_ids = params[:order_cycle_ids] + @schedule.save! + sync_subscriptions_create flash[:success] = flash_message_for(@schedule, :successfully_created)