From 653804d14c442380411f8deee5d556c3d652ad68 Mon Sep 17 00:00:00 2001 From: luisramos0 Date: Fri, 17 Aug 2018 22:57:13 +0100 Subject: [PATCH 1/2] Make cookies test more stable --- spec/features/consumer/cookies_spec.rb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/spec/features/consumer/cookies_spec.rb b/spec/features/consumer/cookies_spec.rb index b9755ddc5a..e704004310 100644 --- a/spec/features/consumer/cookies_spec.rb +++ b/spec/features/consumer/cookies_spec.rb @@ -9,7 +9,9 @@ feature "Cookies", js: true do end scenario "does not show after cookies are accepted" do + sleep 1 click_button I18n.t('legal.cookies_banner.cookies_accept_button') + sleep 2 expect_not_visible_cookies_banner visit root_path @@ -18,6 +20,7 @@ feature "Cookies", js: true do scenario "banner contains cookies policy link that opens coookies policy page and closes banner" do find("p.ng-binding > a", :text => "cookies policy").click + sleep 1 expect_visible_cookies_policy_page expect_not_visible_cookies_banner From 00b8b0a36c8eadf481f7a460063732b58dcb5b55 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Thu, 23 Aug 2018 11:03:10 +1000 Subject: [PATCH 2/2] Sleep to avoid race conditions in cookie spec We tried a lot to avoid these sleep commands, but nothing worked. So it's better to have reliable specs than fast specs. --- spec/features/consumer/cookies_spec.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/spec/features/consumer/cookies_spec.rb b/spec/features/consumer/cookies_spec.rb index e704004310..e76559f4b4 100644 --- a/spec/features/consumer/cookies_spec.rb +++ b/spec/features/consumer/cookies_spec.rb @@ -15,12 +15,14 @@ feature "Cookies", js: true do expect_not_visible_cookies_banner visit root_path + sleep 1 expect_not_visible_cookies_banner end scenario "banner contains cookies policy link that opens coookies policy page and closes banner" do - find("p.ng-binding > a", :text => "cookies policy").click sleep 1 + find("p.ng-binding > a", :text => "cookies policy").click + sleep 2 expect_visible_cookies_policy_page expect_not_visible_cookies_banner