From 02a909c1b1f500277fa9c3c5366fdc8c34ddb8f2 Mon Sep 17 00:00:00 2001 From: Kristina Lim Date: Sat, 8 Sep 2018 23:10:06 +0800 Subject: [PATCH] Do not use image_tag for enterprise image previews If Rails config.assets.compile is false and config.assets.digest is true, which is the case for staging and production, image_tag fails when the image file is not found. We do not need sprockets to ensure presence of the image file for these tags, because the correct SRC values are assigned through the JS. Inserting HTML should be sufficient. --- app/views/admin/enterprises/form/_images.html.haml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/admin/enterprises/form/_images.html.haml b/app/views/admin/enterprises/form/_images.html.haml index d44e619cf6..0f48fce322 100644 --- a/app/views/admin/enterprises/form/_images.html.haml +++ b/app/views/admin/enterprises/form/_images.html.haml @@ -4,7 +4,7 @@ %br 100 x 100 pixels .omega.eight.columns - = image_tag '', class: 'image-field-group__preview-image', 'ng-src' => '{{ Enterprise.logo.medium }}', 'ng-if' => 'Enterprise.logo' + %img{ class: 'image-field-group__preview-image', ng: { src: '{{ Enterprise.logo.medium }}', if: 'Enterprise.logo' } } = f.file_field :logo %a.button.red{ href: '', ng: {click: 'removeLogo()', if: 'Enterprise.logo'} } = t('admin.enterprises.remove_logo.remove') @@ -20,7 +20,7 @@ = t('.promo_image_note3') .omega.eight.columns - = image_tag '', class: 'image-field-group__preview-image', 'ng-src' => '{{ Enterprise.promo_image.large }}', 'ng-if' => 'Enterprise.promo_image' + %img{ class: 'image-field-group__preview-image', ng: { src: '{{ Enterprise.promo_image.large }}', if: 'Enterprise.promo_image' } } = f.file_field :promo_image %a.button.red{ href: '', ng: {click: 'removePromoImage()', if: 'Enterprise.promo_image'} } = t('admin.enterprises.remove_promo_image.remove')