diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 3acb58cc25..ea841b8a8b 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 1400` -# on 2020-10-14 09:49:36 +0100 using RuboCop version 0.81.0. +# on 2020-10-30 17:18:53 +0000 using RuboCop version 0.81.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -27,19 +27,20 @@ Lint/UselessAccessModifier: - 'app/services/mail_configuration.rb' - 'lib/open_food_network/feature_toggle.rb' -# Offense count: 1 +# Offense count: 2 Lint/UselessAssignment: Exclude: - 'spec/**/*' - - 'lib/spree/core/controller_helpers/common.rb' - 'app/models/spree/taxon.rb' + - 'lib/spree/core/controller_helpers/common.rb' -# Offense count: 9 +# Offense count: 10 Naming/AccessorMethodName: Exclude: - 'app/controllers/spree/admin/taxonomies_controller.rb' - 'app/models/spree/adjustment.rb' - - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/order.rb' + - 'app/services/checkout/post_checkout_actions.rb' - 'lib/spree/core/controller_helpers/common.rb' - 'spec/support/request/shop_workflow.rb' - 'spec/support/request/web_helper.rb' @@ -59,7 +60,7 @@ Naming/MemoizedInstanceVariableName: - 'app/mailers/producer_mailer.rb' - 'lib/open_food_network/address_finder.rb' -# Offense count: 20 +# Offense count: 24 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ # ForbiddenPrefixes: is_, has_, have_ @@ -73,10 +74,11 @@ Naming/PredicateName: - 'app/models/order_cycle.rb' - 'app/models/spree/adjustment.rb' - 'app/models/spree/credit_card.rb' - - 'app/models/spree/line_item_decorator.rb' - - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/line_item.rb' + - 'app/models/spree/order.rb' - 'app/models/spree/payment_method.rb' - 'app/models/spree/preferences/file_configuration.rb' + - 'app/models/spree/preferences/preferable.rb' - 'app/models/spree/shipping_method.rb' - 'app/models/spree/user.rb' - 'lib/open_food_network/customers_report.rb' @@ -115,11 +117,12 @@ Rails/Date: - 'app/models/order_cycle.rb' - 'app/models/spree/credit_card.rb' -# Offense count: 1 +# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforceForPrefixed. Rails/Delegate: Exclude: + - 'app/models/spree/line_item.rb' - 'engines/order_management/app/services/order_management/reports/bulk_coop/renderers/html_renderer.rb' # Offense count: 16 @@ -152,13 +155,12 @@ Rails/FindBy: - 'app/models/product_import/spreadsheet_data.rb' - 'app/models/spree/user.rb' -# Offense count: 2 +# Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/FindEach: Exclude: - - 'app/models/spree/order_decorator.rb' - 'app/models/spree/shipment.rb' # Offense count: 9 @@ -169,13 +171,13 @@ Rails/HasAndBelongsToMany: - 'app/models/concerns/payment_method_distributors.rb' - 'app/models/enterprise.rb' - 'app/models/enterprise_group.rb' - - 'app/models/spree/line_item_decorator.rb' + - 'app/models/spree/line_item.rb' - 'app/models/spree/role.rb' - 'app/models/spree/shipping_method.rb' - 'app/models/spree/user.rb' - 'app/models/spree/zone.rb' -# Offense count: 35 +# Offense count: 38 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasManyOrHasOneDependent: @@ -186,9 +188,10 @@ Rails/HasManyOrHasOneDependent: - 'app/models/spree/address.rb' - 'app/models/spree/adjustment.rb' - 'app/models/spree/credit_card.rb' - - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/order.rb' - 'app/models/spree/payment_method.rb' - 'app/models/spree/property.rb' + - 'app/models/spree/return_authorization.rb' - 'app/models/spree/shipment.rb' - 'app/models/spree/shipping_category.rb' - 'app/models/spree/shipping_method.rb' @@ -237,7 +240,7 @@ Rails/LexicallyScopedActionFilter: - 'app/controllers/spree/users_controller.rb' - 'app/controllers/user_passwords_controller.rb' -# Offense count: 13 +# Offense count: 14 Rails/OutputSafety: Exclude: - 'app/controllers/spree/admin/reports_controller.rb' @@ -260,15 +263,16 @@ Rails/RakeEnvironment: - 'lib/capistrano/tasks/**/*.rake' - 'lib/tasks/specs.rake' -# Offense count: 9 +# Offense count: 11 Rails/ReflectionClassName: Exclude: - 'app/models/customer.rb' - 'app/models/distributor_shipping_method.rb' - 'app/models/enterprise_role.rb' + - 'app/models/spree/order.rb' - 'app/models/subscription.rb' -# Offense count: 243 +# Offense count: 247 # Configuration parameters: Blacklist, Whitelist. # Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters Rails/SkipsModelValidations: @@ -287,7 +291,8 @@ Rails/SkipsModelValidations: - 'app/models/spree/address.rb' - 'app/models/spree/adjustment.rb' - 'app/models/spree/credit_card.rb' - - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/inventory_unit.rb' + - 'app/models/spree/order.rb' - 'app/models/spree/payment.rb' - 'app/models/spree/shipment.rb' - 'app/models/spree/shipping_method.rb' @@ -325,7 +330,6 @@ Rails/SkipsModelValidations: - 'spec/features/admin/order_cycles/complex_editing_spec.rb' - 'spec/features/admin/order_cycles/simple_spec.rb' - 'spec/features/admin/order_spec.rb' - - 'spec/features/admin/payments_spec.rb' - 'spec/features/admin/reports_spec.rb' - 'spec/features/consumer/caching/shops_caching_spec.rb' - 'spec/features/consumer/shopping/checkout_spec.rb' @@ -346,6 +350,7 @@ Rails/SkipsModelValidations: - 'spec/models/spree/adjustment_spec.rb' - 'spec/models/spree/asset_spec.rb' - 'spec/models/spree/line_item_spec.rb' + - 'spec/models/spree/order_inventory_spec.rb' - 'spec/models/spree/order_spec.rb' - 'spec/models/spree/tax_category_spec.rb' - 'spec/models/spree/variant_spec.rb' @@ -378,7 +383,7 @@ Rails/UniqueValidationWithoutIndex: # Environments: development, test, production Rails/UnknownEnv: Exclude: - - 'app/models/spree/app_configuration_decorator.rb' + - 'app/models/spree/app_configuration.rb' - 'lib/spree/core/controller_helpers/ssl.rb' # Offense count: 2 @@ -387,7 +392,7 @@ Style/CaseEquality: - 'app/helpers/angular_form_helper.rb' - 'spec/models/spree/payment_spec.rb' -# Offense count: 64 +# Offense count: 29 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle. # SupportedStyles: nested, compact @@ -401,6 +406,7 @@ Style/ClassAndModuleChildren: - 'app/models/tag_rule/filter_order_cycles.rb' - 'app/models/tag_rule/filter_payment_methods.rb' - 'app/models/tag_rule/filter_shipping_methods.rb' + - 'app/serializers/api/address_serializer.rb' - 'app/serializers/api/country_serializer.rb' - 'app/serializers/api/currency_config_serializer.rb' - 'app/serializers/api/current_order_serializer.rb' @@ -434,7 +440,7 @@ Style/FormatStringToken: - 'lib/open_food_network/sales_tax_report.rb' - 'spec/features/admin/bulk_order_management_spec.rb' -# Offense count: 818 +# Offense count: 765 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -626,13 +632,10 @@ Style/FrozenStringLiteralComment: - 'app/models/product_import/unit_converter.rb' - 'app/models/proxy_order.rb' - 'app/models/schedule.rb' - - 'app/models/spree/app_configuration_decorator.rb' - 'app/models/spree/gateway/migs.rb' - 'app/models/spree/gateway/pin.rb' - 'app/models/spree/gateway/stripe_connect.rb' - - 'app/models/spree/line_item_decorator.rb' - 'app/models/spree/option_type_decorator.rb' - - 'app/models/spree/order_decorator.rb' - 'app/models/spree/preferences/file_configuration.rb' - 'app/models/spree/price_decorator.rb' - 'app/models/spree/product_decorator.rb' @@ -821,7 +824,6 @@ Style/FrozenStringLiteralComment: - 'lib/spree/authentication_helpers.rb' - 'lib/spree/localized_number.rb' - 'lib/spree/money_decorator.rb' - - 'lib/spree/product_filters.rb' - 'lib/stripe/account_connector.rb' - 'lib/stripe/profile_storer.rb' - 'lib/stripe/webhook_handler.rb' @@ -889,6 +891,7 @@ Style/FrozenStringLiteralComment: - 'spec/controllers/shops_controller_spec.rb' - 'spec/controllers/spree/admin/adjustments_controller_spec.rb' - 'spec/controllers/spree/admin/base_controller_spec.rb' + - 'spec/controllers/spree/admin/general_settings_controller_spec.rb' - 'spec/controllers/spree/admin/invoices_controller_spec.rb' - 'spec/controllers/spree/admin/mail_methods_controller_spec.rb' - 'spec/controllers/spree/admin/orders/customer_details_controller_spec.rb' @@ -1042,7 +1045,6 @@ Style/FrozenStringLiteralComment: - 'spec/lib/open_food_network/users_and_enterprises_report_spec.rb' - 'spec/lib/open_food_network/xero_invoices_report_spec.rb' - 'spec/lib/spree/localized_number_spec.rb' - - 'spec/lib/spree/product_filters_spec.rb' - 'spec/lib/stripe/account_connector_spec.rb' - 'spec/lib/stripe/webhook_handler_spec.rb' - 'spec/lib/tasks/enterprises_rake_spec.rb' @@ -1086,7 +1088,6 @@ Style/FrozenStringLiteralComment: - 'spec/models/spree/classification_spec.rb' - 'spec/models/spree/credit_card_spec.rb' - 'spec/models/spree/gateway/stripe_connect_spec.rb' - - 'spec/models/spree/image_spec.rb' - 'spec/models/spree/line_item_spec.rb' - 'spec/models/spree/order/checkout_spec.rb' - 'spec/models/spree/order_spec.rb' @@ -1193,7 +1194,6 @@ Style/FrozenStringLiteralComment: - 'spec/support/products_helper.rb' - 'spec/support/request/admin_helper.rb' - 'spec/support/request/authentication_helper.rb' - - 'spec/support/request/checkout_helper.rb' - 'spec/support/request/cookie_helper.rb' - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/menu_helper.rb' @@ -1212,7 +1212,7 @@ Style/FrozenStringLiteralComment: - 'spec/views/spree/admin/payment_methods/index.html.haml_spec.rb' - 'spec/views/spree/admin/shared/_order_links.html.haml_spec.rb' -# Offense count: 48 +# Offense count: 44 # Configuration parameters: MinBodyLength. Style/GuardClause: Exclude: @@ -1228,7 +1228,7 @@ Style/GuardClause: - 'app/models/enterprise.rb' - 'app/models/enterprise_group.rb' - 'app/models/producer_property.rb' - - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/preferences/preferable_class_methods.rb' - 'app/models/spree/price_decorator.rb' - 'app/models/spree/product_decorator.rb' - 'app/services/order_syncer.rb' @@ -1237,15 +1237,15 @@ Style/GuardClause: - 'lib/open_food_network/order_cycle_form_applicator.rb' - 'lib/open_food_network/rack_request_blocker.rb' - 'spec/support/delayed_job_helper.rb' - - 'spec/support/request/checkout_helper.rb' - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/shop_workflow.rb' -# Offense count: 2 +# Offense count: 3 Style/MissingRespondToMissing: Exclude: - 'app/helpers/application_helper.rb' - 'app/models/spree/gateway.rb' + - 'app/models/spree/preferences/configuration.rb' # Offense count: 2 Style/MixinUsage: @@ -1253,7 +1253,7 @@ Style/MixinUsage: - 'lib/open_food_network/orders_and_fulfillments_report.rb' - 'spec/lib/open_food_network/packing_report_spec.rb' -# Offense count: 36 +# Offense count: 43 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. # SupportedStyles: predicate, comparison @@ -1267,8 +1267,11 @@ Style/NumericPredicate: - 'app/models/product_import/product_importer.rb' - 'app/models/product_import/spreadsheet_entry.rb' - 'app/models/spree/gateway/stripe_connect.rb' - - 'app/models/spree/line_item_decorator.rb' - - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/line_item.rb' + - 'app/models/spree/order.rb' + - 'app/models/spree/order_contents.rb' + - 'app/models/spree/order_inventory.rb' + - 'app/models/spree/preferences/preferable.rb' - 'app/models/spree/user.rb' - 'app/models/variant_override.rb' - 'app/services/cart_service.rb' @@ -1281,7 +1284,7 @@ Style/NumericPredicate: - 'lib/spree/money_decorator.rb' - 'lib/tasks/sample_data.rake' -# Offense count: 231 +# Offense count: 241 Style/Send: Exclude: - 'spec/controllers/admin/subscriptions_controller_spec.rb' @@ -1306,8 +1309,10 @@ Style/Send: - 'spec/models/enterprise_spec.rb' - 'spec/models/exchange_spec.rb' - 'spec/models/spree/gateway/stripe_connect_spec.rb' + - 'spec/models/spree/order_inventory_spec.rb' - 'spec/models/spree/order_spec.rb' - 'spec/models/spree/payment_spec.rb' + - 'spec/models/spree/return_authorization_spec.rb' - 'spec/models/spree/tax_rate_spec.rb' - 'spec/models/tag_rule/discount_order_spec.rb' - 'spec/models/tag_rule/filter_order_cycles_spec.rb' @@ -1325,3 +1330,11 @@ Style/Send: Style/StructInheritance: Exclude: - 'lib/open_food_network/enterprise_fee_applicator.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: IgnoredMethods. +# IgnoredMethods: respond_to, define_method +Style/SymbolProc: + Exclude: + - 'app/models/spree/preferences/preferable.rb'