From 00e171a8f1424f7b00cfe4f9bb04b529cc6033f9 Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Tue, 16 May 2023 11:14:40 +1000
Subject: [PATCH] Reduce indentation in report spec

Specs should also test from the outside instead of declaring modules and
test from within those modules.
---
 ...rders_cycle_supplier_totals_report_spec.rb | 166 +++++++++---------
 1 file changed, 81 insertions(+), 85 deletions(-)

diff --git a/spec/lib/reports/orders_and_fulfillment/orders_cycle_supplier_totals_report_spec.rb b/spec/lib/reports/orders_and_fulfillment/orders_cycle_supplier_totals_report_spec.rb
index b70a8f6ea7..25b164fd6a 100644
--- a/spec/lib/reports/orders_and_fulfillment/orders_cycle_supplier_totals_report_spec.rb
+++ b/spec/lib/reports/orders_and_fulfillment/orders_cycle_supplier_totals_report_spec.rb
@@ -2,101 +2,97 @@
 
 require 'spec_helper'
 
-module Reporting
-  module Reports
-    module OrdersAndFulfillment
-      describe OrderCycleSupplierTotals do
-        let!(:distributor) { create(:distributor_enterprise) }
+describe Reporting::Reports::OrdersAndFulfillment::OrderCycleSupplierTotals do
+  let!(:distributor) { create(:distributor_enterprise) }
 
-        let!(:order) do
-          create(:completed_order_with_totals, line_items_count: 1, distributor: distributor)
-        end
-        let!(:supplier) do
-          order.line_items.first.variant.product.supplier
-        end
-        let(:current_user) { distributor.owner }
-        let(:params) { { display_summary_row: false, fields_to_hide: [] } }
-        let(:report) do
-          OrderCycleSupplierTotals.new(current_user, params)
-        end
+  let!(:order) do
+    create(:completed_order_with_totals, line_items_count: 1, distributor: distributor)
+  end
+  let!(:supplier) do
+    order.line_items.first.variant.product.supplier
+  end
+  let(:current_user) { distributor.owner }
+  let(:params) { { display_summary_row: false, fields_to_hide: [] } }
+  let(:report) do
+    described_class.new(current_user, params)
+  end
 
-        let(:table_headers) do
-          report.table_headers
-        end
+  let(:table_headers) do
+    report.table_headers
+  end
 
-        let(:report_table) do
-          report.table_rows
-        end
+  let(:report_table) do
+    report.table_rows
+  end
 
-        it "generates the report" do
-          expect(report_table.length).to eq(1)
-        end
-        context "with a VAT/GST-free supplier" do
-          before(:each) do
-            supplier.update(charges_sales_tax: false)
-          end
+  it "generates the report" do
+    expect(report_table.length).to eq(1)
+  end
 
-          it "has a variant row when product belongs to a tax category" do
-            product_tax_category_name = order.line_items.first.variant.product.tax_category.name
+  context "with a VAT/GST-free supplier" do
+    before(:each) do
+      supplier.update(charges_sales_tax: false)
+    end
 
-            supplier_name_field = report_table.first[0]
-            supplier_vat_status_field = report_table.first[-2]
-            product_tax_category_field = report_table.first[-1]
+    it "has a variant row when product belongs to a tax category" do
+      product_tax_category_name = order.line_items.first.variant.product.tax_category.name
 
-            expect(supplier_name_field).to eq supplier.name
-            expect(supplier_vat_status_field).to eq "No"
-            expect(product_tax_category_field).to eq product_tax_category_name
-          end
+      supplier_name_field = report_table.first[0]
+      supplier_vat_status_field = report_table.first[-2]
+      product_tax_category_field = report_table.first[-1]
 
-          it "has a variant row when product doesn't belong to a tax category" do
-            order.line_items.first.variant.product.update(tax_category_id: nil)
-            supplier_name_field = report_table.first[0]
-            supplier_vat_status_field = report_table.first[-2]
-            product_tax_category_field = report_table.first[-1]
+      expect(supplier_name_field).to eq supplier.name
+      expect(supplier_vat_status_field).to eq "No"
+      expect(product_tax_category_field).to eq product_tax_category_name
+    end
 
-            expect(supplier_name_field).to eq supplier.name
-            expect(supplier_vat_status_field).to eq "No"
-            expect(product_tax_category_field).to eq "none"
-          end
-        end
-        context "with a VAT/GST-enabled supplier" do
-          before(:each) do
-            supplier.update(charges_sales_tax: true)
-          end
+    it "has a variant row when product doesn't belong to a tax category" do
+      order.line_items.first.variant.product.update(tax_category_id: nil)
+      supplier_name_field = report_table.first[0]
+      supplier_vat_status_field = report_table.first[-2]
+      product_tax_category_field = report_table.first[-1]
 
-          it "has a variant row when product belongs to a tax category" do
-            product_tax_category_name = order.line_items.first.variant.product.tax_category.name
-
-            supplier_name_field = report_table.first[0]
-            supplier_vat_status_field = report_table.first[-2]
-            product_tax_category_field = report_table.first[-1]
-
-            expect(supplier_name_field).to eq supplier.name
-            expect(supplier_vat_status_field).to eq "Yes"
-            expect(product_tax_category_field).to eq product_tax_category_name
-          end
-
-          it "has a variant row when product doesn't belong to a tax category" do
-            order.line_items.first.variant.product.update(tax_category_id: nil)
-            supplier_name_field = report_table.first[0]
-            supplier_vat_status_field = report_table.first[-2]
-            product_tax_category_field = report_table.first[-1]
-
-            expect(supplier_name_field).to eq supplier.name
-            expect(supplier_vat_status_field).to eq "Yes"
-            expect(product_tax_category_field).to eq "none"
-          end
-        end
-
-        it "includes sku column" do
-          variant_sku = order.line_items.first.variant.sku
-          last_column_title = table_headers[-3]
-          first_row_last_column_value = report_table.first[-3]
-
-          expect(last_column_title).to eq "SKU"
-          expect(first_row_last_column_value).to eq variant_sku
-        end
-      end
+      expect(supplier_name_field).to eq supplier.name
+      expect(supplier_vat_status_field).to eq "No"
+      expect(product_tax_category_field).to eq "none"
     end
   end
+
+  context "with a VAT/GST-enabled supplier" do
+    before(:each) do
+      supplier.update(charges_sales_tax: true)
+    end
+
+    it "has a variant row when product belongs to a tax category" do
+      product_tax_category_name = order.line_items.first.variant.product.tax_category.name
+
+      supplier_name_field = report_table.first[0]
+      supplier_vat_status_field = report_table.first[-2]
+      product_tax_category_field = report_table.first[-1]
+
+      expect(supplier_name_field).to eq supplier.name
+      expect(supplier_vat_status_field).to eq "Yes"
+      expect(product_tax_category_field).to eq product_tax_category_name
+    end
+
+    it "has a variant row when product doesn't belong to a tax category" do
+      order.line_items.first.variant.product.update(tax_category_id: nil)
+      supplier_name_field = report_table.first[0]
+      supplier_vat_status_field = report_table.first[-2]
+      product_tax_category_field = report_table.first[-1]
+
+      expect(supplier_name_field).to eq supplier.name
+      expect(supplier_vat_status_field).to eq "Yes"
+      expect(product_tax_category_field).to eq "none"
+    end
+  end
+
+  it "includes sku column" do
+    variant_sku = order.line_items.first.variant.sku
+    last_column_title = table_headers[-3]
+    first_row_last_column_value = report_table.first[-3]
+
+    expect(last_column_title).to eq "SKU"
+    expect(first_row_last_column_value).to eq variant_sku
+  end
 end