From 0091a60a6e043241baf3aace8ce4dd71f6bb6b21 Mon Sep 17 00:00:00 2001
From: David Cook <david@redcliffs.net>
Date: Wed, 6 Sep 2023 12:26:14 +1000
Subject: [PATCH] Install rubocop-rspec

Why not enforce more consistency in our specs also?

Some of them generated way too many violations, so I relaxed them a bit.
---
 .github/workflows/linters.yml | 4 +++-
 .rubocop.yml                  | 4 +++-
 .rubocop_styleguide.yml       | 6 ++++++
 Gemfile                       | 1 +
 Gemfile.lock                  | 9 +++++++++
 5 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml
index fa30eb7d99..7db6afae12 100644
--- a/.github/workflows/linters.yml
+++ b/.github/workflows/linters.yml
@@ -18,7 +18,9 @@ jobs:
         uses: reviewdog/action-rubocop@v2
         with:
           rubocop_version: gemfile
-          rubocop_extensions: rubocop-rails:gemfile
+          rubocop_extensions:
+            - rubocop-rails:gemfile
+            - rubocop-rspec:gemfile
           reporter: github-pr-check
           level: error
           fail_on_error: true
diff --git a/.rubocop.yml b/.rubocop.yml
index 779460f826..4241ba03ce 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -4,7 +4,9 @@
 #
 # The configuration is split into three files. Look into those files for more details.
 #
-require: rubocop-rails
+require:
+  - rubocop-rails
+  - rubocop-rspec
 inherit_from:
 
   # The automatically generated todo list to ignore all current violations.
diff --git a/.rubocop_styleguide.yml b/.rubocop_styleguide.yml
index 0264a99261..3fc2a87938 100644
--- a/.rubocop_styleguide.yml
+++ b/.rubocop_styleguide.yml
@@ -125,6 +125,12 @@ Rails/SkipsModelValidations:
     - update_column
     - update_columns
 
+RSpec/MultipleExpectations:
+  Max: 5 # Default 1
+
+RSpec/MultipleMemoizedHelpers:
+  Max: 10 # Default 5
+
 Style/Documentation:
   Enabled: false
 
diff --git a/Gemfile b/Gemfile
index fba0e12183..23e8f60e4b 100644
--- a/Gemfile
+++ b/Gemfile
@@ -186,6 +186,7 @@ group :development do
   gem 'rails-erd'
   gem 'rubocop'
   gem 'rubocop-rails'
+  gem 'rubocop-rspec'
   gem 'spring'
   gem 'spring-commands-rspec'
   gem 'spring-commands-rubocop'
diff --git a/Gemfile.lock b/Gemfile.lock
index 1ad8fc4062..a44926e28d 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -655,11 +655,19 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.30.0)
       parser (>= 3.2.1.0)
+    rubocop-capybara (2.18.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.23.1)
+      rubocop (~> 1.33)
     rubocop-rails (2.23.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
       rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-rspec (2.23.2)
+      rubocop (~> 1.33)
+      rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
     ruby-graphviz (1.2.5)
       rexml
     ruby-progressbar (1.13.0)
@@ -918,6 +926,7 @@ DEPENDENCIES
   rswag-ui
   rubocop
   rubocop-rails
+  rubocop-rspec
   sd_notify
   select2-rails!
   shoulda-matchers