From 0002b2e0190258af6620bd6bf1499660c909cf2e Mon Sep 17 00:00:00 2001 From: wandji20 Date: Tue, 3 Sep 2024 14:59:06 +0100 Subject: [PATCH] Clean up hardcoded values and improve readability --- .../controllers/guest_checkout_controller.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/app/webpacker/controllers/guest_checkout_controller.js b/app/webpacker/controllers/guest_checkout_controller.js index 189505f207..c366f02553 100644 --- a/app/webpacker/controllers/guest_checkout_controller.js +++ b/app/webpacker/controllers/guest_checkout_controller.js @@ -21,6 +21,10 @@ export default class extends Controller { } } + disconnect() { + this.removeUnloadEvent(); + } + login() { window.dispatchEvent(new Event("login:modal:open")); } @@ -40,10 +44,8 @@ export default class extends Controller { } handlePageUnload(event) { - event.preventDefault() - - event.returnValue = 'I18n.t("admin.unsaved_confirm_leave")'; - return + event.preventDefault(); + event.returnValue = I18n.t("admin.unsaved_confirm_leave"); } removeUnloadEvent() { @@ -51,8 +53,4 @@ export default class extends Controller { window.removeEventListener('beforeunload', this.handlePageUnload); } } - - disconnect() { - this.removeUnloadEvent(); - } }